Would it be possible to request a compatibility mod for this and W3EE/Redux? This is a visually essential mod I'd say, but like you write EE changes .xmls extensively.
Hi, I'm using the Ghost Mode version of the mod and BiA. I cannot for the life of me make the mod work for the Gesheft sword (Dark Souls easter egg "Unique silver sword".. I gave the mod priority manually, I changed it's name to load first in the mods folder, I even merged and selected the scabbard changes in the .xml's. It only works if I remove all other mods :)) Can you help me with a separate file for this one sword or advice on how to make it work properly? I also use All NPC scabbard mod.
I read what you wrote in regards to addressing the conflict w/ your other mod "The Essential Weapon Rework Mod",
If you're using my Scabbard Clipping Fix mod, you will need to merge it with this mod. When there is a conflict, select all the lines from this mod, except if it asks you about scabbards. In that case, select the line from the Scabbard Clipping Fix mod. Every other line should come from this mod.
but it is not clear, at all. Unless I'm missing something obvious, practically every merge has the word scabbard in it (thought maybe it was a conflict w/ another mod, but I don't have any sword mods installed to my knowledge, other than the widely used "All NPC Scabbards")... TIA
It's only if Script Merger ask you to merge manually. The author recommend to select Scabbard Clipping Fix if you wish the fix, or the the other mod if you wish its changes.
If you're using my Essential Weapon Rework mod and this mod, then you need to merge them both. Select all the lines about stats and other info from Essential Weapon mod. And only select the lines about Scabbards, if asked, from this mod. That's all.
I appreciate the help from each of you but I'm not sure if there's a language barrier or something, cause I don't know how much clearer I can be. Hopefully the screenshots will help.
I understand they need to be merged. You just said "And only select the lines about Scabbards, if asked, from this mod. That's all". What I'm saying is, there definitely ARE conflicts. No "if". And EVERY SINGLE one is from THIS mod. There are no other conflicts (at least for me w/ my mods). But again, in the description for your other mod, you wrote "When there is a conflict, select all the lines from this mod, except if it asks you about scabbards". Not IF, but WHEN. That was the word you used, implying there ARE conflicts that are NOT from this scabbards mod. However, the same line states "except if it asks you about scabbards". There is no "if"; it DOES ask about scabbards. Hence my confusion; I assumed (wrongly?) that you would know that your own mod, conflicts with your other mod...
I don't know if they're about stats or not; I'm not a modder (wouldn't be asking this question in the first place if I was). Some of them have numbers, but it looks like it's prolly a naming system. My guess is to select the lines from this mod, "Scabbard Clipping Fix", but due to the language used on the description page of "The Essential Weapon Rework Mod" as mentioned above, I've been hesitant to conclude that. Thank you for your help.
I'm British and the sentence Zowbaid wrote is correct. The way we speak require logic comprehension. Similar as we code or resolve mathematic problem.
The IF for "And only select the lines about Scabbards, if asked, from this mod. That's all", implies only the conditions are reach, in the case when Script Merger ask you. It doesn't mean if "there definitely ARE conflicts [...] And EVERY SINGLE one is from THIS mod". But only IF Script Merger ASKS you to resolve the conflict.
Then the When for "When there is a conflict, select all the lines from this mod, except if it asks you about scabbards". This one implies the expectation or not. It doesn't imply "there ARE conflicts that are NOT from this scabbards mod", but only one possibilities that Script Merger detect a merge conflict between this scabbards mod and another mod.
And so, if the When condition are met. Then another condition are to be met which is "except if it asks you about scabbards". Again, it implies one of the conditions are reach or not, not systemically true as you thought "There is no "if"; it DOES ask about scabbards". The meaning is the same as the first quote. It's IF Script Merger ASKS you to resolve the conflict.
"When" and "If" are somehow similar but they don't have an exact same definition. And of course one mod ARE in conflict to another mod. Though Zowbaid was talking about "merge conflict" during the process of Script Merger, not the question of "is this mod in conflict to another one?".
Now for the main problem I can't help with the provided pics because you active the setting "show the path line from each mods". I can't tell which one is Scabbard Clipping Fix mod or another mod.
@TBoner101. Ok, let's start at a more basic level. Basically, when you go into Script Merger, you HAVE to merge this mod with Essential Weapon Rework mod because they WILL 100% conflict. You have to merge them if you want the stats from that mod and the scabbards from this mod. Now, in the screenshot you posted, you're showing a conflict with a scabbard. You can tell because it's highlighted and it when comparing windows B and C, you can see that Window B says scabbard_silver_2_02, and the Window C says scabbard_silver_lynx_01. The one on the right (window C) is from this mod (Scabbard Clipping Fix mod), which is the line you want. So always select C when you have conflicts with scabbards. Every other conflict that is NOT scabbard-related (such as weapon stats), select the line from Essential Weapons Rework mod (should be Window B).
Also, judging from those screenshots, it looks like you're using an older version of Essential Weapons Rework. If you download the latest version, it should make merging the scabbards more seamless, hopefully without even needing to select B or C.
Thanks for the detailed response. I mean, citizenship/residency doesn't necessarily correlate to fluency within the native language. I have friends/family who immigrated to America and have lived here for > half their lives, are barely understandable, and still struggle to communicate. At the same time, I know people from other countries who speak better English than me.
Respectfully, I often see you helping out on various mod pages by answering questions (which is great), but get confused reading your comments quite frequently. There are several grammatical errors not explained by brevity or slang in your reply and TBH, I don't understand the majority of it (and nor do I think I'm alone either). I don't wanna be a grammar nazi but even your statement ironically proclaiming your communication is comprehensible (an admittedly biased opinion), "The way we speak require logic comprehension", is wrong. It should be "requires logical comprehension". Perhaps most important, though, is this,
?Similar as we code or resolve mathematic problem.
The thing is, we aren't coding or resolving mathematical problems now, are we? If/when isn't an if/then statement.
Anyway, all I was trying to say was that Script Merger did ask me to resolve a conflict with Essential Weapon Rework mod, and it was from this scabbards fix, as evidenced by the screenshots. I DO appreciate your help tho, just in case that wasn't clear. Cheers
Ah, gotcha. I understand now. Good looking out on the old version of Essential Weapon Rework Mod. I didn't see your update, but am now tracking it (and endorsed, ofc). Just to confirm, I should NOT merge Essential Weapon Rework mod with BiA or LfSS, but give it priority over them, right?
I appreciate your help, the mods (and time spent making them), and patience in dealing w/ me making things more complicated than they needed to be. Thanks, bud!
So yes, basically if you're using Essential Weapons Rework, just give it priority over BiA and LfSS, that's right. Since this Scabbard Clipping Fix is a part of LfSS essentially but with a few additions to scabbards, then giving this priority over that is all you need to do. And then Essential Weapons Rework only needs to merge with Scabbards Clipping Fix, since it would be redundant to merge it with LfSS if Scabbard Clipping Fix already has priority over it, you know? It won't even make a difference to do so. Now, BiA is a bug fix mod, so it doesn't apply at all to any mods that change similar files because the other mods will be doing something "new" or "different", in which case you can completely ignore the conflicts and just give priority to the other mods. BiA is meant primarily as a bug fix for the vanilla game, so it can usually be ignored when it's conflicting with mods affecting the same files, giving BiA lower priority.
If you want kind of a priority overview for these mods, it should be something like this:
1. Scabbard Clipping Fix (merged with Essential Weapons Rework) 2. Essential Weapons Rework (merged with Scabbard Clipping Fix)
3. LfSS2.0 4. BiA
Or, you can flip 1 and 2, since they're interchangeable and have to be merged anyway. The most important thing is that they have to have priority over 3 and 4.
Makes perfect sense. Any questions I had were answered by the priority overview at the end. That's interesting to hear about BiA; other than lighting/weather mods, yours was the only one I had above of BiA. This isn't directed at you but an observation I made shortly after installing a few mods for this game (this is the 1st game I've modded), is practically every modder says to give theirs the highest priority, something which I've always found to be comical.
You've been incredibly helpful and your time is very much appreciated. Cheers mate!
Even when he said he was British, I didn't believe him. Maybe as a citizen, but he clearly speaks ESL. Not that there's nothing wrong w/ that (ofc), UNLESS you're attempting to correct someone else's grammar and understanding of the language, specifically me, who happens to be a native English speaker.
I read his post again and still can't understand anything between the first and last paragraph.
Hey bro I merged the xml conflicts between your Essential Weapon Rework and Fixed Scabbards choosing the first in every conflict except If scabbards were mentioned where I chose the latter But this caused the crafting menu of the Oxenfurt blacksmith to not have any swords to craft and all the other items (ingredients etc) to be invisible Maybe this has affected other blacksmiths, to tell you the truth I have not checked
That sounds crazy, there is no way this mod would affect blacksmiths or any shops. They only affect the weapon files. So weapons shouldn't vanish from anywhere.
I'm positive that was the reason since when I unmerged the merges between the two mods I booted the game and the crafting menu was OK And when I merged them again it was bugged all over again
I'm trying to merge all three mods, this, Essential Weapon Rework, and LfSS. The description states to merge the "def_item_crafting_weapons.xml and def_item_weapons_relic.xml" but it doesn't mention which ones. All of them? Script merger shows that I have that xml in the following locations:
Are those all different or just different merges of the same file (obv relic is separate, I'm referring to def_item_crafting_weapons.xml)? These are all on the left side of script merger so they're not past merges.
I've never encountered this issue with scabbards. But if that mod edits a mesh of a scabbard that isn't used in this mod, then it should work no problems. I myself don't use that mod and I haven't noticed any shading issues on my end. So you can test it out if you like.
Having an issue with the scabbard for the viper swords. At firt i thought this was a conflict with lfss but changing priority made no difference. Even after installing this mod alone the scabbard is not correct as seen on the pic. lfss alone also does not have this issue either. https://imgur.com/a/IQwvArG
The silver sword hilt is clipping into the top part of the scabbard. In your pictures you show an example of this being resolved in picture 9. The scabbard mesh is too wide and long if you look closer.
This is a picture only using lfss for reference https://imgur.com/k8ZpUMI
Also this is vanilla with no mods https://imgur.com/4npiu1i
It seems like there's a different sword in that scabbard in those pictures. In one, it just looks like a regular silver sword, and in the other it has the Venmous Viper Sword model. Can you show me that one to see if it clips? It seems like that scabbard model might just have an issue with that particular sword. Becase it's one of the scabbards that got got widened to fit certain swords since other swords use that same scabbard. It's not specific to Viper Sword only. Seems like it's used with other weapons as well.
For reference, here's another sword that uses the exact same scabbard, as you can see it doesn't have that clipping issue you mentioned. https://postimg.cc/TK65jLz2 Some swords have crossguards that clip into the tops of the scabbards unfortunately and yes it's really annoying, but it's a really small price to pay for fixing the overall broken clipping that existed before. By widening the scabbards up top, it unfortunately led to some small clipping with certain swords. But as I said, some swords don't have this issue at all. It all depends on the sword and the scabbard. My Viper sword hardly clips at all into the the same scabbard. It doesn't look like your screenshots. So yeah, try the Venomous Viper sword and see how it looks.
its the same sword in all pics and it is the level 1 requirement viper silver sword you craft early on in white orchard. I think lfss changed the handle making it appear different
Sounds like you are losing the new Viper sword model. BiA fixes this. If you have a conflict issue, check in script merger and find the .xml in this path dlc/ep1/data/gameplay/items/def_item_crafting_weapons.xml. You might have an issue there. If you do, merge the conflicts so you get the correct sword in the scabbard.
Alright, I uploaded a new version that fixes the clipping with those 2 swords specifically. The Viper silver sword and Venomous Viper silver sword cuz they were clipping more than other swords. Should all be fixed now.
Hey thanks! That is excellent. I had no idea that the models were not fixed/assigned correctly in the NG update and indeed lfss swapped the models for the level1 variant which obviously did not fit correctly. The level 2 version are nice and snug. Thanks for the update
The lvl 2 version is actually incoroporated in BiA, which is how it should've looked in vanilla. But they just used some generic steel/silver sword models. So sad, CDPR never addressed this kind of stuff. I just took BiA's sword templates and incoporated to this mod as well so that it all works together, and as you said fits perfectly now cuz I tweaked the sword mesh to fit better.
Sounds like it could be a priority issue. Do you have another mod that modifies Iris or its scabbards? Give my mod highest priority. Or you have a mod that's removing its scabbard for some kind of new one and my mod is overwriting that and making it disappear, which means you have a conflict.
Oh, so it just wasn't included. Alright cool, I'll update. Haven't seen the issue on any other sword but I've been equipping them all out again on this current playthrough so I'll let you know if I find anything else.
Thanks man. Yeah I tested pretty much all of them from vanilla to DLC. But that one sword is a Relic in a file that's filled with non-relics. Don't know why the devs put it there, so it was easy to miss.
108 comments
Deletedbut it is not clear, at all. Unless I'm missing something obvious, practically every merge has the word scabbard in it (thought maybe it was a conflict w/ another mod, but I don't have any sword mods installed to my knowledge, other than the widely used "All NPC Scabbards")... TIA
The author recommend to select Scabbard Clipping Fix if you wish the fix, or the the other mod if you wish its changes.
I understand they need to be merged. You just said "And only select the lines about Scabbards, if asked, from this mod. That's all". What I'm saying is, there definitely ARE conflicts. No "if". And EVERY SINGLE one is from THIS mod. There are no other conflicts (at least for me w/ my mods). But again, in the description for your other mod, you wrote "When there is a conflict, select all the lines from this mod, except if it asks you about scabbards". Not IF, but WHEN. That was the word you used, implying there ARE conflicts that are NOT from this scabbards mod. However, the same line states "except if it asks you about scabbards". There is no "if"; it DOES ask about scabbards. Hence my confusion; I assumed (wrongly?) that you would know that your own mod, conflicts with your other mod...
I don't know if they're about stats or not; I'm not a modder (wouldn't be asking this question in the first place if I was). Some of them have numbers, but it looks like it's prolly a naming system. My guess is to select the lines from this mod, "Scabbard Clipping Fix", but due to the language used on the description page of "The Essential Weapon Rework Mod" as mentioned above, I've been hesitant to conclude that. Thank you for your help.
https://pasteboard.co/i95j5fzovz24.png
https://pasteboard.co/mv9MouyQyMQB.png
mathematicproblem.The IF for "And only select the lines about Scabbards, if asked, from this mod. That's all", implies only the conditions are reach, in the case when Script Merger ask you.
It doesn't mean if "there definitely ARE conflicts [...] And EVERY SINGLE one is from THIS mod". But only IF Script Merger ASKS you to resolve the conflict.
Then the When for "When there is a conflict, select all the lines from this mod, except if it asks you about scabbards". This one implies the expectation or not.
It doesn't imply "there ARE conflicts that are NOT from this scabbards mod", but only one possibilities that Script Merger detect a merge conflict between this scabbards mod and another mod.
And so, if the When condition are met. Then another condition are to be met which is "except if it asks you about scabbards".
Again, it implies one of the conditions are reach or not, not systemically true as you thought "There is no "if"; it DOES ask about scabbards".
The meaning is the same as the first quote. It's IF Script Merger ASKS you to resolve the conflict.
"When" and "If" are somehow similar but they don't have an exact same definition. And of course one mod ARE in conflict to another mod.
Though Zowbaid was talking about "merge conflict" during the process of Script Merger, not the question of "is this mod in conflict to another one?".
Now for the main problem
I can't help with the provided pics because you active the setting "show the path line from each mods". I can't tell which one is Scabbard Clipping Fix mod or another mod.
@TBoner101. Ok, let's start at a more basic level. Basically, when you go into Script Merger, you HAVE to merge this mod with Essential Weapon Rework mod because they WILL 100% conflict. You have to merge them if you want the stats from that mod and the scabbards from this mod. Now, in the screenshot you posted, you're showing a conflict with a scabbard. You can tell because it's highlighted and it when comparing windows B and C, you can see that Window B says scabbard_silver_2_02, and the Window C says scabbard_silver_lynx_01. The one on the right (window C) is from this mod (Scabbard Clipping Fix mod), which is the line you want. So always select C when you have conflicts with scabbards. Every other conflict that is NOT scabbard-related (such as weapon stats), select the line from Essential Weapons Rework mod (should be Window B).
Also, judging from those screenshots, it looks like you're using an older version of Essential Weapons Rework. If you download the latest version, it should make merging the scabbards more seamless, hopefully without even needing to select B or C.
I hope this clears things up.
Respectfully, I often see you helping out on various mod pages by answering questions (which is great), but get confused reading your comments quite frequently. There are several grammatical errors not explained by brevity or slang in your reply and TBH, I don't understand the majority of it (and nor do I think I'm alone either).
I don't wanna be a grammar nazi but even your statement ironically proclaiming your communication is comprehensible (an admittedly biased opinion), "The way we speak require logic comprehension", is wrong. It should be "requires logical comprehension". Perhaps most important, though, is this,
Anyway, all I was trying to say was that Script Merger did ask me to resolve a conflict with Essential Weapon Rework mod, and it was from this scabbards fix, as evidenced by the screenshots. I DO appreciate your help tho, just in case that wasn't clear. Cheers
Just to confirm, I should NOT merge Essential Weapon Rework mod with BiA or LfSS, but give it priority over them, right?
I appreciate your help, the mods (and time spent making them), and patience in dealing w/ me making things more complicated than they needed to be. Thanks, bud!
So yes, basically if you're using Essential Weapons Rework, just give it priority over BiA and LfSS, that's right. Since this Scabbard Clipping Fix is a part of LfSS essentially but with a few additions to scabbards, then giving this priority over that is all you need to do. And then Essential Weapons Rework only needs to merge with Scabbards Clipping Fix, since it would be redundant to merge it with LfSS if Scabbard Clipping Fix already has priority over it, you know? It won't even make a difference to do so. Now, BiA is a bug fix mod, so it doesn't apply at all to any mods that change similar files because the other mods will be doing something "new" or "different", in which case you can completely ignore the conflicts and just give priority to the other mods. BiA is meant primarily as a bug fix for the vanilla game, so it can usually be ignored when it's conflicting with mods affecting the same files, giving BiA lower priority.
If you want kind of a priority overview for these mods, it should be something like this:
1. Scabbard Clipping Fix (merged with Essential Weapons Rework)
2. Essential Weapons Rework (merged with Scabbard Clipping Fix)
3. LfSS2.0
4. BiA
Or, you can flip 1 and 2, since they're interchangeable and have to be merged anyway. The most important thing is that they have to have priority over 3 and 4.
Hope this makes sense.
You've been incredibly helpful and your time is very much appreciated. Cheers mate!
Even when he said he was British, I didn't believe him. Maybe as a citizen, but he clearly speaks ESL. Not that there's nothing wrong w/ that (ofc), UNLESS you're attempting to correct someone else's grammar and understanding of the language, specifically me, who happens to be a native English speaker.
I read his post again and still can't understand anything between the first and last paragraph.
I merged the xml conflicts between your Essential Weapon Rework and Fixed Scabbards choosing the first in every conflict except If scabbards were mentioned where I chose the latter
But this caused the crafting menu of the Oxenfurt blacksmith to not have any swords to craft and all the other items (ingredients etc) to be invisible
Maybe this has affected other blacksmiths, to tell you the truth I have not checked
And when I merged them again it was bugged all over again
-dlc\bob\data\gameplay\items_plus\def_item_crafting_weapons.xml
-dlc\bob\data\gameplay\items\def_item_crafting_weapons.xml
-dlc\ep1\data\gameplay\items_plus\def_item_crafting_weapons.xml
-dlc\ep1\data\gameplay\items\def_item_crafting_weapons.xml
-gameplay\items\def_item_crafting_weapons.xml
-gameplay\items_plus\def_item_crafting_weapons.xml
then,
-gameplay\items\def_item_weapons_relic.xml
-gameplay\items_plus\def_item_weapons_relic.xml
Are those all different or just different merges of the same file (obv relic is separate, I'm referring to def_item_crafting_weapons.xml)? These are all on the left side of script merger so they're not past merges.
https://www.nexusmods.com/witcher3/mods/8042
???
https://imgur.com/a/IQwvArG
This is a picture only using lfss for reference https://imgur.com/k8ZpUMI
Also this is vanilla with no mods https://imgur.com/4npiu1i
https://postimg.cc/TK65jLz2
Some swords have crossguards that clip into the tops of the scabbards unfortunately and yes it's really annoying, but it's a really small price to pay for fixing the overall broken clipping that existed before. By widening the scabbards up top, it unfortunately led to some small clipping with certain swords. But as I said, some swords don't have this issue at all. It all depends on the sword and the scabbard. My Viper sword hardly clips at all into the the same scabbard. It doesn't look like your screenshots. So yeah, try the Venomous Viper sword and see how it looks.