Thank you for taking the helm and updating some of Aedenthorn's mods! I believe I have downloaded them all that you have updated! I hope you can take a look at Longer Seasons!
Thanks for the kind message! I've added it to the list. I keep a list of the mods I plan to work on in the future on my profile on the Stardew Valley forums, so that's the best place to make requests of me. However, that's pretty out of the way so I absolutely don't blame you for not knowing.
You are probably not talking to me, NormanPCN, about Spacechase's Better Shop menu (BSM), but I'll comment anyway. I have been responsible for all the recent updates to BSM. Last few at least. Bugs, features and 1.5 compatibility. I did not create a new Mod and just submitted my changes to Spacechase for eventual publication. I would likely continue that since Spacechase is still around. Space has a tons of Mods and I do not know what their intentions are WRT 1.6.
I have looked at BSM and the 1.6 changes at first glance do not seem too daunting, they are however at a significant/fundamental level. Soo many changes to 1.6 internals. Care must be taken. Since the Mod mimics the game shop menu, the mods function should be cross referenced against potential game code changes.
This is a compatibility issue with the Bigger Backpack mod. That mod allows purchase of a larger 48 slock backpack.
Bigger Backpack is patching itself in since the initial draw is fine. Something this mod does on updated text filter entry is breaking that Bigger Backpack patch.
Bigger Backpack seems to have a bug (missing patch) on shop menus which shows itself when the game window size is changed. I'll let them know about their issue. For whatever reason this mod is calling the game window size changed code. The game window is not changing so this is silly. Maybe it is trying to force a redraw due to the filtering but then looking at the game source the rsize does not seem to force a redraw. Since when a resize happens a redraw is inevitably going to be propagated.
Anyway, if one wants to force a redraw, this instant, then simply call the draw method instead of the game window size changing method. That draw may cause a recursion issue, but initially it seems okay, but I would just go with the resize or draw calls.
Actually one does not really need to force a redraw this instant since a redraw occurs every tick. Also, looking at the game code drawCurrency is called within the draw method. So a redraw is already in progress. drawCurrency is called before the menu is actually drawn so the shop item changes made by this mod will be drawn, this instant.
Actually this mod should handle window size changes as well. The filter field location. An edge case to be sure but one that exists nonetheless.
I added support for window resizing on my end. I also added a check so that it doesn't call that resize window code if Bigger Backpack is installed. I didn't remove that line altogether because while I can't see why it's necessary, I trust that aedenthorn had a reason for it.
This mod seems to be breaking opening a dresser, I try to open one the window just closes Here's my SMAPI log: https://smapi.io/log/877b4578dd7144059bd4553bf0ed95af
12 comments
Longer Seasons at Stardew Valley Nexus - Mods and community (nexusmods.com)
I apologize if this is the wrong area for requests!
I've added it to the list. I keep a list of the mods I plan to work on in the future on my profile on the Stardew Valley forums, so that's the best place to make requests of me. However, that's pretty out of the way so I absolutely don't blame you for not knowing.
I have been responsible for all the recent updates to BSM. Last few at least. Bugs, features and 1.5 compatibility. I did not create a new Mod and just submitted my changes to Spacechase for eventual publication. I would likely continue that since Spacechase is still around. Space has a tons of Mods and I do not know what their intentions are WRT 1.6.
I have looked at BSM and the 1.6 changes at first glance do not seem too daunting, they are however at a significant/fundamental level. Soo many changes to 1.6 internals. Care must be taken. Since the Mod mimics the game shop menu, the mods function should be cross referenced against potential game code changes.
Bigger Backpack is patching itself in since the initial draw is fine. Something this mod does on updated text filter entry is breaking that Bigger Backpack patch.
For whatever reason this mod is calling the game window size changed code. The game window is not changing so this is silly. Maybe it is trying to force a redraw due to the filtering but then looking at the game source the rsize does not seem to force a redraw. Since when a resize happens a redraw is inevitably going to be propagated.
Anyway, if one wants to force a redraw, this instant, then simply call the draw method instead of the game window size changing method. That draw may cause a recursion issue, but initially it seems okay, but I would just go with the resize or draw calls.
__instance.draw(b);
//__instance.gameWindowSizeChanged(Game1.graphics.GraphicsDevice.Viewport.Bounds, Game1.graphics.GraphicsDevice.Viewport.Bounds);
I've tested this and it seems to be fine.
Actually one does not really need to force a redraw this instant since a redraw occurs every tick. Also, looking at the game code drawCurrency is called within the draw method. So a redraw is already in progress. drawCurrency is called before the menu is actually drawn so the shop item changes made by this mod will be drawn, this instant.
Actually this mod should handle window size changes as well. The filter field location. An edge case to be sure but one that exists nonetheless.
I also added a check so that it doesn't call that resize window code if Bigger Backpack is installed. I didn't remove that line altogether because while I can't see why it's necessary, I trust that aedenthorn had a reason for it.
Here's my SMAPI log:
https://smapi.io/log/877b4578dd7144059bd4553bf0ed95af
Edit: done.