Look everyone, I understand that BB-Edit is something that a lot of people like to use for a variety of reasons. However, I don't want to make this version compatible with BB-Edit because it is only thanks to Legends and it's incompatibility with BB-Edit that I managed to break my awful habit of messing around with the stats of my bros when they weren't perfect.
This mod simultaneously removes any ability to do so as well as decreasing your incentive to try because you already get some of the best possible bros.
Therefore (partially for my own sake) I will not be creating a BB-Edit compatible version of this mod. I'm sorry if this annoys you :/
I looked at the code and it looks like many methods are overwritten and copy pasted instead of calling the overwritten methods code. This will probably break any modules changing `player.fillTalentValues()`, `player.setStartValuesEx()`, `player_party.updateStrength()`, `character_background.onUpdate()` and `character_background.buildAttributes()`. Also might introduce very slight bugs or inconsistencies if any of these methods change in any DLCs, may already have this issues.
E.g.I would say this probably won't work with Starting Perks by Background or ultrabros. I remember trying to use this mod a year or so ago and was forced to remove it because of such issues.
Do you consider updating it to work on top of such modules, i.e. instead of rewriting `player.fillTalentValues()` entirely call the original and add a talent and regenerate the stars? Same for other methods.
Honestly, that's fair criticism, this mod is *really* old at this point and was one of the first I ever worked on. I might make it hidden because I've got other more fundamental things I'm gonna be working on for a while but I don't see myself fixing it, sorry :/
I'm not a huge fan of keeping stuff up that doesn't actually work, clutters up the mod list with old crap imo. I'll try and take a look at your mod at some point but it looks neat and I'm glad you fixed the issues. Something u might be interested in is a simplified and improved mod hooks I'm hoping to release in the next few days in a beta state alongside some general BB modding documentation (both for it and more general concepts). I'll try and remember to let you know ^^
Hey End, first of all, thanks for all your hard work. Love your mods. Wanted to know if there is any plans to make a version of this for Legends now that the original mod is hidden by the author?
Hi, I wasn't aware that Leonion had abandoned Master Bros, I might take a look at that at some point, but honestly, dealing with the Legends codebase is often a pain and I might just prefer to work on other stuff (which I have lots of to do lol)
Definitely not the case, seems like you either don't know how it's supposed to work, or have some sort of conflict, which is unlikely. In case it IS a conflict though I'd really appreciate a log or at least a mod list so I could figure out what exactly is going on. Anything is better than "Don't work" tbh
Is this mod incompatible with Legends? Because when used with Legends, on generating a new game, it gets stuck "Building Settlements...". If I load a game that's already been created, and then added this mod after the generation of the map, all cities, towns, citadels, and castles won't open the interface, meaning I can't enter towns with legends mod activated.
Is it unavoidable that the 'all master cheat' mod add on will break starting traits for bros with specific map seeds? I notice that when I try lone wolf map seeds with this add on enabled my lone wolf will be a master but not have the other traits they should have (e.g. Iron Lungs and Fearless).
I see the problem now, someone else said something similar before but I didn't get that it was changing the skills rather than overwriting them. Not sure what exactly is going on here because I should have corrected for this, but I will look into it.
Did you happen to get this issue ironed out? I noticed this as well when I was trying to play a particular see -- the first trait was overwritten with the master trait.
So it does overwrite, but obviously only if the character spawns as a master. I was able to avoid the issue by just generating the same seed multiple times. Eventually the bro was not a master, and had his normal traits. Theoretically you could load a gladiator seed multiple times to get the same outcome (your normal traits), but it would be more annoying on account of there being three characters to load.
Would much appreciate if you would look into this -- I get why the master trait is necessary, but its not a very useful trait on its own to be replacing more useful traits. This might be desirable for some seeds, as the bro is getting max stats. But if were seed farming anyways, the bro is already incredible, or we might value the trait more than a few stat points :P
I've figured out the problem, it's due to the fact that master bros have additional ignored bad traits which has a high chance to mess with the seed. I'm looking into a solution but I'm currently busy with other stuff so it's not a massive priority for me and it seems to require some thinking. I will get to it though.
I don't know if my reply is relevant (since I don't know exactly what problem people are referring to), but to avoid messing with map seeds too much, mod_hooks offers a custom RNG that you can use to avoid changing the stream of numbers from the game's standard RNG.
I am already using RNG from mod_hooks for all the stuff that I've already got working. I do have an idea that might make everything work together tho and I'll work on it for the next bit and see.
So I fixed the thing that I figured out was affecting the seed generation, and I can confirm that it was because now the seeds generate different traits... but its still not the same traits as vanilla. So it seems that there is something else affecting those traits that I haven't figured out yet.
Sorry if this is an overly broad question, but would this be incompatible with the NPC equality mod? (it also makes some changes to certain backgrounds, like the hedge knight)
Give Feedback
73 comments
This mod simultaneously removes any ability to do so as well as decreasing your incentive to try because you already get some of the best possible bros.
Therefore (partially for my own sake) I will not be creating a BB-Edit compatible version of this mod. I'm sorry if this annoys you :/
E.g.I would say this probably won't work with Starting Perks by Background or ultrabros. I remember trying to use this mod a year or so ago and was forced to remove it because of such issues.
Do you consider updating it to work on top of such modules, i.e. instead of rewriting `player.fillTalentValues()` entirely call the original and add a talent and regenerate the stars? Same for other methods.
UPD. Published my rewrite here.
Would much appreciate if you would look into this -- I get why the master trait is necessary, but its not a very useful trait on its own to be replacing more useful traits. This might be desirable for some seeds, as the bro is getting max stats. But if were seed farming anyways, the bro is already incredible, or we might value the trait more than a few stat points :P
Thanks very much