(The better version of) this fix is now in the USSEP as of version 4.1.5 (bug 25197). Unless for some insane reason you're not using USSEP, you shouldn't need this mod any more.
I uploaded with permission of the author a new fix that solves the problem of Respite and the problem of the spell sometimes not working on NPCs that are within the Area of Effect (Spell now ignores Line of Sight).
If you downloaded the previous one, I would suggest replacing it with it, as it is a cleaner fix.
USKP (and later, USSEP) fixed the "heal enemies" bug way back, so you wouldn't. But since this mod would override their fixed version...
I like the idea of changing the perk instead, since the spell itself seems to be unfixable. Nice thinking! "Run on Target" would be, well, checking the Target for the perk though, surely? Which is the bug the spell has right now. So I'm not understanding something... Still, if you've got a fix that's nice and clean, please send it Arthmoor's way for the USSEP.
I took a look at your file and it doesn't look like it overrides anything done by USSEP, since USSEP fixed the spell by adding conditions to the Magic Effect that the Spell uses, not the Spell as such. "Target" is the caster, and "subject" are the actual targets of the spell. Subject refers to what the effect applies to, in this case everyone except the caster, and Target applies to the one applying the effect (the caster). Works with other stuff too, for example, if you want a Fire Enchantment on a sword to work only if you have a particular set of armor on, you would add a Condition on the enchantment that checks that the Target (wielder) has that particular set on.
I always thought that way of naming them was a bit confusing.
It's probably beyond the scope of your mod but also you should add the Ignore Line of Sight flag to the spell as well, since the spell is a bit wonky and sometimes you won't heal someone that is literally two inches away from you. That fixes it (it makes the spell ignore obstacles). That's what I did in my Fix/Tweak pack for vanilla spells mod. I will add this fix too now, thanks to you.
EDIT: And now that I checked again, you can simply change the Stamina Restore Effect condition in the Spell (the one that doesn't apply to the caster, but others) to run on Target instead of Subject. That fixes it.
TL;DR: The condition in the effect that grants stamina restoration to friendly NPCs around you is wrong, because it should be run on Target instead of Subject (which means it fails because it is checking if the the NPCS have the perk, instead of the caster).
Man, Bethesda... Target is the CASTER?! I guess that's why the "simple" spells still work even though they all use Subject: because for those, caster and target (for the sane use of the term) are the same actor.
Line of Sight seems like a very worthwhile fix to me. I did have one occasion where I didn't see the heal effects on a nearby ally who was about 3' below me, and that might be the cause.
Since you've cleaned it up so much already, you might as well just upload your version (you should have permissions if you want to replace the one here). Please send Arthmoor a patch if you haven't already.
Give Feedback
12 comments
If you downloaded the previous one, I would suggest replacing it with it, as it is a cleaner fix.
Also, I'm not seeing the problem with RestoreHealthFFSelfArea. I tested it, and enemies are never healed when you cast the spell.
I like the idea of changing the perk instead, since the spell itself seems to be unfixable. Nice thinking!
"Run on Target" would be, well, checking the Target for the perk though, surely? Which is the bug the spell has right now. So I'm not understanding something...
Still, if you've got a fix that's nice and clean, please send it Arthmoor's way for the USSEP.
"Target" is the caster, and "subject" are the actual targets of the spell. Subject refers to what the effect applies to, in this case everyone except the caster, and Target applies to the one applying the effect (the caster). Works with other stuff too, for example, if you want a Fire Enchantment on a sword to work only if you have a particular set of armor on, you would add a Condition on the enchantment that checks that the Target (wielder) has that particular set on.
I always thought that way of naming them was a bit confusing.
EDIT: And now that I checked again, you can simply change the Stamina Restore Effect condition in the Spell (the one that doesn't apply to the caster, but others) to run on Target instead of Subject. That fixes it.
Man, Bethesda... Target is the CASTER?!
I guess that's why the "simple" spells still work even though they all use Subject: because for those, caster and target (for the sane use of the term) are the same actor.
Line of Sight seems like a very worthwhile fix to me. I did have one occasion where I didn't see the heal effects on a nearby ally who was about 3' below me, and that might be the cause.
Since you've cleaned it up so much already, you might as well just upload your version (you should have permissions if you want to replace the one here). Please send Arthmoor a patch if you haven't already.
Thanks again.