Hey just to let you know - some of the modifications have been implemented incorrectly.
You've made the assumption that all bonuses work as "bigger number better, so replace the minimum value", but this means that for some bonuses you've actually set your non-RNG method to the worst possible roll for that specific bonus.
For example: <replace sel="//sticktime[@ware='mod_weapon_sticktime_01_mk2']/bonus/chargetime/@min">0.9</replace> Should be: <replace sel="//sticktime[@ware='mod_weapon_sticktime_01_mk2']/bonus/chargetime/@max">0.8</replace> This value works as a multiplier, so your mod changes it from the vanilla -10% - -20% bonus to just -10%.
The same error(chargetime) in lines: 10, 15, 20, 46, 51, 56, 74, 85, 90, 95, 101. Just a simple search and replace function in N++ should do the trick. .../bonus/chargetime/@min">0.8</replace>
- Engine Mods:
Spoiler:
Show
Line 144 travelattacktime: <replace sel="//travelthrust[@ware='mod_engine_travelthrust_01_mk2']/bonus/travelattacktime/@min">0.8</replace>
Line 145 travelchargetime: <replace sel="//travelthrust[@ware='mod_engine_travelthrust_01_mk2']/bonus/travelchargetime/@min">0.8</replace>
Line 153 travelattacktime: <replace sel="//travelthrust[@ware='mod_engine_travelthrust_01_mk3']/bonus/travelattacktime/@min">0.7</replace>
Line 154 travelchargetime: <replace sel="//travelthrust[@ware='mod_engine_travelthrust_01_mk3']/bonus/travelchargetime/@min">0.7</replace>
Line 158 travelattacktime: <replace sel="//travelattacktime[@ware='mod_engine_travelattacktime_01_mk1']/@min">0.8</replace>
Line 159 travelchargetime: <replace sel="//travelchargetime[@ware='mod_engine_travelchargetime_01_mk1']/@min">0.8</replace>
- Ship Chassis Mods: I really don't understand the cloak mod, so... "ship radar cloak -30,00 to -45,00%" if the best is -45%, then it's right. If not, needs changing.
- Shield Mods:
Spoiler:
Show
Line 207 rechargedelay: <replace sel="//capacity[@ware='mod_shield_capacity_01_mk2']/bonus/rechargedelay/@min">0.8</replace>
Line 212 rechargedelay: <replace sel="//capacity[@ware='mod_shield_capacity_02_mk3']/bonus/rechargedelay/@min">0.7</replace>
Line 213 rechargedelay: <replace sel="//rechargedelay[@ware='mod_shield_rechargedelay_01_mk1']/@min">0.8</replace>
Line 216 rechargedelay: <replace sel="//rechargerate[@ware='mod_shield_rechargerate_01_mk2']/bonus/rechargedelay/@min">0.8</replace>
Line 219 rechargedelay: <replace sel="//rechargerate[@ware='mod_shield_rechargerate_01_mk3']/bonus/rechargedelay/@min">0.3</replace>
Hi, could you please share a few more details about your mod ? It looks interesting, but I already use a similar mod.
From what I can read in the description, the first thing that came to my mind was : "Equipment upgrades without RNG" still works on 7.5, does your mod work differently ?
By the looks of it, the mods for engines have changed.
This mod also handles some other bonuses differently and in a few cases sets them to the 'worst' outcome of the RNG roll possible in Vanilla, instead of the best.
Hey, I took a look at 7.5 differences and yeah, basically 'strafethrust' was replaced with 'strafeacc' and 'rotationthrust' was changed to 'boostacc' FOR SOME OF MODIFICATIONS, in another one 'travelreleasetime' was removed etc. Looks like this part was implemented correctly, GJ.
And one more thing, this line for Mirage mod is basically useless: <replace sel="//hidecargochance[@ware='mod_ship_hidecargo_01']/@min">1</replace>as well as this one for Tenacity: <replace sel="//regiondamage[@ware='mod_ship_regiondamage_01_mk3']/@min">1</replace> Because there is 100% chance in vanilla for this modifiers. Not big deal but could be deleted imo.
EvilTactician Could you point out which ones are wrong?
Gryzli100 I generate files automatically from game files with a script, so I don't really want to add more complexity to the script than it's absolutely needed. As long as it doesn't break the game or does something wrong, it's easier for me to leave it then to specially handle it.
7 comments
You've made the assumption that all bonuses work as "bigger number better, so replace the minimum value", but this means that for some bonuses you've actually set your non-RNG method to the worst possible roll for that specific bonus.
For example:
<replace sel="//sticktime[@ware='mod_weapon_sticktime_01_mk2']/bonus/chargetime/@min">0.9</replace>Should be:
<replace sel="//sticktime[@ware='mod_weapon_sticktime_01_mk2']/bonus/chargetime/@max">0.8</replace>This value works as a multiplier, so your mod changes it from the vanilla -10% - -20% bonus to just -10%.
There's a few things like this in your mod.
- Weapon Mods:
The same error(chargetime) in lines: 10, 15, 20, 46, 51, 56, 74, 85, 90, 95, 101. Just a simple search and replace function in N++ should do the trick.
.../bonus/chargetime/@min">0.8</replace>
- Engine Mods:
Line 144 travelattacktime:
<replace sel="//travelthrust[@ware='mod_engine_travelthrust_01_mk2']/bonus/travelattacktime/@min">0.8</replace>
Line 145 travelchargetime:
<replace sel="//travelthrust[@ware='mod_engine_travelthrust_01_mk2']/bonus/travelchargetime/@min">0.8</replace>
Line 153 travelattacktime:
<replace sel="//travelthrust[@ware='mod_engine_travelthrust_01_mk3']/bonus/travelattacktime/@min">0.7</replace>
Line 154 travelchargetime:
<replace sel="//travelthrust[@ware='mod_engine_travelthrust_01_mk3']/bonus/travelchargetime/@min">0.7</replace>
Line 158 travelattacktime:
<replace sel="//travelattacktime[@ware='mod_engine_travelattacktime_01_mk1']/@min">0.8</replace>
Line 159 travelchargetime:
<replace sel="//travelchargetime[@ware='mod_engine_travelchargetime_01_mk1']/@min">0.8</replace>
- Ship Chassis Mods:
I really don't understand the cloak mod, so... "ship radar cloak -30,00 to -45,00%" if the best is -45%, then it's right. If not, needs changing.
- Shield Mods:
Line 207 rechargedelay:
<replace sel="//capacity[@ware='mod_shield_capacity_01_mk2']/bonus/rechargedelay/@min">0.8</replace>
Line 212 rechargedelay:
<replace sel="//capacity[@ware='mod_shield_capacity_02_mk3']/bonus/rechargedelay/@min">0.7</replace>
Line 213 rechargedelay:
<replace sel="//rechargedelay[@ware='mod_shield_rechargedelay_01_mk1']/@min">0.8</replace>
Line 216 rechargedelay:
<replace sel="//rechargerate[@ware='mod_shield_rechargerate_01_mk2']/bonus/rechargedelay/@min">0.8</replace>
Line 219 rechargedelay:
<replace sel="//rechargerate[@ware='mod_shield_rechargerate_01_mk3']/bonus/rechargedelay/@min">0.3</replace>
I think that's all. Cya!
Edit: Fixed a value that was wrong.
From what I can read in the description, the first thing that came to my mind was : "Equipment upgrades without RNG" still works on 7.5, does your mod work differently ?
This mod also handles some other bonuses differently and in a few cases sets them to the 'worst' outcome of the RNG roll possible in Vanilla, instead of the best.
And one more thing, this line for Mirage mod is basically useless:
<replace sel="//hidecargochance[@ware='mod_ship_hidecargo_01']/@min">1</replace>as well as this one for Tenacity:<replace sel="//regiondamage[@ware='mod_ship_regiondamage_01_mk3']/@min">1</replace>
Because there is 100% chance in vanilla for this modifiers. Not big deal but could be deleted imo.So yeah, dear Author, update needed!
Gryzli100 I generate files automatically from game files with a script, so I don't really want to add more complexity to the script than it's absolutely needed. As long as it doesn't break the game or does something wrong, it's easier for me to leave it then to specially handle it.