Okey, found solution for long standing error. When you resolve conflict with friendlystash it goes in that order, then you try to keep enchantment of already deleted item. So, proper ordering should be at line 200 about: //this block moved up so when resolved conflict with friendlystash it remains PRIOR "Remove" function call if(thePlayer.inv.IsItemEnchanted(itemsingr[0])) { enchantments.PushBack(thePlayer.inv.GetEnchantment(itemsingr[0])); }
I don't know why but it doesn't work to me, no scripts to merger, no errors, and nothing change when i use witcher gears already having runes to enchant glyph.
Does not work for me too, however, EnhanceItemScript(item, upgradeItem[0]); itemsingr[0]
does not look correct inside loop. That will update only 1st item out of all. Need to change somehow to use i/j variables, maybe [0] replace by[i] would be enough.
Having issues merging this with Friendly Stash. Any way to make these work with one another?
Edit: Might have fixed it by putting the merged lines of code after one another (didn't know you could select several lines to merge and thought I could only do direct replacements).
How do you select lines from multiple panes in script merger? Right clicking the ? area only gives options to choose from one of the 3 diffs. I'm probably missing something obvious, but I'd sure appreciate a point in the right direction, because I'm trying to use this mod with Friendly Stash too.
You can copy and paste any code from any pane into the result pane (bottom). In the end the conflicting section should look like this: if(thePlayer.inv.IsItemEnchanted(itemsingr[0])) { enchantments.PushBack(thePlayer.inv.GetEnchantment(itemsingr[0])); }
32 comments
See List of unneeded mods for Next-Gen Update (already included or obsolete).
//this block moved up so when resolved conflict with friendlystash it remains PRIOR "Remove" function call
if(thePlayer.inv.IsItemEnchanted(itemsingr[0]))
{
enchantments.PushBack(thePlayer.inv.GetEnchantment(itemsingr[0]));
}
thePlayer.inv.GetItemEnhancementItems(itemsingr[0], temp);
ArrayOfNamesAppend(upgrades, temp);
temp.Clear();
thePlayer.inv.RemoveItemByName(schem.ingredients[i].itemName, schem.ingredients[i].quantity);
GetWitcherPlayer().RemoveItemByNameForCrafting(schem.ingredients[i].itemName, schem.ingredients[i].quantity, GetFriendlyStashConfig().IsCraftingAccessAllowed()); //modFriendlyStash
EnhanceItemScript(item, upgradeItem[0]);
itemsingr[0]
does not look correct inside loop. That will update only 1st item out of all. Need to change somehow to use i/j variables, maybe [0] replace by[i] would be enough.
Edit: Might have fixed it by putting the merged lines of code after one another (didn't know you could select several lines to merge and thought I could only do direct replacements).
if(thePlayer.inv.IsItemEnchanted(itemsingr[0]))
{
enchantments.PushBack(thePlayer.inv.GetEnchantment(itemsingr[0]));
}
GetWitcherPlayer().RemoveItemByNameForCrafting(schem.ingredients[i].itemName, schem.ingredients[i].quantity, GetFriendlyStashConfig().IsCraftingAccessAllowed()); //modFriendlyStash
thanks a lot for the mod!
Saw other mods having different dls for 1.31 and 1.31 GOTY.