As pointed out by leseryk from Valheim Combat Overhaul, this mod when used with Combat Overhaul+Epic Loot causes spears (and Epic loot items with Throwable effects) to duplicate themselves when thrown (a copy remains in inventory but you can pick up the thrown copy and end up with two weapons).
Confirmed by removing this mod from our game which fixed the duplication bug.
Version 1.2 removed the piercing damage tooltip from the sword altogether, even after the secondary attack took place last. The previous version showed it if you used it as the last attack
Hey mate, it doesn't appear on the weapon description cause I just patch the sword attack damage when I detect its a secondary attack at the start of the hit calculations, and revert it back when I detect a normal attack. Which isn't a very clean way to do it, but the secondary attack use the base stats of the sword with a damage multiplier, so it's not like I could just edit the sword parameters. This cause a small bug with the description : after a secondary attack your sword description will mention the piercing damage, and after a normal one revert back to slash (cause I do the the check/patch at the start). Good thing you asked me, I noticed I forgot to add the damage bonus from quality levels (when you upgrade the weapon), which is an easy fix.
The description bug could probably be fixed by either reverting the change after damage is applied (need to patch another method) or doing a deep copy of the modified weapon stats to inject into the hit calculation instead of straight up changing the original (cleaner, but I will have to add the copying code myself). But if you want a "secondary attack damage type/multiplier" in the description, I will have to take a look at the UI code and prolly hardcode the type for swords.
I might eventually get around to do it cleanly (probably if I start messing with other weapons secondary attacks too, maybe adding some new stats to weapons data for the secondaries), but for the time being this lazy version will suffice :) Ofc if anyone feel like it, I'd be happy to share the code so they can tweak it, I just didnt bother with putting all this on github yet.
I see. Well, you got my endorsement already. If you make it work properly,(with the added pierce damage on the description permanent + the added levels from upgrading) you will have my vote too.
This thing bothered me from the start. I am glad someone tries to fix it. Well done.
Edit: Polearm also has the same problem. It has animations for both types of damage
13 comments
Confirmed by removing this mod from our game which fixed the duplication bug.
Version 1.2 removed the piercing damage tooltip from the sword altogether, even after the secondary attack took place last. The previous version showed it if you used it as the last attack
Could you do the same to knifes(also it would be nice to see 3d attack in combo all piercing dmg) and poleaxes(slashing).
Ehm, I don't see it on the weapon description though.
Could you, maybe, add that feature?
Or you already did and I don't see it for some reason?
This cause a small bug with the description : after a secondary attack your sword description will mention the piercing damage, and after a normal one revert back to slash (cause I do the the check/patch at the start).
Good thing you asked me, I noticed I forgot to add the damage bonus from quality levels (when you upgrade the weapon), which is an easy fix.
The description bug could probably be fixed by either reverting the change after damage is applied (need to patch another method) or doing a deep copy of the modified weapon stats to inject into the hit calculation instead of straight up changing the original (cleaner, but I will have to add the copying code myself).
But if you want a "secondary attack damage type/multiplier" in the description, I will have to take a look at the UI code and prolly hardcode the type for swords.
I might eventually get around to do it cleanly (probably if I start messing with other weapons secondary attacks too, maybe adding some new stats to weapons data for the secondaries), but for the time being this lazy version will suffice :)
Ofc if anyone feel like it, I'd be happy to share the code so they can tweak it, I just didnt bother with putting all this on github yet.
Well, you got my endorsement already.
If you make it work properly,(with the added pierce damage on the description permanent + the added levels from upgrading) you will have my vote too.
This thing bothered me from the start. I am glad someone tries to fix it.
Well done.
Edit:
Polearm also has the same problem.
It has animations for both types of damage