Heya BlackS7ar, My gaming group and I love this mod, and we've used it for quite some time. It's essential for a quality Valheim leveling experience, in our opinion, but it has a new error in Valheim v0.220.3. (copied below), seemingly related to the xp bonus text displayed in the top-left. I'd put this report in the bugs section, but we use R2modman, and thunderstore, so I have to put it here.
For those not in the know: This CombatIncentivesRewrite allows you to do away with the per-hit xp gains in the base game (repeatedly hitting tamed lox with a flint knife til your mind turns to jelly), and replaces it with bonuses based on the damage you deal to targets (i.e. bonus damage taken by your target during a stagger you produced = bonus xp (the "incentive" here)). It gives bonus xp on a parry, during assassinations (non-detected sneak attacks), etc. Many cool bonuses. Everyone should grab it.
On to the issue and replicable error: CombatIncentivesRewrite version 1.0.8, Valheim v0.220.3: While testing on a solo world, just after logging in, I parried an attack, then punched a target. This error showed in the BepInEx log:
Any chances of expanding this for the non-combat skills as well?
It seems like it would be pretty similar to make the pickaxe and woodchoping skills get bonus xp based on damage dealt, similar to how weapons do.
Running, swimming, and jumping could be a little tougher, but maybe bonus xp that scales up the longer you continuously do an activity (so more xp based on how much stamina you use running/swimming before stopping, or more xp for longer hangtime when jumping).
3 comments
My gaming group and I love this mod, and we've used it for quite some time.
It's essential for a quality Valheim leveling experience, in our opinion, but it has a new error in Valheim v0.220.3. (copied below), seemingly related to the xp bonus text displayed in the top-left.
I'd put this report in the bugs section, but we use R2modman, and thunderstore, so I have to put it here.
For those not in the know:
This CombatIncentivesRewrite allows you to do away with the per-hit xp gains in the base game (repeatedly hitting tamed lox with a flint knife til your mind turns to jelly), and replaces it with bonuses based on the damage you deal to targets (i.e. bonus damage taken by your target during a stagger you produced = bonus xp (the "incentive" here)). It gives bonus xp on a parry, during assassinations (non-detected sneak attacks), etc. Many cool bonuses. Everyone should grab it.
On to the issue and replicable error:
CombatIncentivesRewrite version 1.0.8, Valheim v0.220.3:
While testing on a solo world, just after logging in, I parried an attack, then punched a target.
This error showed in the BepInEx log:
[Error : Unity Log] MissingMethodException: Method not found: void .MessageHud.ShowMessage(MessageHud/MessageType,string,int,UnityEngine.Sprite)
Stack trace:
CombatIncentivesREwrite.Patches.HumanoidPatch.BlockAttack_Postfix (System.Boolean __result, HitData hit, Character attacker, Humanoid __instance, HitData __state) (at <241f17dbef634dae93d4d78c7ab9d061>:0)
(wrapper dynamic-method) Humanoid.DMD<Humanoid::BlockAttack>(Humanoid,HitData,Character)
(wrapper dynamic-method) Character.DMD<Character::RPC_Damage>(Character,long,HitData)
System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) (at <31687ccd371e4dc6b0c23a1317cf9474>:0)
Rethrow as TargetInvocationException: Exception has been thrown by the target of an invocation.
System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) (at <31687ccd371e4dc6b0c23a1317cf9474>:0)
System.Reflection.MethodBase.Invoke (System.Object obj, System.Object[] parameters) (at <31687ccd371e4dc6b0c23a1317cf9474>:0)
System.Delegate.DynamicInvokeImpl (System.Object[] args) (at <31687ccd371e4dc6b0c23a1317cf9474>:0)
System.MulticastDelegate.DynamicInvokeImpl (System.Object[] args) (at <31687ccd371e4dc6b0c23a1317cf9474>:0)
System.Delegate.DynamicInvoke (System.Object[] args) (at <31687ccd371e4dc6b0c23a1317cf9474>:0)
RoutedMethod`1[T].Invoke (System.Int64 rpc, ZPackage pkg) (at <285f74454c9841259bb8585eb4409ef4>:0)
ZNetView.HandleRoutedRPC (ZRoutedRpc+RoutedRPCData rpcData) (at <285f74454c9841259bb8585eb4409ef4>:0)
ZRoutedRpc.HandleRoutedRPC (ZRoutedRpc+RoutedRPCData data) (at <285f74454c9841259bb8585eb4409ef4>:0)
ZRoutedRpc.InvokeRoutedRPC (System.Int64 targetPeerID, ZDOID targetZDO, System.String methodName, System.Object[] parameters) (at <285f74454c9841259bb8585eb4409ef4>:0)
ZNetView.InvokeRPC (System.String method, System.Object[] parameters) (at <285f74454c9841259bb8585eb4409ef4>:0)
(wrapper dynamic-method) Character.DMD<Character::Damage>(Character,HitData)
(wrapper dynamic-method) Attack.DMD<Attack::DoMeleeAttack>(Attack)
Attack.OnAttackTrigger () (at <285f74454c9841259bb8585eb4409ef4>:0)
Humanoid.OnAttackTrigger () (at <285f74454c9841259bb8585eb4409ef4>:0)
CharacterAnimEvent.OnAttackTrigger () (at <285f74454c9841259bb8585eb4409ef4>:0)
Any chance of an update?
Thanks for a cool mod, BlackS7ar!
It seems like it would be pretty similar to make the pickaxe and woodchoping skills get bonus xp based on damage dealt, similar to how weapons do.
Running, swimming, and jumping could be a little tougher, but maybe bonus xp that scales up the longer you continuously do an activity (so more xp based on how much stamina you use running/swimming before stopping, or more xp for longer hangtime when jumping).