I'd like to avoid spamming with new Download files for every little change/fix that I make. So I'll just list the changes coming in the next version below as I make them - then people won't have to ask about those particular bugs/features. This will allow me to add more features and do better testing per update.
Next version changes:
No plans. I might bugfix from time to time.
I'm not able to do any long term / multiplier / splitscreen testing, as I don't have much time for modding, let alone playing the game.
Hey, fantastic work bringing this up to 1.6. Is there any possibility of getting an option to remove trash from the overlay too? Mods that install multiple trash items (such as Joja Cola Restock) aren't read properly by the overlay, and it results in long lines of "???". I'm not all that interested in my % to hook a specific piece of trash. I guess just expanding on the "fish only" option already in the config, but also one excluding trash? If not, no worries, its certainly not worth getting upset over, as the mod adds so much peace of mind and useful information regardless. Keep up the great work!
03:47:50 ERROR Fishing Info Overlays] This mod failed in the Display.Rendered event. Technical details: NullReferenceException: Object reference not set to an instance of an object. at StardewMods.Overlay.Rendered(Object sender, RenderedEventArgs e) in C:\Users\xyr\OneDrive\game\Stardew Valley\FishingInfoOverlays\Overlay.cs:line 110 at StardewModdingAPI.Framework.Events.ManagedEvent`1.Raise(TEventArgs args) in SMAPI\Framework\Events\ManagedEvent.cs:line 101
Please help, this keeps refreshing when I pick up the AlternativeTextures bucket. This problem also occurred in the 1.6 unofficial update version of this mod. The author said it was missing some name and fixed it.
[Fishing Info Overlays] This mod failed in the Display.Rendered event. Technical details:NullReferenceException: Object reference not set to an instance of an object. at StardewMods.Overlay.Rendered(Object sender, RenderedEventArgs e) in D:\Programming\Visual Studio\Projects\StardewMods\FishingInfoOverlays\Overlay.cs:line 89 at StardewMods.ModEntry.Rendered(Object sender, RenderedEventArgs e) in D:\Programming\Visual Studio\Projects\StardewMods\FishingInfoOverlays\ModEntry.cs:line 178 at StardewModdingAPI.Framework.Events.ManagedEvent`1.Raise(TEventArgs args) in SMAPI\Framework\Events\ManagedEvent.cs:line 101
When is this happening? Are you using custom fishing items, have custom fish in that area?
Unless it's giving the wrong line, nothing on that line can fail unless your game is very broken. The mod hasn't even started doing anything on that line.
I suggest starting by removing optional mods (or testing with just my mod). If you can figure out which one is the cause, I can have a look at what it does.
I can't really help you based on the log, as all it says is line 89 = the whole game or player is null (not possible).
I updated it and there was no problem with my local test, but the test time was too short and there may be some bugs Because I deleted the local multiscreen feature, need to delete the original config file Fishing Info Overlays If you notice any issues, let me know :)
thank you so much for this!! so far the only issue i see is on the immersive farm 2 remastered. it shows all 100% and it shows fish that aren't supposed to be available in that season.
The problem I am currently facing is that when switching to the fishing rod display page, the frame rate will decrease significantly. I hope it can be fixed
hi guys it seems like this mod was abbandoned but dont worrie iv worked on updating the mod if all goes well i should be able to upload it soon once ill do ill send another msg with the mod link (not the best at coding but i did my best to fix it for 1.6) if anyone would like to test the mod lmk
sorry for getting your hopes up i couldnt fix it i will keep working on it tho
Yay! I thought I was going to have to find a replacement. I really appreciate you taking the time to update it and I’m happy to test it if you’re still after people to do that :)
I recommend anyone who is waiting for an update, try this one: https://www.nexusmods.com/stardewvalley/mods/21332, it has a similar function showing fish percentages when holding a rod.
154 comments
Next version changes:
I'm not able to do any long term / multiplier / splitscreen testing, as I don't have much time for modding, let alone playing the game.
https://smapi.io/json/i18n/040dac23801d492096f426430160b6b0
Thanks for your mod, have a good day !
Is there any possibility of getting an option to remove trash from the overlay too? Mods that install multiple trash items (such as Joja Cola Restock) aren't read properly by the overlay, and it results in long lines of "???". I'm not all that interested in my % to hook a specific piece of trash. I guess just expanding on the "fish only" option already in the config, but also one excluding trash?
If not, no worries, its certainly not worth getting upset over, as the mod adds so much peace of mind and useful information regardless.
Keep up the great work!
at StardewMods.Overlay.Rendered(Object sender, RenderedEventArgs e) in C:\Users\xyr\OneDrive\game\Stardew Valley\FishingInfoOverlays\Overlay.cs:line 110
at StardewModdingAPI.Framework.Events.ManagedEvent`1.Raise(TEventArgs args) in SMAPI\Framework\Events\ManagedEvent.cs:line 101
Please help, this keeps refreshing when I pick up the AlternativeTextures bucket. This problem also occurred in the 1.6 unofficial update version of this mod. The author said it was missing some name and fixed it.
This shows up a bunch and doesn't stop
https://smapi.io/log/421b2f0c719b4cd28665af9735e2645c
Unless it's giving the wrong line, nothing on that line can fail unless your game is very broken. The mod hasn't even started doing anything on that line.
If you can figure out which one is the cause, I can have a look at what it does.
I can't really help you based on the log, as all it says is line 89 = the whole game or player is null (not possible).
Some people reported that the game hangs when exiting to desktop, but I've not been able to reproduce.
Maybe a larger testing pool will help uncover the issue.
Because I deleted the local multiscreen feature, need to delete the original config file
Fishing Info Overlays
If you notice any issues, let me know :)
For those looking for 1.6:
https://www.nexusmods.com/stardewvalley/mods/22201
once ill do ill send another msg with the mod link
(not the best at coding but i did my best to fix it for 1.6)
if anyone would like to test the mod lmk
sorry for getting your hopes up i couldnt fix it i will keep working on it tho