I am now the official maintainer of this page (thank you SpaceChase0) all new releases can be found on this nexus page!
Edit: I am aware that the skill page text overlaps, there is no room for it atm, spacechase0 is adding a new skill area later that I will move it to but is just ui for now so I ignored it
For future reference, it's good practice to have unofficial updates follow this naming convention. Yours ought to have been: 1.2.5-unofficial.1-Nykal145It ensures that official versions supersede unofficial ones (e.g., for update checks), and other users can release newer unofficial updates if needed.
Did anyone suddenly have a weird issue that makes cows “lay” milk? I’m not saying it has to be this mod, I installed 3-4 today and also updated spacecore, so might be any of these.
Based on scaling, yes the skill still works. At least the luck calculation. The visual part is (as far as I can tell) trying to read trait descriptions with the modified level rather than their expected level. Whether or not the traits are functional with luck buffs active, I can't say for certain.
With the tree where you giving gifts makes the junimos happy and it says there's a 15% chance for some farm advancement, what exactly does that mean?? Like the skill?
Hey, how is this mod integrated with the new mastery system? Will you have to max out the luck skill as well to access the secret cave or only the base game skills? And will you be adding a mastery system to the luck skill later down the line?
[SMAPI] Launching mods... [All Professions] Mod crashed on entry and might not work correctly. Technical details: Newtonsoft.Json.JsonReaderException: Can't parse JSON file at E:\program files (x86)\steam\steamapps\common\Stardew Valley\Mods\AllProfessions\assets\data.json. Technical details: Error converting value "Fortunate" to type 'AllProfessions.Framework.Profession'. Path 'ProfessionsToGain[10].Professions[0]', line 18, position 70. at StardewModdingAPI.Toolkit.Serialization.JsonHelper.ReadJsonFileIfExists[TModel](String fullPath, TModel& result) in SMAPI.Toolkit\Serialization\JsonHelper.cs:line 86 at StardewModdingAPI.Framework.ModHelpers.DataHelper.ReadJsonFile[TModel](String path) in SMAPI\Framework\ModHelpers\DataHelper.cs:line 50 at AllProfessions.ModEntry.Entry(IModHelper helper) in E:\source\_Stardew\Mods.cantorsdust\AllProfessions\ModEntry.cs:line 42 at StardewModdingAPI.Framework.SCore.LoadMods(IModMetadata[] mods, JsonHelper jsonHelper, ContentCoordinator contentCore, ModDatabase modDatabase) in SMAPI\Framework\SCore.cs:line 1765 I am not in a position to debug this issue in the code. One of you three Luck, Spacecore, or All Professions is not sending the requested information that you are requesting of each other correctly. Points to be debugged:
Spacecore is not recognize that Luck Skill exist
Spacecore is not updating the All Profession's Manifest
All Profession's Manifest when set correctly is throwing string errors suggesting a failure on the request end or the response from Luck Skill.
My 2 cents. Most likely Luck Skill Is out of date from how it's supposed to act since Spacecore has changed the way it's manifest code works.
Probable Workaround not tested: OG Professions appear to be in an array of 0-29 so when you reach level 10 in luck
Open your save in Notepad or Notepad++
Search for "Prof"
you are locking for a group like this: <professions><int>6</int><int>7</int><int>30</int><int>32</int></professions>
Remove any ints 30+ and add in <int>30</int><int>31</int><int>32</int><int>33</int><int>34</int><int>35</int> for a final result of <professions><int>6</int><int>7</int><int>30</int><int>31</int><int>32</int><int>33</int><int>34</int><int>35</int></professions>
NOTE: This only works if Luck is the only modded skill you have. Likely the number's meaning is decided on load.
luck skill does not use spacecores implementation for custom skills, it uses its own implantation that existed long before spacecore supported custom skills. I am looking into updating to use spacecores but it is not a small update.
I've been using Luck Skill 1.2.6 for a while, it works fine until you unlock the new 1.6 path; it doesn't show any XP gained for that unless I remove the mod. I had it installed when I completed the CC if that helps, but it didn't make a difference.
Give Feedback
409 comments
Edit: I am aware that the skill page text overlaps, there is no room for it atm, spacechase0 is adding a new skill area later that I will move it to but is just ui for now so I ignored it
For future reference, it's good practice to have unofficial updates follow this naming convention. Yours ought to have been:
1.2.5-unofficial.1-Nykal145It ensures that official versions supersede unofficial ones (e.g., for update checks), and other users can release newer unofficial updates if needed.Wanted to update to say it is working fine. No idea how to delete this comment. Thanks!
But asking just in case anyone else ran into it.
https://smapi.io/log/0ddfb30074d24b2cb90095760b0a6fb0EDIT: I believe the issue stems from having a "permanent" luck bonus, like the +1 Luck ring, active during day transition.
i dont seem to be able to change the profession with the sewer dog NPC
Cracking open the save shows the following:
<professions><int>6</int><int>7</int><int>30</int></professions>
6 and 7 are the level 5 fishing professions while the 30 is the Luck Skill Profession "Fortunate"
Spacecore is not updating the manifest in the data assets causing Luck Skill to fail to be applied
Current manifest:
{
"ProfessionsToGain": [
{ "Skill": "Combat", "Level": 5, "Professions": [ "Fighter", "Scout" ] },
{ "Skill": "Combat", "Level": 10, "Professions": [ "Brute", "Defender", "Acrobat", "Desperado" ] },
{ "Skill": "Farming", "Level": 5, "Professions": [ "Rancher", "Tiller" ] },
{ "Skill": "Farming", "Level": 10, "Professions": [ "CoopMaster", "Shepherd", "Artisan", "Agriculturist" ] },
{ "Skill": "Fishing", "Level": 5, "Professions": [ "Fisher", "Trapper" ] },
{ "Skill": "Fishing", "Level": 10, "Professions": [ "Angler", "Pirate", "Mariner", "Luremaster" ] },
{ "Skill": "Foraging", "Level": 5, "Professions": [ "Forester", "Gatherer" ] },
{ "Skill": "Foraging", "Level": 10, "Professions": [ "Lumberjack", "Tapper", "Botanist", "Tracker" ] },
{ "Skill": "Mining", "Level": 5, "Professions": [ "Miner", "Geologist" ] },
{ "Skill": "Mining", "Level": 10, "Professions": [ "Blacksmith", "Prospector", "Excavator", "Gemologist" ] }
]
}
If I attempt to force the manifest to match the Skill name and the professions within by adding them like so:
{
"ProfessionsToGain": [
{ "Skill": "Combat", "Level": 5, "Professions": [ "Fighter", "Scout" ] },
{ "Skill": "Combat", "Level": 10, "Professions": [ "Brute", "Defender", "Acrobat", "Desperado" ] },
{ "Skill": "Farming", "Level": 5, "Professions": [ "Rancher", "Tiller" ] },
{ "Skill": "Farming", "Level": 10, "Professions": [ "CoopMaster", "Shepherd", "Artisan", "Agriculturist" ] },
{ "Skill": "Fishing", "Level": 5, "Professions": [ "Fisher", "Trapper" ] },
{ "Skill": "Fishing", "Level": 10, "Professions": [ "Angler", "Pirate", "Mariner", "Luremaster" ] },
{ "Skill": "Foraging", "Level": 5, "Professions": [ "Forester", "Gatherer" ] },
{ "Skill": "Foraging", "Level": 10, "Professions": [ "Lumberjack", "Tapper", "Botanist", "Tracker" ] },
{ "Skill": "Mining", "Level": 5, "Professions": [ "Miner", "Geologist" ] },
{ "Skill": "Mining", "Level": 10, "Professions": [ "Blacksmith", "Prospector", "Excavator", "Gemologist" ] },
{ "Skill": "Luck", "Level": 5, "Professions": [ "Fortunate", "Popular Helper" ] },
{ "Skill": "Luck", "Level": 10, "Professions": [ "Lucky", "Un-unlucky", "Shooting Star", "Spirit Child" ] }
]
}
The following error gets thrown:
[SMAPI] Launching mods...[All Professions] Mod crashed on entry and might not work correctly. Technical details:
Newtonsoft.Json.JsonReaderException: Can't parse JSON file at E:\program files (x86)\steam\steamapps\common\Stardew Valley\Mods\AllProfessions\assets\data.json.
Technical details: Error converting value "Fortunate" to type 'AllProfessions.Framework.Profession'. Path 'ProfessionsToGain[10].Professions[0]', line 18, position 70.
at StardewModdingAPI.Toolkit.Serialization.JsonHelper.ReadJsonFileIfExists[TModel](String fullPath, TModel& result) in SMAPI.Toolkit\Serialization\JsonHelper.cs:line 86
at StardewModdingAPI.Framework.ModHelpers.DataHelper.ReadJsonFile[TModel](String path) in SMAPI\Framework\ModHelpers\DataHelper.cs:line 50
at AllProfessions.ModEntry.Entry(IModHelper helper) in E:\source\_Stardew\Mods.cantorsdust\AllProfessions\ModEntry.cs:line 42
at StardewModdingAPI.Framework.SCore.LoadMods(IModMetadata[] mods, JsonHelper jsonHelper, ContentCoordinator contentCore, ModDatabase modDatabase) in SMAPI\Framework\SCore.cs:line 1765
I am not in a position to debug this issue in the code. One of you three Luck, Spacecore, or All Professions is not sending the requested information that you are requesting of each other correctly.
Points to be debugged:
My 2 cents. Most likely Luck Skill Is out of date from how it's supposed to act since Spacecore has changed the way it's manifest code works.
Probable Workaround not tested:
OG Professions appear to be in an array of 0-29 so when you reach level 10 in luck
<professions><int>6</int><int>7</int><int>30</int><int>32</int></professions>
<int>30</int><int>31</int><int>32</int><int>33</int><int>34</int><int>35</int>
for a final result of<professions><int>6</int><int>7</int><int>30</int><int>31</int><int>32</int><int>33</int><int>34</int><int>35</int></professions>
NOTE: This only works if Luck is the only modded skill you have. Likely the number's meaning is decided on load.
overlap