Firstly, let me just say I love your mod! A very elegant solution to something that was bound to frustrate me.
Secondly--and this is really totally not necessary, so please feel free to disregard the request--I was hoping you might teach me how to slightly move the position of the pond. With the current layout of my farm, it's oh-so-slightly off in position to where I'd love for it to be. I was playing with the content file and can see the position [67, 22], which I think I would want to be [68, 21] (shifting the paddy one tile right and one tile up), but I believe source area must also come into play, which I haven't understood just yet. I feel like it may be X coordinate, Y coordinate, length, length? But I've just not been clever enough to get it to shift without a portion of the old pond peeking through the bottom right, or intimidating black bars where ground should be.
Anyway, it's a very small qualm that I really could just live with--it's leagues better than without your mod already! But I was hoping you might take the time out of your day to educate me. Thank you very much for reading, and for the mod!
Sorry, for taking a while to respond, I missed that you had commented. You've got the general idea, "sourceArea" defines the section of map from the map file that will be copied using X position, Y position, Width and Height. "position" then defines the X and Y cooridinates where that copied section will be pasted into the finished map.
The issue you are running into is that when I made the mod, in order to reduce the filesize, I stripped out all the map tile data aside from the area that I was inserting. This means you can't increase the copied area as there is nothing there to copy. Trying will result in what you have already seen, either black sections where there is no map data or tiles of the old pond that have not been overwritten.
I'll take a look later today at making a version of the mod that shifts it one tile up and right. It's been a few months since I touched the map editor but it should be fairly simple.
Edit: Uploaded a version that shifts the pond one tile up and one tile right under optional files in the files tab.
No need for apologies at all; you're doing a kindness for something you did initially out of kindness and as a passion! I appreciate you very much!
I was actually thinking a very simplified version of that! "sourceArea" by the term seemed to be the thing being drawn from--like, that all makes a whole heck ton of sense, and I feel massively validated that I at least kind of figured out what was going on, lol.
Reading your commentary about how you only modified the area of the map with the pond therefore it oughtn't conflict with any other mods, even those that modified the farm, I was thinking, "you know, perhaps it just doesn't exist." But I really had no idea, LOL. Thank you for the explanation!
And oh my goodness THANK YOU for the different version!!!!!! You're fantastic! I appreciate this so much!!
Great mod but it's not working for me. Even though SMAPI is saying the mod loads fine all I get is a black rectangle where the pond should be. It even lets me walk through it as if the pond was gone entirely. I'm not sure if my log would be any help since there's no errors.
The only times I've seen a black area appear due to TMXLoader have been if the tile data had an error causing it to not be readable. I'll take a look later today, and see if there is something I can see that might cause an issue.
If you are able, post the log as it's possible there is some sort of conflict going on, even if it is not causing an actual error in SMAPI, and there is useful info to help narrow down what isn't causing the problem.
Also, were you adding it to a existing game or starting a fresh map? It should work either way however.
Edit: Checked it over and there should be no issues with the map data. I've tested and it is definitely working on both new games and existing saves, so it's got to be something in your setup that is causing it to hiccup. Not really anything else I can check without your log.
I had a look and I've simply not been able to duplicate the issue. The only thing I couldn't test was that you are running on windows 10 while I'm running windows 7, but that shouldn't matter.
As far as I can see you have all requisites installed and up to date and there shouldn't be anything else editing the Farm map. I've tested with the content packs you have that modify the tilesheet that the farm map uses, although that shouldn't matter, and they cause no issues.
The only thing I can suggest is testing on your end.
Move the Mods folder out of your Stardew Valley folder to the desktop. Create a new Mods Folder in the Stardew Valley folder Copy the following folders from the Mods folder you moved back into the new Mods folder(the base folders from installing SMAPI and the requirements for the mod). [TMX] RicePaddyPond ConsoleCommands PyTk SaveBackup TMXLoader
Start the game and create a new game on the default farm map and see if the black box issue occurs. Don't load existing saves at this point.
If it doesn't, start copying mods back over to the Mods folder, testing after every few to see when it reoccurs. I'd suggest leaving the content packs until all the other ones are confirmed working.
If you are able to narrow down which mod causes the issue, I might be able to figure out what is causing it, as at the moment I'm just not seeing a reason.
Existing saves are safe to load once you have all your mods back in place.
Edit: One possible thing to try would be updating to the Unofficial PyTK update 1.12.14 Not sure if that will help as I was using the last official version 1.12.13 myself during testing.
Thank you so much for all of your help. I feel silly that you had to tell me to try mods one at a time to find the conflict, that's modding 101.
In hindsight the answer was pretty obviously the only other TMX mod I was using. Pet House Buildables: https://www.nexusmods.com/stardewvalley/mods/4589 I don't know why it's causing problems but I'd guess it's the lack of update after 1.4.
10 comments
Firstly, let me just say I love your mod! A very elegant solution to something that was bound to frustrate me.
Secondly--and this is really totally not necessary, so please feel free to disregard the request--I was hoping you might teach me how to slightly move the position of the pond. With the current layout of my farm, it's oh-so-slightly off in position to where I'd love for it to be. I was playing with the content file and can see the position [67, 22], which I think I would want to be [68, 21] (shifting the paddy one tile right and one tile up), but I believe source area must also come into play, which I haven't understood just yet. I feel like it may be X coordinate, Y coordinate, length, length? But I've just not been clever enough to get it to shift without a portion of the old pond peeking through the bottom right, or intimidating black bars where ground should be.
Anyway, it's a very small qualm that I really could just live with--it's leagues better than without your mod already! But I was hoping you might take the time out of your day to educate me. Thank you very much for reading, and for the mod!
The issue you are running into is that when I made the mod, in order to reduce the filesize, I stripped out all the map tile data aside from the area that I was inserting. This means you can't increase the copied area as there is nothing there to copy. Trying will result in what you have already seen, either black sections where there is no map data or tiles of the old pond that have not been overwritten.
I'll take a look later today at making a version of the mod that shifts it one tile up and right. It's been a few months since I touched the map editor but it should be fairly simple.
Edit:
Uploaded a version that shifts the pond one tile up and one tile right under optional files in the files tab.
I was actually thinking a very simplified version of that! "sourceArea" by the term seemed to be the thing being drawn from--like, that all makes a whole heck ton of sense, and I feel massively validated that I at least kind of figured out what was going on, lol.
Reading your commentary about how you only modified the area of the map with the pond therefore it oughtn't conflict with any other mods, even those that modified the farm, I was thinking, "you know, perhaps it just doesn't exist." But I really had no idea, LOL. Thank you for the explanation!
And oh my goodness THANK YOU for the different version!!!!!! You're fantastic! I appreciate this so much!!
If you are able, post the log as it's possible there is some sort of conflict going on, even if it is not causing an actual error in SMAPI, and there is useful info to help narrow down what isn't causing the problem.
Also, were you adding it to a existing game or starting a fresh map? It should work either way however.
Edit:
Checked it over and there should be no issues with the map data. I've tested and it is definitely working on both new games and existing saves, so it's got to be something in your setup that is causing it to hiccup. Not really anything else I can check without your log.
Thank you!
As far as I can see you have all requisites installed and up to date and there shouldn't be anything else editing the Farm map. I've tested with the content packs you have that modify the tilesheet that the farm map uses, although that shouldn't matter, and they cause no issues.
The only thing I can suggest is testing on your end.
Move the Mods folder out of your Stardew Valley folder to the desktop.
Create a new Mods Folder in the Stardew Valley folder
Copy the following folders from the Mods folder you moved back into the new Mods folder(the base folders from installing SMAPI and the requirements for the mod).
[TMX] RicePaddyPond
ConsoleCommands
PyTk
SaveBackup
TMXLoader
Start the game and create a new game on the default farm map and see if the black box issue occurs. Don't load existing saves at this point.
If it doesn't, start copying mods back over to the Mods folder, testing after every few to see when it reoccurs. I'd suggest leaving the content packs until all the other ones are confirmed working.
If you are able to narrow down which mod causes the issue, I might be able to figure out what is causing it, as at the moment I'm just not seeing a reason.
Existing saves are safe to load once you have all your mods back in place.
Edit:
One possible thing to try would be updating to the Unofficial PyTK update 1.12.14 Not sure if that will help as I was using the last official version 1.12.13 myself during testing.
In hindsight the answer was pretty obviously the only other TMX mod I was using. Pet House Buildables: https://www.nexusmods.com/stardewvalley/mods/4589 I don't know why it's causing problems but I'd guess it's the lack of update after 1.4.
Thank you again for your help!