I discovered an issue with the auto upgrade function. When you grab a bottle of wine and it gets auto-upgraded to iridium quality, the mod adds the base 'wine' item, not the specific type of wine you made. So when auto-upgrading artisan goods that can have a type, like wine, jelly, juice and aged roe, the mod probably needs a function that checks what version of the item it is and makes sure the correct version gets added to your inventory when auto-upgrading.
I have attempted to fix the issue where items could not be stacked, but you still need to ensure there is at least one free slot in your inventory to successfully pick up and upgrade items.
Hi! I was wondering if you could add an option or setting to make this automatically upgrade items when you pick them up? It would be a lot more convenient for someone who whats all their items at Iridium quality.
I tried it out, and I have a few notes. First of all, you seem to be applying upgrades based on what item category things are in, at least that's what it seems like to me, which would explain why sap is upgraded, since it's in the 'forage' category. I don't honestly think this is a problem. The issue is that stuff like coffee beans, which is in the 'seeds' category, doesn't get upgraded, even though it has item quality. I personally would just add every category that can have stuff with quality in it to the list, or maybe let people decide for themselves in the config what item categories to upgrade. (Some people might want to upgrade minerals, for example, so they can use them to get a better grange display score).
The bigger issue is that the auto-upgrades don't work well with item stacking, since each item is upgraded when it's added, and then a new item is added of the normal quality and that gets upgraded in turn, so you get a bunch of individual items that aren't stacked up. My suggestion would be that instead of just changing the item to have iridium quality, you make the mod check if the item is already iridium (if so, it doesn't need to be changed), and if the item is a different quality, remove the item from the inventory and add an iridium quality version of the same item. That way, the new item should stack with any iridium quality items already in your inventory.
Thank you for your suggestion，that helps a lot. I have attempted to fix the issue where items could not be stacked, but you still need to ensure there is at least one free slot in your inventory to successfully pick up and upgrade items.And I have implemented configuration support for basic item categories, with the exception of certain categories that should not be upgraded, or whose upgrade could lead to errors, such as weapons, tools, hats, rings, etc. Just Try v1.1.0~
13 comments
I'm new to SMAPI, but I'll try.
u can try it, and pls tell me if u see any errors.: )
The bigger issue is that the auto-upgrades don't work well with item stacking, since each item is upgraded when it's added, and then a new item is added of the normal quality and that gets upgraded in turn, so you get a bunch of individual items that aren't stacked up. My suggestion would be that instead of just changing the item to have iridium quality, you make the mod check if the item is already iridium (if so, it doesn't need to be changed), and if the item is a different quality, remove the item from the inventory and add an iridium quality version of the same item. That way, the new item should stack with any iridium quality items already in your inventory.
Hope this helps, and thank you for your efforts!
I have attempted to fix the issue where items could not be stacked, but you still need to ensure there is at least one free slot in your inventory to successfully pick up and upgrade items.And I have implemented configuration support for basic item categories, with the exception of certain categories that should not be upgraded, or whose upgrade could lead to errors, such as weapons, tools, hats, rings, etc.
Just Try v1.1.0~