No, stardew contains all the features ShopExpander provides natively now.
As such, there is no reason to update this mod, as buying upto 999 items at once is now vanilla, and editing shops can be done easily with ContentPatcher.
Shop Expander predates multi-language support in SDV, so the detection for vanilla shops without a explict owner has hard-coded checks for English.
It will take a lot of work redesigning the detection code, which, given that the next SDV update is likely to make the detection code completely irrelevant, and may even make most of ShopExpander itself irrelevant, is not something I am currently willing to spend the effort for.
This issue should have no negative effects for you in gameplay, so it is safe to continue playing as-is.
Please confirm that this issue can be replicated without any other mods, the error you are experiencing is happening because ShopExpander is detecting a NPC-owned shop, but the NPC who owns it does not have a Name.
This should not ever happen, as all NPC's must have a Name, so the fact that you are running into a situation where a nameless NPC exists is peculiar.
[Shop Expander] This mod failed in the Display.MenuChanged event. Technical details: NullReferenceException: Object reference not set to an instance of an object. at Entoarox.ShopExpander.ModEntry.OnMenuChanged(Object sender, MenuChangedEventArgs e) in C:\Users\Gebruiker\source\repos\StardewMods\ShopExpander\ModEntry.cs:line 222 at StardewModdingAPI.Framework.Events.ManagedEvent`1.Raise(TEventArgs args, Func`2 match) in SMAPI\Framework\Events\ManagedEvent.cs:line 126 [Shop Expander] This mod failed in the Display.MenuChanged event. Technical details: NullReferenceException: Object reference not set to an instance of an object. at Entoarox.ShopExpander.ModEntry.OnMenuChanged(Object sender, MenuChangedEventArgs e) in C:\Users\Gebruiker\source\repos\StardewMods\ShopExpander\ModEntry.cs:line 222 at StardewModdingAPI.Framework.Events.ManagedEvent`1.Raise(TEventArgs args, Func`2 match) in SMAPI\Framework\Events\ManagedEvent.cs:line 126 [Shop Expander] This mod failed in the Display.MenuChanged event. Technical details: NullReferenceException: Object reference not set to an instance of an object. at Entoarox.ShopExpander.ModEntry.OnMenuChanged(Object sender, MenuChangedEventArgs e) in C:\Users\Gebruiker\source\repos\StardewMods\ShopExpander\ModEntry.cs:line 222 at StardewModdingAPI.Framework.Events.ManagedEvent`1.Raise(TEventArgs args, Func`2 match) in SMAPI\Framework\Events\ManagedEvent.cs:line 126
i dont know much about programming but when i try to add Hay (178) it said this. [Shop Expander] Unable to add item to shop, it has no value: 178 May be i do something wrong. Thank you for reply me :)
That means that the Hay item has a default value of 0 and thus cannot be added to a shop as a stack because of that. Unfortunately, there is currently no way to fix that, as I need to get the ShopExpander rewrite coded up in order to support custom prices for stacks.
And before I can do the ShopExpander rewrite, I need to get my condition system updated for use with EMU.
That error should have no negative impact on your game and should be safe to ignore, if it is not, then please elaborate on the issue as the log only tells me what the issue is, not why it is a issue.
Give Feedback
87 comments
As such, there is no reason to update this mod, as buying upto 999 items at once is now vanilla, and editing shops can be done easily with ContentPatcher.
It will take a lot of work redesigning the detection code, which, given that the next SDV update is likely to make the detection code completely irrelevant, and may even make most of ShopExpander itself irrelevant, is not something I am currently willing to spend the effort for.
This issue should have no negative effects for you in gameplay, so it is safe to continue playing as-is.
thank you!
This should not ever happen, as all NPC's must have a Name, so the fact that you are running into a situation where a nameless NPC exists is peculiar.
NullReferenceException: Object reference not set to an instance of an object.
at Entoarox.ShopExpander.ModEntry.OnMenuChanged(Object sender, MenuChangedEventArgs e) in C:\Users\Gebruiker\source\repos\StardewMods\ShopExpander\ModEntry.cs:line 222
at StardewModdingAPI.Framework.Events.ManagedEvent`1.Raise(TEventArgs args, Func`2 match) in SMAPI\Framework\Events\ManagedEvent.cs:line 126
[Shop Expander] This mod failed in the Display.MenuChanged event. Technical details:
NullReferenceException: Object reference not set to an instance of an object.
at Entoarox.ShopExpander.ModEntry.OnMenuChanged(Object sender, MenuChangedEventArgs e) in C:\Users\Gebruiker\source\repos\StardewMods\ShopExpander\ModEntry.cs:line 222
at StardewModdingAPI.Framework.Events.ManagedEvent`1.Raise(TEventArgs args, Func`2 match) in SMAPI\Framework\Events\ManagedEvent.cs:line 126
[Shop Expander] This mod failed in the Display.MenuChanged event. Technical details:
NullReferenceException: Object reference not set to an instance of an object.
at Entoarox.ShopExpander.ModEntry.OnMenuChanged(Object sender, MenuChangedEventArgs e) in C:\Users\Gebruiker\source\repos\StardewMods\ShopExpander\ModEntry.cs:line 222
at StardewModdingAPI.Framework.Events.ManagedEvent`1.Raise(TEventArgs args, Func`2 match) in SMAPI\Framework\Events\ManagedEvent.cs:line 126
Could you pls add Hay at Marnie's shop?
[Shop Expander] Unable to add item to shop, it has no value: 178
May be i do something wrong.
Thank you for reply me :)
Unfortunately, there is currently no way to fix that, as I need to get the ShopExpander rewrite coded up in order to support custom prices for stacks.
And before I can do the ShopExpander rewrite, I need to get my condition system updated for use with EMU.