As of the 1.2.0 update, there's a specific overlay for indoors locations. The problem is that a lot of maps are internally indoors and use that overlay by default – for example, NPCs' houses, the mines and the sewers are all technically indoors, but the overlay only makes sense for one of them. That's why I have to manually make a list of maps to disable that overlay for.
Long story short, please let me know if you see any maps that use the indoors window overlay but you feel like they really shouldn't, either vanilla or added by mods. Just leave a comment and I'll do my best to iron out any kinks.
Thank you so much for fixing the gaps! My OCD can finally rest.
I apologize for asking if this is not something to be done on the scope of this mod, however, If you could also fix the name alignment for those using farmer portraits, that would be lovely!
Uhm. That... wasn't intended. I assumed Farmer Portraits' would be edited by Dialogue Display Framework just like the normal one. Looks like that's not the case, though... I'll see what I can do, but I really can't promise anything. Thanks for reporting it!
Okay, I've got both good and bad news. Good news first: I've found a way to put the name back into its box. The bad news... the gap between your farmer's portrait and name will be back and it looks like I can't overlay the indors overlay over the farmer background specifically. For some additional context: It's kind of a soft incompatibility between Farmer Portraits and Dialogue Display Framework at the moment. DDF's changes simply aren't properly reflected for the farmer's portrait. I've got kind of a hacky workaround in the next update I'll publish in a bit, but it's absolutely not perfect either. The authors of both frameworks are working on updates fixing the problems, but I figured having a (not great) workaround was better than nothing until then.
Hello ! Love your mod, it’s gorgeous ! Would you consider updating it to integrate i18n support ? That way it would be translatable - I would do it for
Hey there! Funny you mention that now – I just included i18n and more (probably too, lol) informative tooltips in the copy I'm working on. I actually wanted to release the update yesterday but ran into a few problems I couldn't fix in time. First time I'm hearing of that Internationalization mod, too. Looks handy. I've added a new config option to the update, so I'll just DM you the up-to-date default.json for you to properly translate. Thank you!
Will there be a variation that removes the coloured borders from around the dilaouge box? Right now I can get around it by simply removing the files, but I was just wondering if you'd make a config option for it in the future at all? ^^ I enjoy this mod but the coloured borders clash with the UI I use and gives me a headache.
Well, that would be a pretty good idea... if it weren't a config already! "RoundedBorders" is probably not the most accurate name, admittedly, but it lets you turn the changes to the borders off.
Hey, your mod is gorgeous, but the rain portraits do not work. I tried removing every other mod except content patcher and yours to see if there was some sort of conflict, but to no avail. When it rains, there's sunny sky dialogue. I can't figure out what to do to fix it because when: rain is how you do it.
Side note, your mod is beautifully written. It taught me how to use dynamic tokens for any future modding I do <3
I’ll start with the positive stuff – wow. Thanks so much! No one’s ever called any of my mods "beautifully written". Glad I could (indirectly) help!
The less great stuff… that’s weird. It definitely worked fine on my end when I tested everything. Even weirder that it works on a new save… I would’ve said that the rain backgrounds somehow got lost during the download, but the fact it works on new saves proves that theory wrong. I’ll take a closer look at your log tomorrow. Is that from the save it actually worked on?
yes, this is from the save it worked on. If you'd like, I can get you a log from one where it didn't work. There are no errors showing up in SMAPI, so the assets are there and the json has no errors. Beyond that, I'm lost.
and no dice. it loads the sunny one ( frenchwindows_{{season}} ) instead of the rain one ( frenchwindows_{{season}}_1 )
This seems to either be a mod conflict or something wrong on my end. I may try to reinstall stardew as a whole to see if something got messed up there. I appreciate any time you do spend looking at this :)
EDIT: I tried uninstalling and re-installing stardew in case something had gotten messed up in the files.. no luck
Okay, I've taken a look at your logs and... I'm baffled. I don't see any problems, but the patches simply aren't applied, it looks like. Everything's working fine on my end, so something funky's going on here. I'm absolutely not a troubleshooting pro, but let's see...
Reinstall Changing Skies. I'm honestly not sure why it would change anything, but it's worth the try, I'd say.
If that doesn't work, please load the save it's not working on, type "patch summary Dora.ChangingSkies" into the SMAPI console and share another log. That'll give me some more details to work with.
If you don't mind the mismatched background, you could try playing until the weather's rainy again and see if that changes anything.
Are the rain backgrounds the only ones that don't properly work? Actually, do other changes that are only applied when it's raining work?
As for the window error, the snippet you posted looks correct to me, but your log complains about a malformed JSON. You could try plugging it into this JSON validator to see what the error is. Probably a missing comma or bracket if I had to guess.
As it happens, I have another save file where it is raining, so I have just been using that. I have uninstalled and reinstalled your mod.
Not working log on sunny day with patch summary: https://smapi.io/log/25ccdbc50bfe49aaa386eac53dd0c6ae Not working log on rainy day with patch summary: https://smapi.io/log/19d657b95e7a44139ddfea37e8800a6f Working log on rainy day with patch summary: https://smapi.io/log/320c3c33e9fb4d23becdecb7262b2bae
I see variation shows sunny, sunny, and then rain on the last one.
No changes that are only applied during rain work :( So I don't think your mod is the culprit.
I really appreciate you bringing the error to my attention. I had accidentally deleted a framework mod
I hate to admit it, but... I've genuinely no idea what's going on. It looks like the game just refuses to acknowledge that it's raining even though you say it is... Very, very weird. I fear I'm at my wit's end here (and really hope I'm not the reason everything broke), but if you want to solve that mystery, I'd recommend joining the Stardew Valley Discord server and asking for help in its modded game support channel. It's got some extremely competent regulars who are much better equipped for dealing with problems than me. I'd love to know what's causing this!
UMMM, so the problem fixed itself? Loaded in and it works, for all the rainy mods.. Yesterday in game I unlocked and went to Ginger Island? That's the only thing that's really changed, no mod adjustments or anything
No, the issues wasn't because of files being pre-1.6. My main file is 1.6 and it didn't work. Thanks for the info on passing to another rainy day!
I did join the discord server last night, but haven't said anything as of yet. Figured I could search history before asking any questions.
Thank you both, and I guess I'll let you know if the problem pops up again, and I figure it out
… huh. I’m arguably even more confused than before, but hey, I’ll take it! I’m just glad it’s working again, lol. If the problem ever resurfaces, feel free to let me know!
Thank you for both the compliment and helping out!
Okay, so, funny story... I actually considered making a casino-specific background because the default one looks kind of out of place, but then I checked in-game and thought there were no NPCs and no events in there. I apparently managed to completely miss Qi, though, somehow. I guess he just blends in too much with the background? I'll look into it, but no promise I'll actually make something for one map with one NPC that I didn't even realize was there, lol. Thanks for bringing it up, though!
It is a bit resource-intensive, yeah. I tried to keep the number of patches to a mininum, but I don't think I can reduce it any more. Sorry about that. It's probably not what you wanted to hear, but I fear you'll either have to live with the increased loading times or uninstall the mod.
Seeing night portraits at 5pm feels really jarring. Any way we could get a config option to switch to night sky portraits when it actually gets dark? I know it is technically considered nighttime after 6pm. However, it doesn't become dark until around 8pm, depending on the season.
Hm, I can look into it. As far as I know, 1.6 made some changes to when the sun sets in different seasons. I still haven't really gotten around to actually playing myself, so it's basically all second-hand knowledge, but I'll do some research. It shouldn't be too hard to change. Edit after one simple wiki search: Nightfall is a 8 pm in spring and summer, 7 pm in fall and 6 pm in winter. I think I'll have an update to fit these day cycles out soon. Thanks for bringing it up!
It's my pleasure! The gap had been a thorn in my side basically since the mod's first release, so I'm more than happy that it's finally gone. You were also absolutely right – seeing the night portrait so early really was jarring, lol.
Maybe in the next update you could give the option to be like this, I did it here for myself and it turned out nice. I changed the color to have an earthy tone, inspired by the Earthy Recolour.
I'll be entirely honest: I'm not even going to pretend I dislike the "name box" or the darker outline. However, I won't be adding different color versions for the border or a background for the name. No, I don't like the portrait floating around either, but I still haven't found a proper way to change that yet. Adding different border colors for one UI mod would open a whole can of worms for compat with others and that's something I'd like to avoid. Still, I'm glad to hear you like the mod enough to make a personal edit!
Im unsure if I should ask this on Portrait Frame Variations or on Changing Skies Nexus page, but could there be a version of both mods that look like this?
I replied to you on Discord, but I'll put it here, too – I'm considering releasing a "lite" version of Changing Skies that leaves the wooden frame untouched and only changes the "letter" behind the portrait. In that case, you wouldn't have to do anything.
100 comments
Long story short, please let me know if you see any maps that use the indoors window overlay but you feel like they really shouldn't, either vanilla or added by mods. Just leave a comment and I'll do my best to iron out any kinks.
Maps that I'm aware of and will be fixed soon:
I apologize for asking if this is not something to be done on the scope of this mod, however, If you could also fix the name alignment for those using farmer portraits, that would be lovely!
Good news first: I've found a way to put the name back into its box. The bad news... the gap between your farmer's portrait and name will be back and it looks like I can't overlay the indors overlay over the farmer background specifically.
For some additional context: It's kind of a soft incompatibility between Farmer Portraits and Dialogue Display Framework at the moment. DDF's changes simply aren't properly reflected for the farmer's portrait. I've got kind of a hacky workaround in the next update I'll publish in a bit, but it's absolutely not perfect either. The authors of both frameworks are working on updates fixing the problems, but I figured having a (not great) workaround was better than nothing until then.
Thanks and have a good day !
It would also have the bonus to recall the explanations of the MGCM options in-game (via description pop-up). :)
I've added a new config option to the update, so I'll just DM you the up-to-date default.json for you to properly translate. Thank you!
Side note, your mod is beautifully written. It taught me how to use dynamic tokens for any future modding I do <3
EDIT: it worked when i started a new save file
https://smapi.io/log/11c583c309d64ef5b333149e7fb3e61f
The less great stuff… that’s weird. It definitely worked fine on my end when I tested everything. Even weirder that it works on a new save… I would’ve said that the rain backgrounds somehow got lost during the download, but the fact it works on new saves proves that theory wrong. I’ll take a closer look at your log tomorrow. Is that from the save it actually worked on?
As far as I can tell, your token is good, but I did try to add a rain modifier to another mod
{
"Action": "EditImage",
"Target": "tilesheets/frenchwindows_{{season}}_1",
"FromFile": "assets/frenchwindows_{{season}}_1.png",
"When": {
"Weather": "rain"
}
},
and no dice. it loads the sunny one ( frenchwindows_{{season}} ) instead of the rain one ( frenchwindows_{{season}}_1 )
This seems to either be a mod conflict or something wrong on my end. I may try to reinstall stardew as a whole to see if something got messed up there. I appreciate any time you do spend looking at this :)
EDIT: I tried uninstalling and re-installing stardew in case something had gotten messed up in the files.. no luck
- Reinstall Changing Skies. I'm honestly not sure why it would change anything, but it's worth the try, I'd say.
- If that doesn't work, please load the save it's not working on, type "patch summary Dora.ChangingSkies" into the SMAPI console and share another log. That'll give me some more details to work with.
- If you don't mind the mismatched background, you could try playing until the weather's rainy again and see if that changes anything.
Are the rain backgrounds the only ones that don't properly work? Actually, do other changes that are only applied when it's raining work?As for the window error, the snippet you posted looks correct to me, but your log complains about a malformed JSON. You could try plugging it into this JSON validator to see what the error is. Probably a missing comma or bracket if I had to guess.
Not working log on sunny day with patch summary: https://smapi.io/log/25ccdbc50bfe49aaa386eac53dd0c6ae
Not working log on rainy day with patch summary: https://smapi.io/log/19d657b95e7a44139ddfea37e8800a6f
Working log on rainy day with patch summary: https://smapi.io/log/320c3c33e9fb4d23becdecb7262b2bae
I see variation shows sunny, sunny, and then rain on the last one.
No changes that are only applied during rain work :( So I don't think your mod is the culprit.
I really appreciate you bringing the error to my attention. I had accidentally deleted a framework mod
I hate to admit it, but... I've genuinely no idea what's going on. It looks like the game just refuses to acknowledge that it's raining even though you say it is... Very, very weird. I fear I'm at my wit's end here (and really hope I'm not the reason everything broke), but if you want to solve that mystery, I'd recommend joining the Stardew Valley Discord server and asking for help in its modded game support channel. It's got some extremely competent regulars who are much better equipped for dealing with problems than me. I'd love to know what's causing this!
I got curious and looked into it a bit too, and that's what I found. Passing the day to another rainy day allows portraits to be displayed correctly.
My guess is something changed in how weather is defined in 1.6 or the savefile migration delays it slightly.
No, the issues wasn't because of files being pre-1.6. My main file is 1.6 and it didn't work. Thanks for the info on passing to another rainy day!
I did join the discord server last night, but haven't said anything as of yet. Figured I could search history before asking any questions.
Thank you both, and I guess I'll let you know if the problem pops up again, and I figure it out
Also, regarding your pinned post... there's Qi at the casino that looks a bit odd ;)
Okay, so, funny story... I actually considered making a casino-specific background because the default one looks kind of out of place, but then I checked in-game and thought there were no NPCs and no events in there. I apparently managed to completely miss Qi, though, somehow. I guess he just blends in too much with the background? I'll look into it, but no promise I'll actually make something for one map with one NPC
that I didn't even realize was there, lol. Thanks for bringing it up, though!Edit after one simple wiki search: Nightfall is a 8 pm in spring and summer, 7 pm in fall and 6 pm in winter. I think I'll have an update to fit these day cycles out soon. Thanks for bringing it up!
Still, I'm glad to hear you like the mod enough to make a personal edit!