47 comments

1. 

   Driwell

   • premium
   • 38 kudos
   Locked

   Sticky

   09 Aug 2024, 8:08AM

   heya, I made some changes to the way you're handling the water requirement to be more seamless with the Soap Required feature and refactored the code a bit. Feel free use it on your version, I'll explain it a bit
   
   Your version with my comments:
   

   
   
   • Here you nest the water conditions within the Soap Required feature, therefore the users are only required to be in water if they have that feature disabled, which in my view are unrelated.
     
   • There's also this issue that if they have that disabled they will not spend the soap in the inventory which is also not desirable because the user might want to have the soap requirement off but still use and spend the soaps when they have them.
     
   • Lastly you call the function to actually spend the soap but then again, this is only if they have the soap required feature enabled. That part of the code could also be improved as there are some repetition (checking for the same thing twice).
     

   Event OnEffectStart(Actor akTarget, Actor akCaster)
    If (!Dirty_BatheQuest)
        Dirty_BatheQuest = Game.GetFormFromFile(0x00000DC3, "Dirt and Blood - Dynamic Visuals.esp") as Dirty_BathingQuest
        Debug.trace("DIRTY quest is now " + Dirty_BatheQuest)
    endIf
    If PlayerRef.IsInCombat()
        Dirty_MessageBathCombat.Show()
    elseif PlayerRef.IsWeaponDrawn()
        Dirty_MessageBathWeapon.Show()


    elseif Dirty_SoapRequired.GetValue() == 0
        If IsActorUnderwater(akTarget)
            Debug.Notification("Cannot bathe underwater.")
        elseif PlayerRef.IsSwimming()
            Debug.Notification("Cannot bathe while swimming.")
        elseif !IsActorInWater(akTarget)
            Debug.Notification("Cannot bathe without water.")
        Else
            Dirty_BatheQuest.PlayBatheAnimation(PlayerRef, true)
        EndIf
    elseif Dirty_SoapRequired.GetValue() == 1 && PlayerRef.GetItemCount(Dirty_ListofSoaps) == 0
        Dirty_MessageBathSoap.Show()

    elseif Dirty_SoapRequired.GetValue() == 1 && PlayerRef.GetItemCount(Dirty_ListofSoaps) > 0
        Dirty_BatheQuest.PlayBatheAnimation(PlayerRef, true, true)
    EndIf
EndEvent

   
   My version of the OnEffectStart function:
   

   
   
   • The water requirement is checked regardless of the SoapRequired because that's an unrelated feature.
     
   • If the user has soaps it doesn't matter if they have the SoapRequired toggle enabled or not, they have soaps after all, so why check if the soap requirement is enabled?  just call the animation function with the removeSoap boolean set to true and be done with it without unnecessary validations.
     
   • If they don't have soaps then yes, we can check if the user has that feature enabled and show the appropriate message and not allow them to take the bath. 
     
   • Otherwise just play the animation and don't remove the soap since they don't have any this is good because the popular animation replacement script here on the nexus plays the animation with a rug when you call the function with the removeSoap set to false making the integration seamless.
     

   
   Event OnEffectStart(Actor akTarget, Actor akCaster)
    If (!Dirty_BatheQuest)
        Dirty_BatheQuest = Game.GetFormFromFile(0x00000DC3, "Dirt and Blood - Dynamic Visuals.esp") as Dirty_BathingQuest
        Debug.trace("DIRTY quest is now " + Dirty_BatheQuest)
    endIf
    If PlayerRef.IsInCombat()
        Dirty_MessageBathCombat.Show()
    ElseIf PlayerRef.IsWeaponDrawn()
        Dirty_MessageBathWeapon.Show()
       
    ElseIf IsActorUnderwater(akTarget)
        Debug.Notification("Cannot bathe underwater.")
    ElseIf PlayerRef.IsSwimming()
        Debug.Notification("Cannot bathe while swimming.")
    ElseIf !IsActorInWater(akTarget)
        Debug.Notification("Cannot bathe without water.")
    Else
        If PlayerRef.GetItemCount(Dirty_ListofSoaps) > 0
            Dirty_BatheQuest.PlayBatheAnimation(PlayerRef, true, true)
        ElseIf Dirty_SoapRequired.GetValue() == 1
            Dirty_MessageBathSoap.Show()
        Else
            Dirty_BatheQuest.PlayBatheAnimation(PlayerRef, true)
        EndIf
    EndIf
EndEvent

   hope you find this useful :)
   
   PS: What an ungodly "CODE" feature nexus has, code boxes shouldn't wrap... sorry for the mess with the comments, hope it's readable enough. I can send you the code without the comments by pm.
   
   Post PS: I removed all comments from the code blocks and added them as pseudocode explanations above each box instead.
   
   have a good day!
   1. 

      asterxaio

      • supporter
      • 2 kudos
      Locked

      Sticky

      03 Jan 2025, 5:43PM

      Can you upload this?
2. 

   AnActualDuck

   • premium
   • 0 kudos
   Locked

   Sticky

   15 May 2024, 7:54PM

   I love finding random hololive fans in the wild
3. 

   MyHouseatl

   • member
   • 15 kudos
   Locked

   Sticky

   22 Apr 2023, 10:17AM

   I don't know it it's your mod or some other problem but, sometimes when standing in water, the PC eats the soap instead of bathing.  Not all water does this.  How is your script detecting water?  Cause Damage flag?  Not sure how to trouble shoot as I have added Cause Damage flag every where I could find water.
   
   (For instance, Raven Rock Bathouse doesn't work.  Even after adding Cause Damage Flag.)
   1. 

      davidgilbertking

      • premium
      • 37 kudos
      Locked

      Sticky

      24 Jun 2023, 7:21PM

      Hi, how did you solve it? adding the flag did the trick in the end?
   2. 

      xLenax

      • supporter
      • 22 kudos
      Locked

      Sticky

      10 Oct 2023, 10:02AM

      ffs just use a bashed patch or a synthesis patch, you'll need one or the one (optimally both) anyway for leveled lists, records and etc Just tick the option/add the patch water causes damage, there's no need to blindly add the flag "everywhere" with water. Plus, some water mods, already come with the flag, it shouldn't even be needed after po3's universal water damage fix
4. 

   Violence

   • supporter
   • 5 kudos
   Locked

   Sticky

   08 Jul 2023, 6:42AM

   Hello. Quick suggestions, without intending any harm; 
   
   - You may want to allow this to detect water reliably without using other mods or Synthesis ETC.
   
   - You may also want to address compatibility with Simple Inn Baths, though perhaps this should be asked of the author of that. I've no idea what they've done so that the tub water in the instanced bath room isn't actual water.
5. 

   xybolt

   • premium
   • 7 kudos
   Locked

   Sticky

   19 Oct 2022, 4:06PM

   The condition that checks if you're in water is a bit too strict; it does not scan for nearby water bassin or bathes, something you can use when washing yourself.
   elseif !IsActorInWater(akTarget)
   Is there an option (maybe you can give me a pointer) to scan around for water instead. Since PO3's water detection is already included, could we not use one of its functions (not sure if there is any) to facilitate this?
   1. 

      FenikkusuKaen

      • premium
      • 13 kudos
      Locked

      Sticky

      23 Oct 2022, 7:01PM

      Probably possible, but only when I have time to do it. Too busy with irl job sr :(
   2. 

      davidgilbertking

      • premium
      • 37 kudos
      Locked

      Sticky

      27 Dec 2022, 4:08AM

      +1
      I would love a compatibility patch with Simple Inn Bath, there you bathe in a large basin that's technically not water, though it looks amazing. It was basically the main reason I uninstalled this
   3. 

      prydzen

      • member
      • 0 kudos
      Locked

      Sticky

      12 Feb 2023, 1:05AM

      perhaps Simple Inn Bath should make it real water instead of fake water.
   4. 

      nightowl43978

      • member
      • 6 kudos
      Locked

      Sticky

      24 Jun 2023, 2:39PM

      I believe that would be caused by the Simple Inn Bath tubs lacking the proper keywords, which would be solved using this mod. Also has the side effect of causing other mods' water to work as well, such as Legacy of the Dragonborn. 
6. 

   Longtrousers

   • supporter
   • 0 kudos
   Locked

   Sticky

   10 Mar 2023, 9:12AM

   banger installer
7. 

   victoriena

   • member
   • 0 kudos
   Locked

   Sticky

   11 Dec 2022, 8:18PM

   This mod in amazing, but it breaks immersion for me in the answering dialogue, because when for example a kid is telling me I stink, (hehe) I have a non immersive answer to give back, like ok lets play a game for instance.
   
   Thank you for your work!!
8. 

   Darnexx

   • premium
   • 308 kudos
   Locked

   Sticky

   24 Nov 2022, 9:18PM

   Thank you! It was so annoying when my dude was washing himself in the middle of the Road cause I accidently hit the button... 
9. 

   Corvinus18

   • premium
   • 82 kudos
   Locked

   Sticky

   10 Nov 2022, 11:50PM

   The NPC reaction looks like a cool idea, hope you continue to expand it.
   
   Dialogues like "you filthy nord/nuah"
10. 

    FenikkusuKaen

    • premium
    • 13 kudos
    Locked

    Sticky

    09 Nov 2022, 3:57PM

    Added NPC reactions plugin, so I changed this mod page name.
    Only guards and kids react to your dirtiness and bloodiness for now. Generate and editing voice lines take too much time.
    I'm also thinking about allowing bathing near wells/wash basins but need to figure out how to do it first :)
    Edited: Uploaded 2.0b to fix FOMOD missing pekora image which is unforgivable!