So, even though the USSEP version of the patch says it's for " For USSEP(4.2.5b) users," would it break anything to be used with 4.2.5 (not "b") or one of the later versions of the unofficial patch?
Next April 1st you should release an "update" where he sings the entire time while that quest is running, irrelevant of where you are in Skyrim. For instance, you are in the Dark Brotherhood hide out, Sven is singing. Fighting a dragon, can still hear Sven singing. At Alduin's wall, he's still singing. =p Because honestly that was what I thought this mod was going to do originally.
If you finished the main quest quickly, the impact of this bug is negligible.
But if you just stop the main quest at "Alduin's Wall" to do something else, you'll notice that bard Sven will never sing again, it doesn't work to request for songs also, and there's a lot less interaction in the Sleeping Giant Inn. Maybe you don't care about these, but make me uncomfortable.
It's just a minor fix for those who care about the details and I actually didn't want to be a modder because don't have time to do support. I upload this because I initially thought it was the exchange of location owners that caused the issue, which made me waste time on checking scripts, just don't want others who are affected and want to fix the issues to take detours like me.
I don't think yayepicyay was attacking you and I didn't read his comment as sarcasm. You dont need to defend your work, who in their right mind would oppose a fix mod?? Of course this mod is great and necessary nobody would dare say otherwise. yaypicyay propably just wanted to chime in with his own thoughts and a funny idea he had.
Just FYI, your script conflicts with the one form USSEP. I would suggest using the USSEP one as a base since it contains a lot more fixes. Moreover, it conflicts with the script from the mod Bard Instrumentals Mostly - Sing Rarely (that script includes all USSEP fixes).
Just to be on the safe side, your script edits only line 381 of vanilla script?
That is, it changes (in Function PlaySong):
If Bard == Sven && MQ203.isrunning() to
if Bard == Sven && MQ203.GetStage() >= 10 && MQ203.GetStage() < 40 ?
Weird, as your changes were commented out by Bethesdsa...perhaps some testing they were running and forgot to revert back?
Well, since I uploaded it, I'd better do my duty to merge conflicts.
As for the script code, as I commented yesterday, I personally don't think it's necessary and reasonable for Bethesdsa to ban singing during the entire quest process. That should be a stopgap measure in an unstable development environment. At least in my own test, even if I used the console to move Delphine countless times to trigger interaction, there was no interruption of the main quest.
So I just follow the conventional way, only kept the banning of singing in the scene of Esbern meet with Delphine as insurance.
Of course, there is no absolute safety guarantee, even if Bethesdsa has done in other quests.
Originally, this was just to solve my own troubles. For me, this way is the most reasonable with the least impact, and basically safe.
If you finished the main quest quickly, the impact of this bug is negligible.
But if you just stop the main quest at "Alduin's Wall" to do something else, you'll notice that bard Sven will never sing again, it doesn't work to request for songs also, and there's a lot less interaction in the Sleeping Giant Inn.
That's a bug? Damn... I thought it was a feature....
Ok, seriously, while it's not something I'd personally use (because aside from the gentleman in Markarth, I think the bards in Skyrim are terrible), it's good of you to share this sort of stuff.
I think it should be a fail-safe design, in order to temporarily prevent the interaction between singing Sven and Delphine, it may interfere with the meeting between Delphine and Esbern at the Sleeping Giant Inn, resulting in the interruption of the main quest.But it mistakenly continued to function even after the two left the Inn went to Alduin's Wall. This is totally unreasonable and harmful. So I fixed the script as intended.
20 comments
So +1 for me.
p.s. Please don't... unless ..
But if you just stop the main quest at "Alduin's Wall" to do something else, you'll notice that bard Sven will never sing again, it doesn't work to request for songs also, and there's a lot less interaction in the Sleeping Giant Inn. Maybe you don't care about these, but make me uncomfortable.
It's just a minor fix for those who care about the details and I actually didn't want to be a modder because don't have time to do support. I upload this because I initially thought it was the exchange of location owners that caused the issue, which made me waste time on checking scripts, just don't want others who are affected and want to fix the issues to take detours like me.
Just FYI, your script conflicts with the one form USSEP. I would suggest using the USSEP one as a base since it contains a lot more fixes.
Moreover, it conflicts with the script from the mod Bard Instrumentals Mostly - Sing Rarely (that script includes all USSEP fixes).
Just to be on the safe side, your script edits only line 381 of vanilla script?
That is, it changes (in Function PlaySong):
If Bard == Sven && MQ203.isrunning()to
if Bard == Sven && MQ203.GetStage() >= 10 && MQ203.GetStage() < 40
?Weird, as your changes were commented out by Bethesdsa...perhaps some testing they were running and forgot to revert back?
In any case thanks for spotting this!
Well, since I uploaded it, I'd better do my duty to merge conflicts.
As for the script code, as I commented yesterday, I personally don't think it's necessary and reasonable for Bethesdsa to ban singing during the entire quest process. That should be a stopgap measure in an unstable development environment. At least in my own test, even if I used the console to move Delphine countless times to trigger interaction, there was no interruption of the main quest.
So I just follow the conventional way, only kept the banning of singing in the scene of Esbern meet with Delphine as insurance.
Of course, there is no absolute safety guarantee, even if Bethesdsa has done in other quests.
Originally, this was just to solve my own troubles. For me, this way is the most reasonable with the least impact, and basically safe.
Check the other comments here as well.
But if you just stop the main quest at "Alduin's Wall" to do something else, you'll notice that bard Sven will never sing again, it doesn't work to request for songs also, and there's a lot less interaction in the Sleeping Giant Inn.
Damn... I thought it was a feature....
Ok, seriously, while it's not something I'd personally use (because aside from the gentleman in Markarth, I think the bards in Skyrim are terrible), it's good of you to share this sort of stuff.