cool app but you need to rethink how you handled dependencies. The binary just opens a blank console window for me so i downloaded the source which only worked after I commented out the subprocess call. Seems if you already have tkinter it will just fail. I'm not sure if its good practice to use a try catch block in the middle of your imports but you could wrap it with that or probably better way would be to include a batch file to download requirements on first setup. You could also include any other requirements and have it compile the exe afterwards to get a slightly more robust setup
there are also pretty significant bugs at least on my machine. Most are probably easy for me to resolve so if I decide to use this I'll make pull requests for anything I fix but I'll list some issues now:
close button doesn't work because you run the destroy method recursively triggering a recursive error at 1k repetitions if there are any files or if there are no files it errors out due to no children to close - I have to hit stop button in pycharm or if running from console I close the console window
change directory button fails because it tries to read an iconname attribute from coreEditor. I would just try catch this or remove the iconname call
only the first file of each type is read in the editor
lack of scrollbars or collapsible sections limits usability
no support for generic filetypes - adding things like .ini, .json, .txt, etc. to file_types_module kind of just worked about as well as the types you already supported. perhaps I'm missing some features for the supported types but either way you at least get a working line by line editor so I think you could expand it to take any generic text type and then if matching supported types add extra features like highlighting or block recognition
that's all I have time to look over right now. I'm also making a python script running/file explorer using pysimpleGUI/tkinter so I understand the pains of python GUI development. I had wanted to stick to python for learning purposes but I'm now at the point I think I'm going to just reimplement my core GUI in C# and run my python scripts compiled with cython from there. I was also planning on implementing many of the features you're working on here and will likely be able to do so pretty quickly with C# as my core. If that sounds interesting I can upload source for my project sooner than later for you to fork. If you'd rather keep working in your current codebase I think you're pretty close to having something nice for users and even in its current form its useful as learning material for me
Oh wait I just realized you're the same person with the DAR/OAR scripts I commented on a few days ago. I think I'll join your discord, just looking at your page on here I think we have enough common ground it makes sense to collab or at least code share. I'll post my WIP python version before I switch to C# in case its helpful for you
1 comment
there are also pretty significant bugs at least on my machine. Most are probably easy for me to resolve so if I decide to use this I'll make pull requests for anything I fix but I'll list some issues now:
close button doesn't work because you run the destroy method recursively triggering a recursive error at 1k repetitions if there are any files or if there are no files it errors out due to no children to close - I have to hit stop button in pycharm or if running from console I close the console window
change directory button fails because it tries to read an iconname attribute from coreEditor. I would just try catch this or remove the iconname call
only the first file of each type is read in the editor
lack of scrollbars or collapsible sections limits usability
no support for generic filetypes - adding things like .ini, .json, .txt, etc. to file_types_module kind of just worked about as well as the types you already supported. perhaps I'm missing some features for the supported types but either way you at least get a working line by line editor so I think you could expand it to take any generic text type and then if matching supported types add extra features like highlighting or block recognition
that's all I have time to look over right now. I'm also making a python script running/file explorer using pysimpleGUI/tkinter so I understand the pains of python GUI development. I had wanted to stick to python for learning purposes but I'm now at the point I think I'm going to just reimplement my core GUI in C# and run my python scripts compiled with cython from there. I was also planning on implementing many of the features you're working on here and will likely be able to do so pretty quickly with C# as my core. If that sounds interesting I can upload source for my project sooner than later for you to fork. If you'd rather keep working in your current codebase I think you're pretty close to having something nice for users and even in its current form its useful as learning material for me
Oh wait I just realized you're the same person with the DAR/OAR scripts I commented on a few days ago. I think I'll join your discord, just looking at your page on here I think we have enough common ground it makes sense to collab or at least code share. I'll post my WIP python version before I switch to C# in case its helpful for you