Hey, you should write Quality Bonus in the title so that way people don't overlook your mod. This seems kinda better than the other Quality Bonus mod, but I initially ignored it because what even is an Epicurean? I'm no dictionary, nor am I a wordsman.
Please do not give the mod a lame generic name when it has a cool one that is already pretty self-explanatory. You don't have to be a dictionary to know English.
Hey, you should write Quality Bonus in the title so that way people don't overlook your mod. This seems kinda better than the other Quality Bonus mod, but I initially ignored it because what even is an Epicurean? I'm no dictionary, nor am I a wordsman.
Looks like a great mod that I'll be happy to use. However, with the current wave of virus injected mods going on, I'm a bit wary of newly uploaded mods by users with no solid mod history. If somebody feels like risking it to prove my concerns wrong, please let me know how that went for you.
You weren't the only one to think that, this was temporarily taken down (made hidden) to be manually reviewed by a moderator. They didn't remove it after investigating because obviously it is clean, but what you're saying is completely fair and something I do expect.
This isn't technically my first mod but it is the first one I ever published to Nexus (and Thunderstore).
If you have any experience you're free to decompile the .dll file and check the code yourself, as it isn't a big mod.
Download it and scan it with whatever anti malware you most like. It's a dll, so correct me if I'm wrong, but if you just download it and do nothing with it, it's like you didn't downloaded it at all. Won't do anything on it's own just by being inside an empty folder.
Thanks for letting me know. I downloaded and checked it. The VirusTotal scan came back clean. It also does appear to be designed to do what it's intended to, at least judging by the config file.
However, at least as far as the bonus quality cash is concerned, it does not work for me. I have tried both completing and offering deals and the amount of money I receive is unchanged regardless of the customer's standards. I saved and restarted the game multiple times but the outcome was all the same. MelonLoader didn't log any errors either. I was using Quality Bonus Mod before and it was working fine (I made sure to remove it before installing this mod).
Also, this is not the first time I see recommendations to decompile. Could you elaborate on how one would go about doing that? Is there a way to get to the actual code with some light-weight tool or does one have to have an entire IDE for that?
That's interesting, because this mod was inspired by the Quality Bonus mod because I wasn't satisfied with it. It uses very similar methods in giving you bonus cash. MelonLoader should have a console that logs the mods' deals:
See if these are showing up? If they're not, it's likely the mod itself isn't loading properly at all.
As for decompiling, you can use an IDE but there is a lightweight open source tool called dnSpy. It's what I personally used to parse the game's source code to make the mod. You do need to know how to navigate it, but once you figure it out, you should be able to look at the source code of any mod without it running due to how .dll files work.
I tried testing it again and it does work and logs everything but only for the dealer deals: [18:22:14.185] Contract payment: $1210.00, Items quantity: 1 [18:22:14.185] Tiers above standard: 4 (40% bonus), Bonus: $484.00 [18:22:16.591] StorageEntity.SetItemSlotQuantity (index: 4, quantity: 1) [18:22:16.591] StorageEntity.SetItemSlotQuantity (index: 4, quantity: 1) [18:22:17.176] Contract payment: $575.00, Items quantity: 1 [18:22:17.176] Tiers above standard: 2 (20% bonus), Bonus: $115.00 [18:22:19.290] StorageEntity.SetItemSlotQuantity (index: 2, quantity: 8) [18:22:19.290] StorageEntity.SetItemSlotQuantity (index: 2, quantity: 8) When I do deals myself, there is no bonus and there are no logs.
Another thing that I have noticed while testing is when I dealing myself and have an item deposited into the offer cell, it occasionally completely disappears. It seems to coincide with dealers making a deal. Might be something you want to look into as well. I do have a concoction of 20 mods, but everything was working fine before this one.
I think I understand what the issue is, just to be sure, try making a sale at night (with a customer coming to you rather than you to them) and see if it works then?
Thank you for reporting this to me. I'll see if I can update this to fix that issue.
However this mod does nothing with the inventory or sale window, so I have no idea what's causing that.
EDIT: It works as long as customers come to you (after curfew is not required), if you request a sale from someone yourself it doesn't seem to give the bonus.
"Complete Deal" worked as intended, so it seems that only "Offer a deal" has things going wrong with it.
As for the sale window items disappearing, it doesn't seem to happen if dealers aren't dealing (after 4 AM, for example). So it looks like it is triggered by the dealer sales. It definitely could be some other mod triggering it, since I never created conditions for it to happen before installing this mod (keeping the item in the sale window for a while). If you think your mod has nothing to do with it, then you're most likely right.
25 comments
Nice mod :))
Nice mod :))
(NVM)
Personally i think this is the better mod. No explanation needed!
However, with the current wave of virus injected mods going on, I'm a bit wary of newly uploaded mods by users with no solid mod history.
If somebody feels like risking it to prove my concerns wrong, please let me know how that went for you.
This isn't technically my first mod but it is the first one I ever published to Nexus (and Thunderstore).
If you have any experience you're free to decompile the .dll file and check the code yourself, as it isn't a big mod.
However, at least as far as the bonus quality cash is concerned, it does not work for me. I have tried both completing and offering deals and the amount of money I receive is unchanged regardless of the customer's standards. I saved and restarted the game multiple times but the outcome was all the same. MelonLoader didn't log any errors either. I was using Quality Bonus Mod before and it was working fine (I made sure to remove it before installing this mod).
Also, this is not the first time I see recommendations to decompile. Could you elaborate on how one would go about doing that? Is there a way to get to the actual code with some light-weight tool or does one have to have an entire IDE for that?
[00:57:18.880] Contract payment: $325.00, Items quantity: 2
[00:57:18.880] Tiers above standard: 2 (20% bonus), Bonus: $65.00
See if these are showing up? If they're not, it's likely the mod itself isn't loading properly at all.
As for decompiling, you can use an IDE but there is a lightweight open source tool called dnSpy. It's what I personally used to parse the game's source code to make the mod. You do need to know how to navigate it, but once you figure it out, you should be able to look at the source code of any mod without it running due to how .dll files work.
I tried testing it again and it does work and logs everything but only for the dealer deals:
[18:22:14.185] Contract payment: $1210.00, Items quantity: 1[18:22:14.185] Tiers above standard: 4 (40% bonus), Bonus: $484.00
[18:22:16.591] StorageEntity.SetItemSlotQuantity (index: 4, quantity: 1)
[18:22:16.591] StorageEntity.SetItemSlotQuantity (index: 4, quantity: 1)
[18:22:17.176] Contract payment: $575.00, Items quantity: 1
[18:22:17.176] Tiers above standard: 2 (20% bonus), Bonus: $115.00
[18:22:19.290] StorageEntity.SetItemSlotQuantity (index: 2, quantity: 8)
[18:22:19.290] StorageEntity.SetItemSlotQuantity (index: 2, quantity: 8)
When I do deals myself, there is no bonus and there are no logs.
Another thing that I have noticed while testing is when I dealing myself and have an item deposited into the offer cell, it occasionally completely disappears. It seems to coincide with dealers making a deal. Might be something you want to look into as well. I do have a concoction of 20 mods, but everything was working fine before this one.
Thank you for reporting this to me. I'll see if I can update this to fix that issue.
However this mod does nothing with the inventory or sale window, so I have no idea what's causing that.
EDIT: It works as long as customers come to you (after curfew is not required), if you request a sale from someone yourself it doesn't seem to give the bonus.
As for the sale window items disappearing, it doesn't seem to happen if dealers aren't dealing (after 4 AM, for example). So it looks like it is triggered by the dealer sales. It definitely could be some other mod triggering it, since I never created conditions for it to happen before installing this mod (keeping the item in the sale window for a while). If you think your mod has nothing to do with it, then you're most likely right.
Thanks for taking care of that so promptly!
Definitely one of the must-have mods!