The mod duplicates the functionality of Enter Castle and Town with a Horse, but it lacks the 'Make cloth\leather harness civilian' functionality. Not sure, did they make it civilian by default now?
I have some general recommendations: * It's better to make mods that use Harmony depend on the Harmony package instead of providing your own 0Harmony.dll; * `new Harmony(ID).PatchAll()`, especially `new Harmony(ID).UnpatchAll()` should not be used, manually patching like this gives more control and is more error-prone; * Since Harmony is used, you can find methods via `var spawnPlayerMethod = AccessTools.Method(typeof(MissionAgentHandler), "SpawnPlayer");` instead of `var spawnPlayerMethod = typeof(MissionAgentHandler).GetMethod("SpawnPlayer", BindingFlags.Instance | BindingFlags.Public);`
I was just thinking we needed something like this. Thank you very much for the addition.
This isn't a criticism just something I noticed: if you enter a town to walk around after sneaking in, your character wears a disguise that doesn't include a horse, so you'll be on foot still in those cases.
7 comments
I have some general recommendations:
* It's better to make mods that use Harmony depend on the Harmony package instead of providing your own 0Harmony.dll;
* `new Harmony(ID).PatchAll()`, especially `new Harmony(ID).UnpatchAll()` should not be used, manually patching like this gives more control and is more error-prone;
* Since Harmony is used, you can find methods via `var spawnPlayerMethod = AccessTools.Method(typeof(MissionAgentHandler), "SpawnPlayer");` instead of `var spawnPlayerMethod = typeof(MissionAgentHandler).GetMethod("SpawnPlayer", BindingFlags.Instance | BindingFlags.Public);`
https://www.nexusmods.com/mountandblade2bannerlord/mods/328
This isn't a criticism just something I noticed: if you enter a town to walk around after sneaking in, your character wears a disguise that doesn't include a horse, so you'll be on foot still in those cases.