when it levels up a major skill and you're not using ncgd, it doesn't count towards the character level this could be circumvented by only setting the skill progress and letting the game handle the levelup on the next cast
Using OpenMW 0.49 Dev build, as well as the appropriate dev build version of NCGD Lua, as the main release build of NCGD Lua doesn't work on the very newest versions of OpenMW.
NCGD works fine, but the MBSP script options do not show up. I assume like the original there is a popup at the beginning of the game as well to let you know that is running, if it does, then that is not popping up either.
Going through the log I can only find a few things, funny enough both NCGD and MBSP share at least one, probably frivolous, error.
[21:58:14.788 I] L@0x1[scripts/omw/settings/player.lua]: Can't register setting renderer "NCGDMW_hotkey". registerRenderer and moved to Menu context Settings interface [21:58:14.790 V] Language file "l10n/MBSP_Uncapper/en.yaml" is enabled [21:58:14.790 I] L@0x1[scripts/omw/settings/player.lua]: Can't register setting renderer "MBSP_Uncapper_hotkey". registerRenderer and moved to Menu context Settings interface and then a little further down is the only other error I can find
[21:58:15.071 E] Menu[scripts/omw/settings/menu.lua] eventHandler[OmWSettingsRegisterPage] failed. Lua error: [string "scripts/omw/settings/menu.lua"]:91: Setting progressMenuKey of SettingsPlayerMBSP_Uncapper has unknown renderer MBSP_Uncapper_hotkey [21:58:15.071 E] stack traceback: [21:58:15.071 E] [C]: in function 'error' [21:58:15.071 E] [string "scripts/omw/settings/menu.lua"]:91: in function 'renderSetting' [21:58:15.071 E] [string "scripts/omw/settings/menu.lua"]:151: in function 'renderGroup' [21:58:15.071 E] [string "scripts/omw/settings/menu.lua"]:284: in function 'renderPage' [21:58:15.071 E] [string "scripts/omw/settings/menu.lua"]:468: in function 'registerPage' [21:58:15.071 E] [string "scripts/omw/settings/menu.lua"]:507: in function <[string "scripts/omw/settings/menu.lua"]:506>
The moment I hit 100 destruction my current magicka starts increasing over the maximum really fast going into the thousands due to the Refunder feature. Also, the mod is not showing up on my OpenMW scripts menu anymore since ~Feb 15th builds.
The newer versions of OpenMW removed some backwards compatibility which broke the scripts menu. To fix it, you just need to navigate where your mod is installed. Go to MBSP Uncapper\scripts\MBSP_Uncapper\ and create a new file called menu.lua and paste the following inside:
local async = require('openmw.async') local input = require('openmw.input') local I = require("openmw.interfaces")
I.Settings.registerRenderer( 'MBSP_Uncapper_hotkey', function(value, set) return { template = I.MWUI.templates.textEditLine, props = { text = value and input.getKeyName(value) or '', }, events = { keyPress = async:callback(function(e) set(e.code) end) } } end)
Then edit player.lua and remove the following lines:
I.Settings.registerRenderer( 'MBSP_Uncapper_hotkey', function(value, set) return { template = I.MWUI.templates.textEditLine, props = { text = value and input.getKeyName(value) or '', }, events = { keyPress = async:callback(function(e) set(e.code) end) } } end)
Lastly, you need to edit the MBSP_Uncapper.omwscripts file and add the following line:
Whenever I load a save, skill growth for skills at/above 100 resets to 0. I unloaded every mod after this one so I don't think it should be a mod conflict. I am using NCGDMW lua edition and OpenMW 0.48.
Does it make sense to use onFrame instead of onUpdate, so you can catch updates to speechcraft when the UI is open? FWIW I'll be moving NCGD over to onFrame in a coming update :)
I would be very surprised if it worked with TES3MP out of the box. The current version of TES3MP is forked from OpenMW 0.47, so the functions used in this mod's code would probably just throw errors.
With that being said, TES3MP does have it's own functions that work better for this type of mod than current (0.48) OpenMW ones.
For example, an event handler can bet set up that directly gives the skill which increased (instead of cycling through every skill each tick). Also, checking the active spell and its cost are possible.
There is a TES3MP MBSP on github, but I don't remember if it includes an uncapper or customization options.
I changed: local dif = types.Player.stats.skills[skill](self).progress - skillProgress[skill] to: local dif = types.Player.stats.skills[skill](self).progress + skillProgress[skill]
Not sure yet if that change is correct, but it does result in my XP increasing now.
edit:
what also works is types.Player.stats.skills[skill](self).progress = skillProgress[skill] + (deltaMagicka / playerStorage:get("magickaXPRate")) * dif - dif to: types.Player.stats.skills[skill](self).progress = skillProgress[skill] + (deltaMagicka / playerStorage:get("magickaXPRate")) * dif
I guess the issue has to be somewhere in that area.
I should have checked the comments first - I'm experiencing the same issue and opened a Bug Report. My Alteration leveled, so maybe cross-referencing its script with the issues Destruction and Conjuration (in my experience), and apparently Restoration are facing will help.
I have gone back to alvazir's MBSP+BetterSounds+NCDGMW plugin for now. Couldn't figure out how to fix the script from MBSP Uncapped, since my mentioned changes also caused the XP gain to behave like vanilla.
Basically, it was applying the XP bonus to the previous level of skill progress (not the current), which was resulting in negative progress when the bonus XP was less than the vanilla XP (or at least reduced progress).
I threw Rebirth onto the end of my current load order and tested the updated version on a new character. Behavior was correct, but let me know if you continue to encounter issues with the updated version.
28 comments
this could be circumvented by only setting the skill progress and letting the game handle the levelup on the next cast
Using OpenMW 0.49 Dev build, as well as the appropriate dev build version of NCGD Lua, as the main release build of NCGD Lua doesn't work on the very newest versions of OpenMW.
NCGD works fine, but the MBSP script options do not show up. I assume like the original there is a popup at the beginning of the game as well to let you know that is running, if it does, then that is not popping up either.
Going through the log I can only find a few things, funny enough both NCGD and MBSP share at least one, probably frivolous, error.
[21:58:14.788 I] L@0x1[scripts/omw/settings/player.lua]: Can't register setting renderer "NCGDMW_hotkey". registerRenderer and moved to Menu context Settings interface[21:58:14.790 V] Language file "l10n/MBSP_Uncapper/en.yaml" is enabled
[21:58:14.790 I] L@0x1[scripts/omw/settings/player.lua]: Can't register setting renderer "MBSP_Uncapper_hotkey". registerRenderer and moved to Menu context Settings interface
and then a little further down is the only other error I can find
[21:58:15.071 E] Menu[scripts/omw/settings/menu.lua] eventHandler[OmWSettingsRegisterPage] failed. Lua error: [string "scripts/omw/settings/menu.lua"]:91: Setting progressMenuKey of SettingsPlayerMBSP_Uncapper has unknown renderer MBSP_Uncapper_hotkey
[21:58:15.071 E] stack traceback:
[21:58:15.071 E] [C]: in function 'error'
[21:58:15.071 E] [string "scripts/omw/settings/menu.lua"]:91: in function 'renderSetting'
[21:58:15.071 E] [string "scripts/omw/settings/menu.lua"]:151: in function 'renderGroup'
[21:58:15.071 E] [string "scripts/omw/settings/menu.lua"]:284: in function 'renderPage'
[21:58:15.071 E] [string "scripts/omw/settings/menu.lua"]:468: in function 'registerPage'
[21:58:15.071 E] [string "scripts/omw/settings/menu.lua"]:507: in function <[string "scripts/omw/settings/menu.lua"]:506>
local async = require('openmw.async')
local input = require('openmw.input')
local I = require("openmw.interfaces")
I.Settings.registerRenderer(
'MBSP_Uncapper_hotkey', function(value, set)
return {
template = I.MWUI.templates.textEditLine,
props = {
text = value and input.getKeyName(value) or '',
},
events = {
keyPress = async:callback(function(e)
set(e.code)
end)
}
}
end)
Then edit player.lua and remove the following lines:
I.Settings.registerRenderer(
'MBSP_Uncapper_hotkey', function(value, set)
return {
template = I.MWUI.templates.textEditLine,
props = {
text = value and input.getKeyName(value) or '',
},
events = {
keyPress = async:callback(function(e)
set(e.code)
end)
}
}
end)
Lastly, you need to edit the MBSP_Uncapper.omwscripts file and add the following line:
MENU: Scripts\MBSP_Uncapper\menu.lua
Loving this mod so far, really nice job with it!
Edit: Can this be applied to a TES3MP server, since they can load .LUAs?
With that being said, TES3MP does have it's own functions that work better for this type of mod than current (0.48) OpenMW ones.
For example, an event handler can bet set up that directly gives the skill which increased (instead of cycling through every skill each tick). Also, checking the active spell and its cost are possible.
There is a TES3MP MBSP on github, but I don't remember if it includes an uncapper or customization options.
No idea what's going on.
I am playing with NCDGMW and Morrowind Rebirth.
local dif = types.Player.stats.skills[skill](self).progress - skillProgress[skill]to:
local dif = types.Player.stats.skills[skill](self).progress + skillProgress[skill]Not sure yet if that change is correct, but it does result in my XP increasing now.
edit:
what also works is
types.Player.stats.skills[skill](self).progress = skillProgress[skill] + (deltaMagicka / playerStorage:get("magickaXPRate")) * dif - difto:
types.Player.stats.skills[skill](self).progress = skillProgress[skill] + (deltaMagicka / playerStorage:get("magickaXPRate")) * difI guess the issue has to be somewhere in that area.
Changed:
types.Player.stats.skills[skill](self).progress = skillProgress[skill] + (deltaMagicka / playerStorage:get("magickaXPRate")) * dif - dif
To:
types.Player.stats.skills[skill](self).progress = types.Player.stats.skills[skill](self).progress + (deltaMagicka / playerStorage:get("magickaXPRate")) * dif - dif
Basically, it was applying the XP bonus to the previous level of skill progress (not the current), which was resulting in negative progress when the bonus XP was less than the vanilla XP (or at least reduced progress).
I threw Rebirth onto the end of my current load order and tested the updated version on a new character. Behavior was correct, but let me know if you continue to encounter issues with the updated version.
Thanks for the feedback!