Thank you all for your valuable feedback, testing, and bug reports which helps me make this better. Further feedback and bug reports welcome.
Known issues: M+KB: Clicking on a disabled item will trigger a queue (e.g. a trap icon with a red X over it)
Planned: Item bar compatibility
2.4 - On received hit cancel should now work as intended, e.g. ignoring friendly hits, with rocksteady on. Now enabled as default. - Some reorganizing of the settings, sunsetting reset timers - Added: option to let queue persist through X amount of dodges
After the last few updates, my settings started not saving. I don't see any other reports, so it may be a personal issue on my part. Sorry for the translator.
The mod works great under normal circumstances but seems to brute force inputs, which interacts in a bad way when crafting an item from your radial menu. I've CTD'd twice since installing the mod after using a shortcut key to craft Flash Pods. It worked fine the first time in a fight, but the second time I pressed the key in the same right, it crashed. Happened like this both times so far.
When you say shortcut key, are you refering to an actual "just craft" item on the radial menu or are you referring to using M+KB? Are you trying to craft 1-by-1 or all?
I'm using M+KB with the option to disable cursor when the shortcut bars are active. This is what my setup looks like:
While in combat, I select the 2nd bar and press my 2 key to craft additional flash pods one-by-one. The mod appears to cause me to attempt to craft a ton at once. It's fine the first time around while in combat, but the second time in the same fight I've tried to use the same key, my game crashes. I can try to poke around more and get you a proper testcase
Edit: I also use the following mods, if it helps:
CatLib Auto Focus Mode Auto Close Recommendation Dialog No KeyLag Persistent Buff Glow Removal Better Camera Distance Disable Near Fade
Edit 2:
The crashes happened while in a random SOS against AT Rey Dau with 4 total players. Not sure if being in a multiplayer session changes things but figured I'd mention that too
Alright so I tried again in a quest where I was technically in a multiplayer lobby (but password protected), and used my keys to craft potions. Both my potion craft shortcuts are one-by-one as well, and they were also spam crafted on use. I went to use a potion very shortly after the potions crafted, and my game crashed.
In this I went to craft potions again, then tried to spam drinking them to see if I could repro the issue. I'm at full HP so presumably nothing happens here. I then go down a line, attempt to craft flash pods, see I'm full, then go to equip them and the game crashes at the point the video and audio freeze. I do spam the button a few times, but hopefully this illustrates the issue I'm having. Might not actually be related to crafting items as I originally thought, as spamming the button to drink a potion without crafting anything caused a crash as well.
Hullo, me again to annoy you! Decided to try removing all my other mods and the crash still occurs. :/ I was wrong about it having to do anything with crafting so I am sorry if I mislead you. I pretty much 100% repro the crash by spamming potions while in combat. Let me know if there's any other details you'd like, and thanks again for the work you put into this
Basicly the crash was caused by a bug that the queue is not cleared in certain conditions. This should be fixed in the next release.
In regards to crafting, it is a bit tricky to resolve because we have to cover both cases, that you have a static recipe to craft one by one, and an empty item slot which requests to craft the item you're trying to use. But initially these are identical.
Im thinking I will release a temporary patch later which is 90% fixed as it's better than nothing :)
Thank you for the update! Unfortunately my situation has not improved; I logged on after updating the mod to 1.9v3 and CTD'd twice, both times immediately after attempting to use an item in the middle of using another item while in combat. :(
Maybe I did something wrong? I noticed a new folder in the package labelled '.vs' which I guess is visualstudio and wasn't sure if that should be in there or if I should also plop that into my reframework directory.
I hadn't tried in the training area, just regular combat against a monster. Just went to the training area and I was able to trigger a CTD after smacking the dummy a bit, sharpening my weapon, and then selecting to equip Flash Pods during the animation. I did Recommended Lobby and not Online Single Player if that matters.
After deleting the .json file you mentioned and restarting the game fresh, I still got a CTD. I can 100% repro the issue by rapidly pressing the shortcut to equip/unequip flash pods and the "V" key to manually close the shortcut menu while the Flash Pod unequip animation is playing.
Thank you! Your help has been incredibly valuable.
I was able to reproduce this and the cause is that the way the item is saved requires the M+KB hud to be open for it to be executed. Considering that, do you think that an option to automaticly close the menu on successfull item would be useful?
Ah, great! I'm happy to be able to help! Yes, I think an option to close the UI after an item is used would be useful, although I believe there is already a mod that does this here, so I wouldn't want you to step on anyone's toes. That said, I haven't tried this other mod and would prefer it all be in a single package for compatibility's sake. Thank you!!
When I begin to sharping in combat and get hit by monster, as soon as I recover my hunter would start sharping immediately without any input. I am not sure if it is a setting in the mod I can disable this?
For some reason, your mod gives me a glowing orange circle on my screen. I turned off my mods, and turned each one on, one by one, to figure out which mod was causing it, and it was this one. Don't know why that's happening.
Sorry, where does the visual indicator pop up? Can you provide us with a footage or maybe an screenshot? Loving the mod so far, thanks for putting your time and effort. Keep the good job up.
In the options there is an "enable indicator option", by default it should pop up somewhere to the right of the healthbar. There is a preview so it should be fairly obvious when you enable it. :)
I put Shoutouts on my radials for taunting purposes, but they get procced >100x at once with this mod. it then gets stuck on "Could not send the message, Please wait and try again" repeatedly until I reset/disable the script. Using v1.6
103 comments
Further feedback and bug reports welcome.
Known issues:
M+KB: Clicking on a disabled item will trigger a queue (e.g. a trap icon with a red X over it)
Planned:
Item bar compatibility
2.4
- On received hit cancel should now work as intended, e.g. ignoring friendly hits, with rocksteady on. Now enabled as default.
- Some reorganizing of the settings, sunsetting reset timers
- Added: option to let queue persist through X amount of dodges
I don't see any other reports, so it may be a personal issue on my part.
Sorry for the translator.
I haven't noticed this myself. And I wasn't able to recreate this.
Can you elaborate a bit?
When you say shortcut key, are you refering to an actual "just craft" item on the radial menu or are you referring to using M+KB?
Are you trying to craft 1-by-1 or all?
While in combat, I select the 2nd bar and press my 2 key to craft additional flash pods one-by-one. The mod appears to cause me to attempt to craft a ton at once. It's fine the first time around while in combat, but the second time in the same fight I've tried to use the same key, my game crashes. I can try to poke around more and get you a proper testcase
Edit: I also use the following mods, if it helps:
CatLib
Auto Focus Mode
Auto Close Recommendation Dialog
No KeyLag
Persistent Buff Glow Removal
Better Camera Distance
Disable Near Fade
Edit 2:
The crashes happened while in a random SOS against AT Rey Dau with 4 total players. Not sure if being in a multiplayer session changes things but figured I'd mention that too
https://imgur.com/eOJM01U
In this I went to craft potions again, then tried to spam drinking them to see if I could repro the issue. I'm at full HP so presumably nothing happens here. I then go down a line, attempt to craft flash pods, see I'm full, then go to equip them and the game crashes at the point the video and audio freeze. I do spam the button a few times, but hopefully this illustrates the issue I'm having. Might not actually be related to crafting items as I originally thought, as spamming the button to drink a potion without crafting anything caused a crash as well.
In regards to crafting, it is a bit tricky to resolve because we have to cover both cases, that you have a static recipe to craft one by one, and an empty item slot which requests to craft the item you're trying to use. But initially these are identical.
Im thinking I will release a temporary patch later which is 90% fixed as it's better than nothing :)
Maybe I did something wrong? I noticed a new folder in the package labelled '.vs' which I guess is visualstudio and wasn't sure if that should be in there or if I should also plop that into my reframework directory.
I thought it could be related to the 4-row setup you use, but I still wasnt able to recreate it :(
Just to have done it, can you try and delete the radial_queue.json from the reframework/autorun folder and let the mod create a new config file?
https://imgur.com/q2MdIsB
I was able to reproduce this and the cause is that the way the item is saved requires the M+KB hud to be open for it to be executed.
Considering that, do you think that an option to automaticly close the menu on successfull item would be useful?
Sorry, where does the visual indicator pop up? Can you provide us with a footage or maybe an screenshot?
Loving the mod so far, thanks for putting your time and effort. Keep the good job up.
When press the - or = key next to Backspace, the 1 next to ESC is also pressed.
I'm using 63key keyboard
https://imgur.com/x3Bh1Yj
Famous last words