posted already on the bug section of the mod but i post it here anyways, i am unable to install the mod, modutil installed fine but when trying to install the reroll mod this happens
ERROR:MainExceptions:Encountered uncaught exception while implementing mod changes Traceback (most recent call last): File "L:\Steam\steamapps\common\Hades\Content\modimporter.py", line 580, in makeedit mergesjson(base,mod.data[0]) File "L:\Steam\steamapps\common\Hades\Content\modimporter.py", line 349, in mergesjson indata = readsjson(infile) File "L:\Steam\steamapps\common\Hades\Content\modimporter.py", line 291, in readsjson return sjson.loads(open(filename,'r',encoding='utf-8-sig').read()) File "C:\Users\Jaim\AppData\Local\Programs\Python\Python39\lib\site-packages\sjson\__init__.py", line 394, in loads return _decode_dict(MemoryInputStream(text.encode('utf-8'))) File "C:\Users\Jaim\AppData\Local\Programs\Python\Python39\lib\site-packages\sjson\__init__.py", line 326, in _decode_dict value = _parse(stream) File "C:\Users\Jaim\AppData\Local\Programs\Python\Python39\lib\site-packages\sjson\__init__.py", line 377, in _parse return _parse_list(stream) File "C:\Users\Jaim\AppData\Local\Programs\Python\Python39\lib\site-packages\sjson\__init__.py", line 346, in _parse_list value = _parse(stream) File "C:\Users\Jaim\AppData\Local\Programs\Python\Python39\lib\site-packages\sjson\__init__.py", line 369, in _parse return _decode_dict(stream, True) File "C:\Users\Jaim\AppData\Local\Programs\Python\Python39\lib\site-packages\sjson\__init__.py", line 326, in _decode_dict value = _parse(stream) File "C:\Users\Jaim\AppData\Local\Programs\Python\Python39\lib\site-packages\sjson\__init__.py", line 371, in _parse return _decode_string(stream) File "C:\Users\Jaim\AppData\Local\Programs\Python\Python39\lib\site-packages\sjson\__init__.py", line 263, in _decode_string result += _decode_escaped_character(stream.read()) TypeError: can't concat NoneType to bytearray The above exception was the direct cause of the following exception: Traceback (most recent call last): File "L:\Steam\steamapps\common\Hades\Content\modimporter.py", line 660, in <module> start() File "L:\Steam\steamapps\common\Hades\Content\modimporter.py", line 647, in start makeedit(base,mods) File "L:\Steam\steamapps\common\Hades\Content\modimporter.py", line 588, in makeedit raise RuntimeError("Encountered uncaught exception while implementing mod changes") from e RuntimeError: Encountered uncaught exception while implementing mod changes
I answered in the Bug section too. My guess is this is due to the version of ModUtil I packaged with my mod. I believe they made non backwards compatible changes in modimporter that no longer work with ModUtil.
So first try using the ModUtil found here: https://www.nexusmods.com/hades/mods/27
Throughout the game, the thought of rerolling the Hammer of Daedalus did not leave me, why did the developers not immediately do this? Riddle. But thank you for the modification, I am very glad that you made it! Thanks!
having issues with this mod. whenever i open the in-game menu, game insta crashes and asks me to submit a bug report. when i open it back up, it lets me into the menu but i cant change any options or leave the menu. hopefully you can help
If I want to install the mod manually without installing python, will the manual installation instruction on LRevolution's Codex mod page should work as well? Apart from changing the mod's name for the last Import part.
Yes, but you would still need both ModUtil and this mod (they are packaged together). So at the bottom of RoomManager.lua you would add:
Import "../Mods/ModUtil/ModUtil.lua" Import "../Mods/ModUtil/ModUtilPyre.lua" Import "../Mods/ModUtil/ModUtilHades.lua" Import "../Mods/EllosRerollEverythingMod/Reroll.lua" Import "../Mods/EllosRerollEverythingMod/RerollUI.lua" I wrote that from memory, so if it doesn't work, make sure the paths look correct. Worst case you can join the modding discord and ask for more help there! https://discord.gg/KuMbyrN
Thanks for the reply, gonna give it a shot later! The last file should be RerollSettingsUI.lua instead I think? What about the helptext.sjson instead?
*update* Yup, it works great! Any chance you might update it in the future so that the reroll button can be selected via controller? Nothing crucial but figured it would make a good quality of life upgrade. Thanks for the mod too!
You just mean the button to open the Reroll config menu right?
Honestly controller controls in menus is not very easy to modify as far as I can tell. So unlikely I will tackle this, but will keep it mind if I find out a way to improve it
I am able to use the mod menu in game to change the rerolls to free, but it doesn't seem to be working anymore with the newest update. It just takes my rerolls like the vanilla game despite the settings I choose. Hope it just needs an easy update. Thanks for the mod when it worked though, cheers. Update- I joined the modding discord and think I may be doing something wrong.
I know we talked in the Discord briefly, but v2.0 supports both types of rerolls now. So regardless of your mirror, it should work now. Let me know if I can help with anything else
Seeing the same weirdness with repeated rolls, seems to cicle between the same choices after a few rolls.
Also, during a trial between two gods the rerolls had a cost to them. After that every boon I found also had a cost to reroll. I had everything set to reroll cost = 0.
Thanks for reporting these issues. I believe the repeated rolls is once all options have been seen. basically it has a mechanism to prevent seeing the same options by removing a boon from the pool each time. Eventually its down to the last three and no more rerolls are possible. I can look into fixing this at some point
Trials might have some different logic that is messing with things. I will investigate
Fixed the first issue. Have not revisited the second one just yet. I will take a look when I get more time. Hopefully v2.0 gets you most of what you need though!
Thanks for this, is there a max cap on how many rerolls you can do for stuff? Trying to reroll chaos and it stopped working after the first roll, had it on 0/0.
Also running the starting boon selector-mod, dunno if that is relevant.
I'm seeing similar weirdness with repeated rerolls - it looks like the first reroll is a "real" one and most of the ones after that (for all boons, anyway) are not working or are stuck in a cycle. Chaos specifically seems to stop rerolling at all pretty quick but I've noticed this for all boon rerolling in the 3 runs I've tried.
Checking an ares-reroll now, and it seems to reroll three times and then cycle the same three options, never changing the actual quality of your boon. As in a normal boon seem to stay normal and not show up as anything of better. If I was to hazard a guess at what is happening, it eventually shows all the possible boons you can have, but it doesn't re-randomize the quality of it.
Edit: No, it doesn't give you all the available boon-options either, so I dunno what it does really. (was eligeble for Dire Misfortune for my Ares and it never showed up no matter how many rerolls I did, the same 4 options of choices repeat, some of them include the same boon with the exact same rarity). Next on Athena I am seeing the call in different rarities, so I guess that isnt locked down. Still just 4 "rolls" total that cycle.
Edit2: Same run, Ares again: Rerolled maybe 40 times (started taking notes a while into the rolls) and I got 6 different sets, but it is really weird the way they get presented, it basically rolled the same two sets maybe 70% of the time. (in my notes the two most prevalent sets have shown up 12 and 13 times each and only two of the total six options shown showed up after I started notating how many times stuff showed up, those two other sets showed up 2 and 3 times each during the time I took notes)
Hmm thanks for the very detailed notes. I will need to investigate. To be honest, I didn't fully investigate the reroll mechanism, I primarily targeted just changing the cost. I will try to reproduce and determine if its something in the mod or if the vanilla game has this issue too. Judging from your impending doom anecdote, it sounds like the former
Thanks everyone for the reports. Please see v2.0 which fixes most known issues right now (including the randomness issues) and also adds a lot of functionality that was missing (Room rerolls!)
Give Feedback
27 comments
https://www.nexusmods.com/hades/mods/27
This will resolve the failures you were seeing. Sorry for the long delay in response
ERROR:MainExceptions:Encountered uncaught exception while implementing mod changes
Traceback (most recent call last):
File "L:\Steam\steamapps\common\Hades\Content\modimporter.py", line 580, in makeedit
mergesjson(base,mod.data[0])
File "L:\Steam\steamapps\common\Hades\Content\modimporter.py", line 349, in mergesjson
indata = readsjson(infile)
File "L:\Steam\steamapps\common\Hades\Content\modimporter.py", line 291, in readsjson
return sjson.loads(open(filename,'r',encoding='utf-8-sig').read())
File "C:\Users\Jaim\AppData\Local\Programs\Python\Python39\lib\site-packages\sjson\__init__.py", line 394, in loads
return _decode_dict(MemoryInputStream(text.encode('utf-8')))
File "C:\Users\Jaim\AppData\Local\Programs\Python\Python39\lib\site-packages\sjson\__init__.py", line 326, in _decode_dict
value = _parse(stream)
File "C:\Users\Jaim\AppData\Local\Programs\Python\Python39\lib\site-packages\sjson\__init__.py", line 377, in _parse
return _parse_list(stream)
File "C:\Users\Jaim\AppData\Local\Programs\Python\Python39\lib\site-packages\sjson\__init__.py", line 346, in _parse_list
value = _parse(stream)
File "C:\Users\Jaim\AppData\Local\Programs\Python\Python39\lib\site-packages\sjson\__init__.py", line 369, in _parse
return _decode_dict(stream, True)
File "C:\Users\Jaim\AppData\Local\Programs\Python\Python39\lib\site-packages\sjson\__init__.py", line 326, in _decode_dict
value = _parse(stream)
File "C:\Users\Jaim\AppData\Local\Programs\Python\Python39\lib\site-packages\sjson\__init__.py", line 371, in _parse
return _decode_string(stream)
File "C:\Users\Jaim\AppData\Local\Programs\Python\Python39\lib\site-packages\sjson\__init__.py", line 263, in _decode_string
result += _decode_escaped_character(stream.read())
TypeError: can't concat NoneType to bytearray
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "L:\Steam\steamapps\common\Hades\Content\modimporter.py", line 660, in <module>
start()
File "L:\Steam\steamapps\common\Hades\Content\modimporter.py", line 647, in start
makeedit(base,mods)
File "L:\Steam\steamapps\common\Hades\Content\modimporter.py", line 588, in makeedit
raise RuntimeError("Encountered uncaught exception while implementing mod changes") from e
RuntimeError: Encountered uncaught exception while implementing mod changes
anyone know why i cannot install this mod?
So first try using the ModUtil found here:
https://www.nexusmods.com/hades/mods/27
and let me know if you still experience issues
Import "../Mods/ModUtil/ModUtil.lua"Import "../Mods/ModUtil/ModUtilPyre.lua"
Import "../Mods/ModUtil/ModUtilHades.lua"
Import "../Mods/EllosRerollEverythingMod/Reroll.lua"
Import "../Mods/EllosRerollEverythingMod/RerollUI.lua"
I wrote that from memory, so if it doesn't work, make sure the paths look correct. Worst case you can join the modding discord and ask for more help there!
https://discord.gg/KuMbyrN
*update*
Yup, it works great! Any chance you might update it in the future so that the reroll button can be selected via controller? Nothing crucial but figured it would make a good quality of life upgrade. Thanks for the mod too!
Honestly controller controls in menus is not very easy to modify as far as I can tell. So unlikely I will tackle this, but will keep it mind if I find out a way to improve it
Update- I joined the modding discord and think I may be doing something wrong.
Also, during a trial between two gods the rerolls had a cost to them. After that every boon I found also had a cost to reroll. I had everything set to reroll cost = 0.
Trials might have some different logic that is messing with things. I will investigate
Also running the starting boon selector-mod, dunno if that is relevant.
Likely I just missed some special cases. Feel free to report any others you find.
Currently I'm also aware that cost = 0 does not work for wells of charon
Edit: No, it doesn't give you all the available boon-options either, so I dunno what it does really. (was eligeble for Dire Misfortune for my Ares and it never showed up no matter how many rerolls I did, the same 4 options of choices repeat, some of them include the same boon with the exact same rarity). Next on Athena I am seeing the call in different rarities, so I guess that isnt locked down. Still just 4 "rolls" total that cycle.
Edit2: Same run, Ares again: Rerolled maybe 40 times (started taking notes a while into the rolls) and I got 6 different sets, but it is really weird the way they get presented, it basically rolled the same two sets maybe 70% of the time. (in my notes the two most prevalent sets have shown up 12 and 13 times each and only two of the total six options shown showed up after I started notating how many times stuff showed up, those two other sets showed up 2 and 3 times each during the time I took notes)