Hades
0 of 0

File information

Last updated

Original upload

Created by

MagicGonads

Uploaded by

MagicGonadsNEW

Virus scan

Safe to use

Tags for this mod

17 comments

  1. rhrns0
    rhrns0
    • member
    • 2 posts
    • 0 kudos
    Code for 'FishingPointChance' and 'RequiredMinRoomsSinceFishingPoint' is not currently working.

    RoomSetData has nested tables (BaseTartarus, RoomSimple01...) but the current code iterate RoomSetData table only once so that It cannot propery get/set data like FishingPointChance.

      for k, v in pairs(RoomData) do
      local room = ModUtil.SafeGet( RoomData, {k, "FishingPointChance"})
      if room then
    ModUtil.MapSetTable( RoomData[k], {
    FishingPointChance = config.FishingPointChance,
    FishingPointRequirements = {
      RequiredMinRoomsSinceFishingPoint = config.RequiredMinRoomsSinceFishingPoint,
    },
    })
    if config.ClearFishingPointRequirements then
    ModUtil.SafeSet( RoomData[k], {"FishingPointRequirements"}, {} )
    end
      end
    end


    This code should work. Thanks.

    1. MagicGonadsNEW
      MagicGonadsNEW
      • member
      • 125 posts
      • 0 kudos
      Your analysis is correct, but there's nothing wrong with using `v` directly, why do you add an extra layer of indexing everywhere?
      I've tested changing my code from RoomSetData to RoomData and that does work (removing the OverrideTableKeys call), so thanks.
    2. rhrns0
      rhrns0
      • member
      • 2 posts
      • 0 kudos
      You're absolutely right. I just couldn't think of it as a reference to the table.
      Thank you for making a good mod. :)
  2. albazeus
    albazeus
    • member
    • 46 posts
    • 1 kudos
    You should remove this file from your mod:

    Mods/GodAmongFish/Scripts/GodAmongFish.lua
    since it's not used.
    1. MagicGonadsNEW
      MagicGonadsNEW
      • member
      • 125 posts
      • 0 kudos
      True, I don't know why that happened
  3. sekretgv
    sekretgv
    • member
    • 3 posts
    • 0 kudos
    thank you so much, this is lifesaver
  4. MookittyBonnie
    MookittyBonnie
    • supporter
    • 826 posts
    • 37 kudos
    For reference, what are the game's default values?

    I just want to extend the perfect catch window a bit while leaving everything else default. Honestly I thought fishing was a nice distraction until I learned of the perfect catch timing, which just makes it stressful.
    1. kaydiechii
      kaydiechii
      • member
      • 42 posts
      • 1 kudos
      i figured out default values, you need to look under scripts @ fishingdata.lua

      NumFakeDunks = { Min = 0, Max = 3 },
      FakeDunkInterval = { Min = 2, Max = 5 },
      --WaitInterval = { Min = 1, Max = 5 },
      WarnInterval = { Min = 1, Max = 2 },
      GoodInterval = 0.34,
      PerfectInterval = 0.34,
      WayLateInterval = 1,
      GiveUpInterval = 3,


      Additionally, under roomdata.lua - allthough its important to know that FishingPointChance changes wildly depending on the room and level you're in, but i just globally set mine to .3 because that seems reasonable. to get a true default you'll need to retool this mod to be along the lines of RCMCGM - https://www.nexusmods.com/hades/mods/42. you could probably copy this or just remove the parts of the mod that affect fishing chance at all. this mod "modifies" the chance globally

      FishingPointChance = 0.10,
      FishingPointRequirements =
      {
      RequiredCosmetics = { "FishingUnlockItem" },
      RequiredMinRoomsSinceFishingPoint = 10,
    2. MagicGonadsNEW
      MagicGonadsNEW
      • member
      • 125 posts
      • 0 kudos
      if you want default values set the value to nil
  5. elementofharmony
    elementofharmony
    • member
    • 1 posts
    • 0 kudos
    Great mod. To uninstall, do we just remove the mod from the mod folder and run modimporter?
    1. MagicGonadsNEW
      MagicGonadsNEW
      • member
      • 125 posts
      • 0 kudos
      yes
  6. Kryzaa
    Kryzaa
    • BANNED
    • 212 posts
    • 3 kudos
    Thank you for reducing the grind for stuff!
  7. Vra5ka
    Vra5ka
    • member
    • 31 posts
    • 0 kudos
    Mod is working PERFECTLY. Its 100% chance of spawning Fishing Spots (coz you have Infinity Lure (from Charon's Well) - in all Rooms that have waters for fishing, of course.
    It has 100% (Perfect Catch) chance to hook fish from first bite\dunk (no fake dunks ofc) - all Rare Fishes are yours through entire Escape Attempt!

    Only one working and splendid Mod for you to become true God Among Fish!
  8. MagicGonadsNEW
    MagicGonadsNEW
    • member
    • 125 posts
    • 0 kudos
    I prefer to be contacted on Discord btw
    @Magic_Gonads#7347

    You will definitely see a more rapid response than the absymal 3 months it took me to fix this mod
  9. Vra5ka
    Vra5ka
    • member
    • 31 posts
    • 0 kudos
    Did this still would work?
    PSS: test it, mod is half dead
    1. StarslayerSomewhere
      StarslayerSomewhere
      • member
      • 5 posts
      • 0 kudos
      The mod successfully modifies fishingdata, but does not correctly modify roomdata (for the various room types), so you'll have improved fishing times, but not rate of room appearances.
    2. MagicGonadsNEW
      MagicGonadsNEW
      • member
      • 125 posts
      • 0 kudos
      This is fixed now