Code for 'FishingPointChance' and 'RequiredMinRoomsSinceFishingPoint' is not currently working.
RoomSetData has nested tables (BaseTartarus, RoomSimple01...) but the current code iterate RoomSetData table only once so that It cannot propery get/set data like FishingPointChance.
for k, v in pairs(RoomData) do local room = ModUtil.SafeGet( RoomData, {k, "FishingPointChance"}) if room then ModUtil.MapSetTable( RoomData[k], { FishingPointChance = config.FishingPointChance, FishingPointRequirements = { RequiredMinRoomsSinceFishingPoint = config.RequiredMinRoomsSinceFishingPoint, }, }) if config.ClearFishingPointRequirements then ModUtil.SafeSet( RoomData[k], {"FishingPointRequirements"}, {} ) end end end
Your analysis is correct, but there's nothing wrong with using `v` directly, why do you add an extra layer of indexing everywhere? I've tested changing my code from RoomSetData to RoomData and that does work (removing the OverrideTableKeys call), so thanks.
For reference, what are the game's default values?
I just want to extend the perfect catch window a bit while leaving everything else default. Honestly I thought fishing was a nice distraction until I learned of the perfect catch timing, which just makes it stressful.
i figured out default values, you need to look under scripts @ fishingdata.lua
NumFakeDunks = { Min = 0, Max = 3 }, FakeDunkInterval = { Min = 2, Max = 5 }, --WaitInterval = { Min = 1, Max = 5 }, WarnInterval = { Min = 1, Max = 2 }, GoodInterval = 0.34, PerfectInterval = 0.34, WayLateInterval = 1, GiveUpInterval = 3,
Additionally, under roomdata.lua - allthough its important to know that FishingPointChance changes wildly depending on the room and level you're in, but i just globally set mine to .3 because that seems reasonable. to get a true default you'll need to retool this mod to be along the lines of RCMCGM - https://www.nexusmods.com/hades/mods/42. you could probably copy this or just remove the parts of the mod that affect fishing chance at all. this mod "modifies" the chance globally
Mod is working PERFECTLY. Its 100% chance of spawning Fishing Spots (coz you have Infinity Lure (from Charon's Well) - in all Rooms that have waters for fishing, of course. It has 100% (Perfect Catch) chance to hook fish from first bite\dunk (no fake dunks ofc) - all Rare Fishes are yours through entire Escape Attempt!
Only one working and splendid Mod for you to become true God Among Fish!
The mod successfully modifies fishingdata, but does not correctly modify roomdata (for the various room types), so you'll have improved fishing times, but not rate of room appearances.
17 comments
RoomSetData has nested tables (BaseTartarus, RoomSimple01...) but the current code iterate RoomSetData table only once so that It cannot propery get/set data like FishingPointChance.
for k, v in pairs(RoomData) do
local room = ModUtil.SafeGet( RoomData, {k, "FishingPointChance"})
if room then
ModUtil.MapSetTable( RoomData[k], {
FishingPointChance = config.FishingPointChance,
FishingPointRequirements = {
RequiredMinRoomsSinceFishingPoint = config.RequiredMinRoomsSinceFishingPoint,
},
})
if config.ClearFishingPointRequirements then
ModUtil.SafeSet( RoomData[k], {"FishingPointRequirements"}, {} )
end
end
end
This code should work. Thanks.
I've tested changing my code from RoomSetData to RoomData and that does work (removing the OverrideTableKeys call), so thanks.
Thank you for making a good mod. :)
Mods/GodAmongFish/Scripts/GodAmongFish.lua
since it's not used.
I just want to extend the perfect catch window a bit while leaving everything else default. Honestly I thought fishing was a nice distraction until I learned of the perfect catch timing, which just makes it stressful.
NumFakeDunks = { Min = 0, Max = 3 },
FakeDunkInterval = { Min = 2, Max = 5 },
--WaitInterval = { Min = 1, Max = 5 },
WarnInterval = { Min = 1, Max = 2 },
GoodInterval = 0.34,
PerfectInterval = 0.34,
WayLateInterval = 1,
GiveUpInterval = 3,
Additionally, under roomdata.lua - allthough its important to know that FishingPointChance changes wildly depending on the room and level you're in, but i just globally set mine to .3 because that seems reasonable. to get a true default you'll need to retool this mod to be along the lines of RCMCGM - https://www.nexusmods.com/hades/mods/42. you could probably copy this or just remove the parts of the mod that affect fishing chance at all. this mod "modifies" the chance globally
FishingPointChance = 0.10,
FishingPointRequirements =
{
RequiredCosmetics = { "FishingUnlockItem" },
RequiredMinRoomsSinceFishingPoint = 10,
It has 100% (Perfect Catch) chance to hook fish from first bite\dunk (no fake dunks ofc) - all Rare Fishes are yours through entire Escape Attempt!
Only one working and splendid Mod for you to become true God Among Fish!
@Magic_Gonads#7347
You will definitely see a more rapid response than the absymal 3 months it took me to fix this mod
PSS: test it, mod is half dead