Sorry for this 1 year after posting but your mod doesn't work as intended. With Comprehension perk it should give points till 64% per skill but it gives points only till 61%. As formula said, when any skill=63 you get (70-63)*1.5/10=1.05 points rounded down 1 point so you should get to 64. That it didn't happen; it stopped at 61. Nice idea though.
@JethroKirby - Just tested it (no other mods loaded). Had a Sneak skill of 40. Read the book. Got 3 skill points.
Also set my Speech to 71. Read the book. Got 0 skill points. Didnt lose any at all. (Shouldn't lose any points regardless of your score, because the script only mods the score if the points gained are above 0).
You loading any other mods that affect the skill books by chance? Just wondering if something is conflicting.
Also- it works off your current skill score. So, if it is inflated or reduced because of anything, the points given by the book work off that. For example, if you normally have Sneak 40, but for some reason your Sneak skill is temp boosted to 50, you will only gain 2 points from reading the Sneak book.
edit: If the skill modifier is less than 0, it looks like you will still get the message saying something like "You gained -1 points". You dont lose any actually (skill only gets modded if the modifier is > 0), but the message says you do (bad placement in my script). Fixing it now.
I have to say that I'm impressed with this mod. My only concern is that it doesn't seem to work quite like you say.
I just read a skill book for a skill that was a 40 and it went up by 1 - should be 3 right? or 2?
I messed around with the player.forceav "skill" command to see what was going on and it seems that the highest a skill can be to gain a skill point is at 45 after that it gets 0. Also noticed that reading a book when your skill is over 61 reduces my skill by -2. Found that out by accident.
I believe that once you get these bugs worked out it will be awesome
P.S. If it helps, I tested with Sneak and Speech
*EDIT* Just did some more testing and it seems to work perfectly up to a skill of 35, once you get to 36 it reduces the skill points gained by 1 every five points (instead of the 10). I'm not much of a scripter but i'd say the formula is off?
Can't wait till you get it fixed, this mod makes skill books more useful and less overpowering if that makes any since ">
4 comments
With Comprehension perk it should give points till 64% per skill but it gives points only till 61%.
As formula said, when any skill=63 you get (70-63)*1.5/10=1.05 points rounded down 1 point so you should get to 64. That it didn't happen; it stopped at 61.
Nice idea though.
Scn BookSkillExplosivesScript
int SkillMod
Begin OnEquip
Set SkillMod to (50 - Player.GetAV Explosives) / 5
If (Player.HasPerk Comprehension == 1)
Set SkillMod to SkillMod * 1.50
Endif
If (SkillMod > 0)
Player.ModAV Explosives SkillMod
Endif
ShowMessage BookSkillMsg SkillMod
Player.RemoveItem BookSkillExplosives 1 1
ModPCMiscStat "Books Read" 1
End
I just change the formula to...
Set SkillMod to (70 - Player.GetAV Explosives) / 10
for all the skill books and it seems to work as intended. I just figured you might of accidentally put the wrong file in the archive.
Maybe I need to redownload?
Also set my Speech to 71. Read the book. Got 0 skill points. Didnt lose any at all. (Shouldn't lose any points regardless of your score, because the script only mods the score if the points gained are above 0).
You loading any other mods that affect the skill books by chance? Just wondering if something is conflicting.
Also- it works off your current skill score. So, if it is inflated or reduced because of anything, the points given by the book work off that. For example, if you normally have Sneak 40, but for some reason your Sneak skill is temp boosted to 50, you will only gain 2 points from reading the Sneak book.
edit: If the skill modifier is less than 0, it looks like you will still get the message saying something like "You gained -1 points". You dont lose any actually (skill only gets modded if the modifier is > 0), but the message says you do (bad placement in my script). Fixing it now.
I just read a skill book for a skill that was a 40 and it went up by 1 - should be 3 right? or 2?
I messed around with the player.forceav "skill" command to see what was going on and it seems that the highest a skill can be to gain a skill point is at 45 after that it gets 0. Also noticed that reading a book when your skill is over 61 reduces my skill by -2. Found that out by accident.
I believe that once you get these bugs worked out it will be awesome
P.S. If it helps, I tested with Sneak and Speech
*EDIT* Just did some more testing and it seems to work perfectly up to a skill of 35, once you get to 36 it reduces the skill points gained by 1 every five points (instead of the 10). I'm not much of a scripter but i'd say the formula is off?
Can't wait till you get it fixed, this mod makes skill books more useful and less overpowering if that makes any since