Thank for your mod, it very useful, can enjoy walking in night city, but look like "toggle walking state combat" isn't work properly. When I gettin a combat, the speed is 1.5, the combat end, and the speed turn to 3.5. Just on the contrary. I use v1.10.0. I had tried totally del the mod and redownload and reinstall, but the problem still their.
as for the combat toggle, i'm not too sure if you're describing a bug or if you're not using that option correctly (which is on me cause I could further describe the goal for this option).
first, to prevent both of us (mostly me as i'm typing this), let's first call the jogging state the default state (as that's the default state when you load into game), and the walking state as the toggled state (as you need to toggle it to enable it). we'll do this to reference a specific state without assuming its movement speed.
the goal for the combat option is to disable the toggled state when entering combat and re-enable it when leaving combat. this is only necessary for those where the speed for the toggled state is slow (an actual walk speed), as when entering combat when moving slow isn't ideal and could get annoying.
if instead, you are using the default movement speed values as it is when installing the mod (where the default state is slow and the toggled speed is faster), then this combat option shouldn't be used. as if you are in the toggled state, you're moving fast and you don't want to disable this state which would result you in moving slow.
i freshly installed the mod and it works as expected, here are the steps i followed after freshly installing the mod after removing the mod following the uninstalling instructions in the mod's description.
in the mod's menu:
set the walking speed to 1.5
set the jogging speed to 4
enable the "Toggle Walking With Combat"
optionally set a hotkey to enable/disable the toggled state
then reload a save.
when in game, you should be jogging. then enable the toggled state and you should be walking now.
find someone and start shooting them, once you enter combat (the map should say COMBAT), the toggled state is disabled and you should be jogging now.
run away and lose them to leave combat (the map should no longer say COMBAT) and the toggled state should be re-enabled, and you should be walking now.
hopefully you can follow this and it works as expected. to give a short summary, the combat option should only really be enabled if the movement speed are vanilla like values (the default state is a jog and the toggled state is slow) so that when it does disable the toggled state, you go back to jogging. hopefully this big text helps you understand.
Sorry for bother, and thank you for the detailed reply. I had tried what u said before my ask. Now I think I had found the problem. I install it by Vortex initially, but now install it manually. The good life come back. So vortex... whatever what, just kept using my Gorilla kiss their face, and enjoy NC. ty again.
i haven’t played phantom liberty yet (i think i’ve spent more time modding it then playing it) so i’m not sure about that, but i think the mod works when you become Johnny through his memories.
but i don’t think you’re asking about that, what do you mean when you say go for a walk? do you mean you want to be Johnny and walk around town as them?
if yes, as in you want to be another character and walk around night city as them, then nah i’m sorry that’s out of scope for the mod.
just want to thoroughly describe the bug that version 1.8.1 fixed here, as i didn't have enough space in the description.
this bug fix ensures that the flag that the mod uses to determine if the player has sprinted from the toggled state is reset regardless of whether if the persist system is enabled or not, as for previous versions, the flag would only be reset if the system was enabled.
this bug really only occurred if you repeatedly enabled and disabled the persist system during gameplay, meaning that, as an example, if you disabled the system and enabled the toggled state and then did an action that would cancel it (sprinting for example), you would go back to the default state because the system was disabled, but the flag was not reset and is kept as `true` permanently. if you would then re-enable the persist system and sprint from the default state, the mod will enable the toggled state because the flag was never reset.
this update just ensures that the flag is reset regardless of whether if the persist system is enabled or not. the system will continue to behave as expected from previous versions, it's just it will now also behave as expected when the system is enabled and disabled during gameplay.
Here are my thoughts, just personal suggestions~ If WASD is for walking, holding down shift is for running, and releasing it goes back to walking, double-clicking and holding shift is for sprinting, and releasing it goes back to walking, would this make the game more immersive?
i'm a bit confused on what you mean, could you explain it a bit more?
i think i kind of understand what you mean, at-least i understand you want the shift key to toggle the various movement states, which i agree. i think that would be a better alternative to having a walk state.
my idea would be something like this: - tap shift to toggle walking/jogging - hold shift to sprint
someone earlier said something like this and i'm messing around with it, if i get this i'll update ya.
Thank you for your reference, perhaps you did not understand what I meant. I feel that toggling the walking state with one click is very rigid, similar to the way the scanning button works. Pressing and holding is always more free than toggling the scan. What I mean is that pressing and holding is one state, and releasing it returns to the original state. In summary, pressing WASD direction alone is walking, holding shift is jogging, double-clicking and holding shift is sprinting. Of course, it doesn't have to be the keys I mentioned, you can do it according to your own ideas. After all, I'm just providing a thought, pressing and releasing is more free than toggling with one click. Do you understand what I'm saying?
You can also use WASD for jogging, after all, there will always be people who like a faster pace. If you want to walk, just hold down the walk button, sprinting can also be achieved by double clicking and holding WASD, this is also an interesting idea. In fact, it is to give up the switch button, do not switch under any circumstances, all operations are done by holding down. Holding down and releasing this button is much more flexible than switching by pressing once and then pressing again to restore. In short, thank you very much for the MOD you made, we are really lucky to have you!
i see what you mean, i'm also not a big fan of having a different button toggle the walking state too, i would prefer if everything is done with just shift.
i'm not sure if some inputs could be done (notably the double click and hold), but i think the others could be done. i am new to messing with input stuff so i'll continue to mess with it and if i get something (which is most likely going to be leaning on the inputs i mentioned) i'll update you and probably upload a file too.
it's been a bit sorry, but i've been messing with this and it seems impossible to do. at-least from what i know and been told, you can't make the player do an action through code, an action must be done through it's respective keybind.
my idea was to have shift do three things
tap to dodge
double tap to toggle walking
hold to sprint
in settings, these actions were binded to a non-used key and the mod would've handled everything through the shift key by seeing how long it was held to determine which action to do, but this wasn't possible because actions must be done through a keybind (the only exception is toggle walking, this can be enabled through code).
if i manually make all of the keys use the shift key, it would mess things up as as soon as you press the button, you would sprint/dodge. the best i've found and got was having shift tap be a dodge and hold to sprint.
Is it possible to make 'shift' going from walking to jogging and then do a double 'shift' to hold sprinting? I think that would make a better experience and control for me since I jog more than walking and sprinting in the game
it's been a bit sorry, but i've been messing with this and it seems impossible to do. at-least from what i know and been told, you can't make the player do an action through code, an action must be done through it's respective keybind.
my idea was to have shift do three things
tap to dodge
double tap to toggle walking
hold to sprint
in settings, these actions were binded to a non-used key and the mod would've handled everything through the shift key by seeing how long it was held to determine which action to do, but this wasn't possible because actions must be done through a keybind (the only exception is toggle walking, this can be enabled through code).
if i manually make all of the keys use the shift key, it would mess things up as as soon as you press the button, you would sprint/dodge. the best i've found and got was having shift tap be a dodge and hold to sprint.
however with the last update, i'm thinkin the mod is more or less done. if there's a bug, want for a feature, or to fix something in vanilla then for sure, but as it is now, i think it's feature complete.
I don't know if it's just me experiencing this, but I've realised something that's been throwing me off when using the mod.
In vanilla, you can only "crouch sprint" if you are in a "jogging state." If you were walking, then crouched and tried to "crouch sprint," it didn't work. With the mod, it's the opposite: you would have to first be walking, then crouch and proceed to "crouch sprint." If you were jogging and then tried to "crouch sprint," it didn't work (with both Persist System on or off).
Can you make it possible to "crouch sprint", regardless of what state you were in?
to be honest, i've always seen in the game's settings/code/etc. about a crouch sprint but i've never been able to do it. i remember being able to do it a long time ago, but now, whenever i sprint from a crouch, i stand sprint. maybe i've just been doing it wrong, from what you say, it looks like you have to be in the toggled state to crouch sprint
aight i'm lookin at the game's code and for some reason, they prevent you from crouch sprinting when entering crouch when the toggled state is enabled, meaning you can only crouch sprint in the default state. this is why the mod flips the condition, because it flips the speed for the default and toggled state (by default).
before i upload the fix in the mod, can you download this file (which is the raw text for this pastebin) as "Cyberpunk 2077\r6\scripts\WalkByDefault2.0\crouchSprint.reds" and play with it for a bit? what this file does is that it makes the game not check if the player had entered crouching from the toggled state, which should allow you to crouch sprint no matter what state you enter crouch from.
mess with this a bit and see if it works and tell me if it's good, if so then i'll upload it to the mod for future versions (tbh im just lazy to update the mod rn)
159 comments
as for the combat toggle, i'm not too sure if you're describing a bug or if you're not using that option correctly (which is on me cause I could further describe the goal for this option).
first, to prevent both of us (mostly me as i'm typing this), let's first call the jogging state the default state (as that's the default state when you load into game), and the walking state as the toggled state (as you need to toggle it to enable it). we'll do this to reference a specific state without assuming its movement speed.
the goal for the combat option is to disable the toggled state when entering combat and re-enable it when leaving combat. this is only necessary for those where the speed for the toggled state is slow (an actual walk speed), as when entering combat when moving slow isn't ideal and could get annoying.
if instead, you are using the default movement speed values as it is when installing the mod (where the default state is slow and the toggled speed is faster), then this combat option shouldn't be used. as if you are in the toggled state, you're moving fast and you don't want to disable this state which would result you in moving slow.
i freshly installed the mod and it works as expected, here are the steps i followed after freshly installing the mod after removing the mod following the uninstalling instructions in the mod's description.
hopefully you can follow this and it works as expected. to give a short summary, the combat option should only really be enabled if the movement speed are vanilla like values (the default state is a jog and the toggled state is slow) so that when it does disable the toggled state, you go back to jogging.
hopefully this big text helps you understand.
i haven’t played phantom liberty yet (i think i’ve spent more time modding it then playing it) so i’m not sure about that, but i think the mod works when you become Johnny through his memories.
but i don’t think you’re asking about that, what do you mean when you say go for a walk? do you mean you want to be Johnny and walk around town as them?
if yes, as in you want to be another character and walk around night city as them, then nah i’m sorry that’s out of scope for the mod.
Edit: Pretty easy to tweak PlayerLocomotion.player_locomotion_data_CrouchSprint_inline1 to change this if anyone else is interested.
And thank you nolvalir for making this!
and it’s good to see you figure it out but you have a good point and i’ll update the mod soon ish to do this for people who don’t know how to mod
this bug fix ensures that the flag that the mod uses to determine if the player has sprinted from the toggled state is reset regardless of whether if the persist system is enabled or not, as for previous versions, the flag would only be reset if the system was enabled.
this bug really only occurred if you repeatedly enabled and disabled the persist system during gameplay, meaning that, as an example, if you disabled the system and enabled the toggled state and then did an action that would cancel it (sprinting for example), you would go back to the default state because the system was disabled, but the flag was not reset and is kept as `true` permanently. if you would then re-enable the persist system and sprint from the default state, the mod will enable the toggled state because the flag was never reset.
this update just ensures that the flag is reset regardless of whether if the persist system is enabled or not. the system will continue to behave as expected from previous versions, it's just it will now also behave as expected when the system is enabled and disabled during gameplay.
i think i kind of understand what you mean, at-least i understand you want the shift key to toggle the various movement states, which i agree. i think that would be a better alternative to having a walk state.
my idea would be something like this:
- tap shift to toggle walking/jogging
- hold shift to sprint
someone earlier said something like this and i'm messing around with it, if i get this i'll update ya.
i'm not sure if some inputs could be done (notably the double click and hold), but i think the others could be done. i am new to messing with input stuff so i'll continue to mess with it and if i get something (which is most likely going to be leaning on the inputs i mentioned) i'll update you and probably upload a file too.
and thank you for the kind words:)
my idea was to have shift do three things
in settings, these actions were binded to a non-used key and the mod would've handled everything through the shift key by seeing how long it was held to determine which action to do, but this wasn't possible because actions must be done through a keybind (the only exception is toggle walking, this can be enabled through code).
if i manually make all of the keys use the shift key, it would mess things up as as soon as you press the button, you would sprint/dodge. the best i've found and got was having shift tap be a dodge and hold to sprint.
- pressing shift will toggle between jog/walk
- holding shift will be run
my idea was to have shift do three things
in settings, these actions were binded to a non-used key and the mod would've handled everything through the shift key by seeing how long it was held to determine which action to do, but this wasn't possible because actions must be done through a keybind (the only exception is toggle walking, this can be enabled through code).
if i manually make all of the keys use the shift key, it would mess things up as as soon as you press the button, you would sprint/dodge. the best i've found and got was having shift tap be a dodge and hold to sprint.
however with the last update, i'm thinkin the mod is more or less done. if there's a bug, want for a feature, or to fix something in vanilla then for sure, but as it is now, i think it's feature complete.
In vanilla, you can only "crouch sprint" if you are in a "jogging state." If you were walking, then crouched and tried to "crouch sprint," it didn't work. With the mod, it's the opposite: you would have to first be walking, then crouch and proceed to "crouch sprint." If you were jogging and then tried to "crouch sprint," it didn't work (with both Persist System on or off).
Can you make it possible to "crouch sprint", regardless of what state you were in?
i'll look into it and see
edit: just saw that it's a perk, lookin into it
before i upload the fix in the mod, can you download this file (which is the raw text for this pastebin) as "Cyberpunk 2077\r6\scripts\WalkByDefault2.0\crouchSprint.reds" and play with it for a bit? what this file does is that it makes the game not check if the player had entered crouching from the toggled state, which should allow you to crouch sprint no matter what state you enter crouch from.
mess with this a bit and see if it works and tell me if it's good, if so then i'll upload it to the mod for future versions (tbh im just lazy to update the mod rn)