As always, let me know if you have any issues; check the Bugs tab for known issues. And save before trading, just in case lol.
Currently, the return feature is not functioning perfectly, and to be honest, I implemented it more as an experiment than out of necessity. I recommend disabling it if you care about it not always working or if you do not intend to use it. It should not, however, make items disappear or anything like that.
May I ask how the game handles wares? Is it a tag? Been searching through game files but can't seem to find it. (or can it only be accessed through scripting?)
I don't know about game files (I basically only do scripting), but you can dynamically manage wares via scripting through the ServerItem.DontAddToHotbar component of an item entity. See my Volition Cabinet code (Helpers/Ware.lua) for more info.
Hi. I love the idea of the mod, but I seem to be having some issues.
If I understand correctly, when I open the trade screen, all items that have been added to wares should be sent from the other characters to my character's inventory. This doesn't happen. Using the 'Add Wares to Offer' button also doesn't add any wares that weren't in my character's inventory to begin with. When I check the inventory of the other party members after trying to trade, their items marked as wares have had that flag removed.
Don't know if it's relevant, but I've tried this with the vendors in the Guildhall so far (Severn and Sticky Dondo).
I get this message in red in the SE console:
bg3se::esv::lua::OsirisCallbackManager::RunHandler(): Osiris event handler failed: [string "SendWaresToTrader/Server/WareDelivery.lua"]:53: attempt to index a nil value (local 'partyMemberEntity') stack traceback: SendWaresToTrader/Server/WareDelivery.lua:53: in field 'SendPartyWaresToCharacter' SendWaresToTrader/Server/EventHandlers.lua:47: in function <SendWaresToTrader/Server/EventHandlers.lua:39>
I've got mod fixer and the script extender. Do you have any idea of what the issue could be? Am I screwing something up on my end? I'd appreciate any help!
Thanks for the report, I have never encountered this behavior but I might be able to fix the error causing that log. In any case, I didn't change the 'Add Wares to Offer' button, nor do I think that's (easily) doable
I fixed some issues, but I encountered two weird problems with sending the items around: the basic function modders use to move items around seems to not want to move items to different inventories if they are added to the trading slots, which is weird because the context menu allows you to do that... and 2 - stacked items aren't being sent back and I think I finally understood why; I'll refactor the code later and it will probably fix it. I'll release a 1.0.1 addressing the error from your console, but these aforementioned issues will persist. I don't know if the first one can even be fixed. Thanks again for the report.
It should work as long as the mod does not send items to other characters. I did test an earlier version in multiplayer, but the release should work as well. I would just avoid trading simultaneously.
Have you checked if these wares came from camp members? They currently aren't returned since it would unmark them as wares for some reason. Otherwise, it's hard to debug this without knowing the output from your Script Extender console.
22 comments
Currently, the return feature is not functioning perfectly, and to be honest, I implemented it more as an experiment than out of necessity.
I recommend disabling it if you care about it not always working or if you do not intend to use it. It should not, however, make items disappear or anything like that.
(or can it only be accessed through scripting?)
See my Volition Cabinet code (Helpers/Ware.lua) for more info.
I will try your mod :)
If I understand correctly, when I open the trade screen, all items that have been added to wares should be sent from the other characters to my character's inventory. This doesn't happen. Using the 'Add Wares to Offer' button also doesn't add any wares that weren't in my character's inventory to begin with. When I check the inventory of the other party members after trying to trade, their items marked as wares have had that flag removed.
Don't know if it's relevant, but I've tried this with the vendors in the Guildhall so far (Severn and Sticky Dondo).
I get this message in red in the SE console:
I've got mod fixer and the script extender. Do you have any idea of what the issue could be? Am I screwing something up on my end? I'd appreciate any help!
In any case, I didn't change the 'Add Wares to Offer' button, nor do I think that's (easily) doable
I'll release a 1.0.1 addressing the error from your console, but these aforementioned issues will persist. I don't know if the first one can even be fixed. Thanks again for the report.
Otherwise, it's hard to debug this without knowing the output from your Script Extender console.