It's a totally different concept. That mod seems to modify the behavior of Soul Trapping. This doesn't affect soul trapping at all - it provide an alternative way of filling soul gems.
I'm just impressed because I could never figure out how to make an skse plugin. I tried making a skse plugin that brings SAPI functions to skyrim using SKSE and was not succesful. i may study your code some more to see what is going on but I have 0 experience working with memory address pointers, only variables. I understand that variables are simply pointers with names to them, but I also found it to be above my head.
Wouldn't be better to fill the smallest soul gem big enough to hold the soul instead, which would only require to change the 293 line of main.cpp to: if (bestSoulGem == nullptr || dynamic_cast<TESSoulGem*>(thisEntry->type)->gemSize <= dynamic_cast<TESSoulGem*>(bestSoulGem->type)->gemSize && dynamic_cast<TESSoulGem*>(thisEntry->type)->gemSize >= soul_size)and optionally line 308 to: if (bestSoulGem ) since the gem being big enough for the soul it's now done earlier ?
it does make the plugin a bit more intensive, adding an extra check to each iteration of the loop, but I think it's better than having to remove your biggest gems from your inventory in order to collect a small soul as it happens in vanilla.
10 comments
will work well together?
what do you think Mr Spark ?
it does make the plugin a bit more intensive, adding an extra check to each iteration of the loop, but I think it's better than having to remove your biggest gems from your inventory in order to collect a small soul as it happens in vanilla.