Skyrim
0 of 0

File information

Last updated

Original upload

Created by

Spark01

Uploaded by

ElectricVersion

Virus scan

Safe to use

10 comments

  1. SayidD
    SayidD
    • member
    • 12 kudos
    Difference with thes mod ENANCED SOULTRAP (http://www.nexusmods.com/skyrim/mods/71073/?) ?
    1. Spark01
      Spark01
      • supporter
      • 9 kudos
      It's a totally different concept. That mod seems to modify the behavior of Soul Trapping. This doesn't affect soul trapping at all - it provide an alternative way of filling soul gems.
    2. SayidD
      SayidD
      • member
      • 12 kudos
      Compatibility?
      will work well together?
      what do you think Mr Spark ?
    3. Spark01
      Spark01
      • supporter
      • 9 kudos
      My guess would be that they'll work fine together. My mod doesn't touch soul trapping, so I can't imagine why they wouldn't.
  2. irswat
    irswat
    • premium
    • 7 kudos
    impressive code
    1. Spark01
      Spark01
      • supporter
      • 9 kudos
      Well thank you! I spent a long time on it Still ironing out some bugs though.
    2. irswat
      irswat
      • premium
      • 7 kudos
      I'm just impressed because I could never figure out how to make an skse plugin. I tried making a skse plugin that brings SAPI functions to skyrim using SKSE and was not succesful. i may study your code some more to see what is going on but I have 0 experience working with memory address pointers, only variables. I understand that variables are simply pointers with names to them, but I also found it to be above my head.
  3. amgepo
    amgepo
    • member
    • 138 kudos
    Wouldn't be better to fill the smallest soul gem big enough to hold the soul instead, which would only require to change the 293 line of main.cpp to: if (bestSoulGem == nullptr || dynamic_cast<TESSoulGem*>(thisEntry->type)->gemSize <= dynamic_cast<TESSoulGem*>(bestSoulGem->type)->gemSize && dynamic_cast<TESSoulGem*>(thisEntry->type)->gemSize >= soul_size)and optionally line 308 to: if (bestSoulGem ) since the gem being big enough for the soul it's now done earlier ?

    it does make the plugin a bit more intensive, adding an extra check to each iteration of the loop, but I think it's better than having to remove your biggest gems from your inventory in order to collect a small soul as it happens in vanilla.
    1. Spark01
      Spark01
      • supporter
      • 9 kudos
      Good idea! Thanks for the input. I'll probably add either an optional version of the plugin that does that, or just add that in the next update.
    2. amgepo
      amgepo
      • member
      • 138 kudos
      Sorry for not having accounted the && priority over || and glad you realized it was causing soul gems sometimes housing too big souls and fixed it