I have a fix for the root cause of this bug, told Egosoft and they agree it looks like the issue, so they should have it in a patch soon (not sure if it will arrive in later version of 1.51 or not).
I realized I should put it in a mod but then realized that since you already have a mod addressing the issue, with a couple hundred people using it, it would be better if you could update your mod to include this fix so all those people are more likely to see it. So if you are willing to do that, awesome. Here's the issue:
X4Ep1_Mentor_Subscription.xml, near line number 1858 (maybe +/- one or two lines, I added a couple comments higher up in my ver so not sure of count), in the Phase_TheExperiment_Criteria_Reaction cue, in the actions section, about 3 lines down is this:
The $DeliverFleetKeys{1} should instead be $DeliverFleetKeys.{$i}
That's the entire fix.
Unlike your fix, it won't help people whose favorite ship has already been designated the explosion target, so you might want to make it a separate download option? Or if you are super ambitious (or just less lazy than I am) you could try to work out a way to combine them.
Have a great day, and thank you for the workaround you provided!
That's some awesome find, mate! I'll have a looksie at it :-)
And I agree - adding it as an option seems like the better way to go. Tho combining them would be even less work, as I would just have to iterate the version number and add the difference to my existing mod package.
I'm not sure what "FleetKeys" means tho. I've seen that line too, but I just didn't know the content of $DeliverFleetKeys or why it would read 'no_equipment' there, since "equipment" sound like "anything of something", not like "less than 3 antimatter cells". I did not find any more instances of "no_equipment" or where the parameters get passed to this cue.
Did you test it tho? What will be the conditions when nothing else but 1->$i is being changed? Will it properly check for the 3 antimatter cells in cargo?
In any case: thanks for the addition - that really is something =)
I made the diff, packed the new mod and added your fix to this mod as additional main version. I hope people don't get confused. Plus I didn't test it yet - hopefully people will comment if it works.
Thanks again for your contribution! It's highly appreciated. Kudos +1 :-)
I just tried it with the new fix. Either I messed up the implementation, or this doesn't affect which ship is being picked.
To test it I flew with my Nemesis to the mission coordinates. At first nothing happened - but I encountered some pirates that just begged to be captured, so I did. Then I just darted over the mission area by chance when I was flying around, which triggered the next sequence of the mission that tells me to go to and wait at the next waypoint, which I did out of curiosity. Next thing: my Nemesis goes boooom.
Note that not a single one of my ships was carrying any Antimatter Cells. So while looking good, sadly it's not the fix for this bug.
@ssvx: Yesterday I saw your bug fix on the front page while browsing for new mods and today I got nuked by the bug. Awesome timing I guess. I thought "that dude meant this quest for sure" so gave it a try and what should I say? It just works! ™
Thanks a lot buddy. Here, have an endorsement and a Kudos.
Wow, that's a fast fix. Got that bug just yesterday - when my main ship blew up no matter how far i am from explosion site. Considered to restart game. Thank you.
@Lianopbs Yep, that is correct. Tho I guess the "main ship" is far more precious than the ship one wants to sacrifice :D ...plus you'll need to have another ship with a pilot that can pick you up. If you're very unlucky and take too much time looking around in the sector, then the main plot might proceed and target your one and only ship. If you're very, very unlucky, you might've just saved right after the mission cue locked your ship for destruction - then your save and progress is pretty much lost and you'd have to return to an even older save. The worst part of the bug is that the mission cue does *not* require the victim ship (or any ship) to carry antimatter cells. It does say so sometimes, but if you just lurk around the mission markers, you'll be terminated - no matter what ;-)
For me, it destroyed the right ship. It destroyed it in the wrong place and at the wrong time though.
The sequence: 1. Bought a Quasar, outfitted that, put a pilot in my starter ship. 2. Ordered starter ship to follow me, arrived at target site. 3. Boso told me my ship didn't have the required equipment. I knew that. 4. Starter ship arrived. Boso told me it needed to be evacuated. 5. Sent starter ship to nearby station to switch pilots since I can't get the pilot to bail out. 6. Kept a pirate from intercepting it. 7. Claimed abandoned pirate ship. 8. Empty pirate ship triggered the script; "evacuated" ship was now at the target site. 9. Starter ship blew up... while docked at a nearby station with the pilot aboard.
Sorry, I'm not exactly sure how to interpret your comment. Are you confirming that the game does weird things, or are you telling me this mod didn't work for you? Thanks in advance for clarification :-)
Give Feedback
12 comments
I realized I should put it in a mod but then realized that since you already have a mod addressing the issue, with a couple hundred people using it, it would be better if you could update your mod to include this fix so all those people are more likely to see it. So if you are willing to do that, awesome. Here's the issue:
X4Ep1_Mentor_Subscription.xml, near line number 1858 (maybe +/- one or two lines, I added a couple comments higher up in my ver so not sure of count), in the Phase_TheExperiment_Criteria_Reaction cue, in the actions section, about 3 lines down is this:
<do_all exact="$DeliverFleetKeys.count" counter="$i">
<do_if value="event.param.{$DeliverFleetKeys.{1}} == 'no_equipment'">
The $DeliverFleetKeys{1} should instead be $DeliverFleetKeys.{$i}
That's the entire fix.
Unlike your fix, it won't help people whose favorite ship has already been designated the explosion target, so you might want to make it a separate download option? Or if you are super ambitious (or just less lazy than I am) you could try to work out a way to combine them.
Have a great day, and thank you for the workaround you provided!
And I agree - adding it as an option seems like the better way to go. Tho combining them would be even less work, as I would just have to iterate the version number and add the difference to my existing mod package.
I'm not sure what "FleetKeys" means tho. I've seen that line too, but I just didn't know the content of $DeliverFleetKeys or why it would read 'no_equipment' there, since "equipment" sound like "anything of something", not like "less than 3 antimatter cells". I did not find any more instances of "no_equipment" or where the parameters get passed to this cue.
Did you test it tho? What will be the conditions when nothing else but 1->$i is being changed? Will it properly check for the 3 antimatter cells in cargo?
In any case: thanks for the addition - that really is something =)
Thanks again for your contribution! It's highly appreciated. Kudos +1 :-)
To test it I flew with my Nemesis to the mission coordinates. At first nothing happened - but I encountered some pirates that just begged to be captured, so I did. Then I just darted over the mission area by chance when I was flying around, which triggered the next sequence of the mission that tells me to go to and wait at the next waypoint, which I did out of curiosity. Next thing: my Nemesis goes boooom.
Note that not a single one of my ships was carrying any Antimatter Cells. So while looking good, sadly it's not the fix for this bug.
Yesterday I saw your bug fix on the front page while browsing for new mods and today I got nuked by the bug.
I thought "that dude meant this quest for sure" so gave it a try and what should I say? It just works! ™
Thanks a lot buddy. Here, have an endorsement and a Kudos.
/edit/ps
Haha, ich seh grad du hast ja selbst einige Fixes im Portfolio. Sauber!
@Lianopbs
Yep, that is correct. Tho I guess the "main ship" is far more precious than the ship one wants to sacrifice :D
...plus you'll need to have another ship with a pilot that can pick you up. If you're very unlucky and take too much time looking around in the sector, then the main plot might proceed and target your one and only ship. If you're very, very unlucky, you might've just saved right after the mission cue locked your ship for destruction - then your save and progress is pretty much lost and you'd have to return to an even older save.
The worst part of the bug is that the mission cue does *not* require the victim ship (or any ship) to carry antimatter cells. It does say so sometimes, but if you just lurk around the mission markers, you'll be terminated - no matter what ;-)
For me, it destroyed the right ship. It destroyed it in the wrong place and at the wrong time though.
The sequence:
1. Bought a Quasar, outfitted that, put a pilot in my starter ship.
2. Ordered starter ship to follow me, arrived at target site.
3. Boso told me my ship didn't have the required equipment. I knew that.
4. Starter ship arrived. Boso told me it needed to be evacuated.
5. Sent starter ship to nearby station to switch pilots since I can't get the pilot to bail out.
6. Kept a pirate from intercepting it.
7. Claimed abandoned pirate ship.
8. Empty pirate ship triggered the script; "evacuated" ship was now at the target site.
9. Starter ship blew up... while docked at a nearby station with the pilot aboard.