PSA for those using this mod and Joys of Efficiency - disable the fish ui from that mod, and don't use the afk fishing feature. First will always display that you caught seaweed instead of a fish (no effect on the catch), second one will change all catches to be seaweed. Haven't noticed any other issues.
I will try to look into this sometime in the coming days, but if you create an issue on the github page where the file is released and provide more details (settings, map, error logs, device, etc) i might be able to fix it faster.
I can try testing it. Will it work ok on an existing save?
UPDATE: Considering I just caught five of the same legendary fish in a row in town with zero battle, I don't think it works on an existing save. :) I'll have more time to check it out later after work on a new save. Thanks for your work on this!
Yeah this works as in "nothing crashes", but I keep getting wrong fish in wrong places at wrong times. For example, Midnight Squid in the morning in spring. So it seems some tweaking is still needed.
Is there any way you could upload your 1.6 compatible version on Nexus too? Would make it easier to follow any changes and comment.
I would upload a continuation on nexus if i managed to fix the issues mentioned and had done some more thorough testing. This mod has had so many changes that it is difficult to continue it without completely rewriting parts of it. The best way to track the progress might be to "Watch" the Github repo in the link.
At the moment it seems the update makes legend family fish to appear despite the Qi quest not being active. They're also catchable multiple times. Additionally, bull trout and minnow show the wrong visual when caught and reeled - a seaweed instead of a fish.
I keep getting fish spawns I really shouldn't be getting - Rare fish that need a quest to spawn being caught without the quest being active (Like the Mr. Qi family quest) - Fish that can only be caught during the night market on the sea floor (Blobfish) - Rare fish that are a catch once only per save also showing up again
its completely bugged out my spawn rates so I removed it :(
***Nexus being weird about replies, this was in response to Etherealneko***
Did this for me too. For me, it clashed with Esca's Modding Plugins (and probably any mod that messes with fish spawns and/or crab pots. Unfortunately I use that mod for its ability to completely disable the pass-out penalty, so its more important to me cause I'm real bad at getting to bed on time. I do really miss this mid though and hope they're compatible again soon, as they always were in 1.5.
This problem occurred during the game and happened in the summer when the game 2 crashed and got stuck. Can you check it [Content Patcher] The mod 'Teh's Fishing Overhaul' added custom token 'TehPers.FishingOverhaul/MissingJournalScraps', which failed and may not work correctly. See the log for details.
Just downloaded today and tried it out. Caught trash at first and no issues. But once I hooked a fish it froze and I was stuck there, time still passing. I had to close the game and restart the whole day
Was working decent for some hours. Then randomly the HIT turned reverse to TIH or was mirrored (sth. like that) and floats to left top. My rod keeps getting stuck in the water. I can "fix" that stuck by teleporting to allies with teleport-to-player. Smapi keeps producing INSANE amounts of red errors, endlessly, after that. Sadly happened after 4 restartes i tried + fishing different spots.
Will post the red lines when i catch them next time
[game] An error occurred in the base update loop: NullReferenceException: Object reference not set to an instance of an object. at TehPers.FishingOverhaul.Services.Setup.FishingRodPatcher.<>c.<StartFishingMinigame>b__16_0(Object tackle) in C:\Users\joxw1\OneDrive\Documents\_Projects\_Mods\Stardew Valley\tehs_StardewValleyMods\src\TehPers.FishingOverhaul\Services\Setup\FishingRodPatcher.cs:line 192 at System.Linq.Enumerable.SelectListIterator`2.ToList() at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source) at TehPers.FishingOverhaul.Services.Setup.FishingRodPatcher.StartFishingMinigame(FishingInfo fishingInfo, Item fishItem, FishingRod rod, FishEntry fishEntry, Boolean fromFishPond) in C:\Users\joxw1\OneDrive\Documents\_Projects\_Mods\Stardew Valley\tehs_StardewValleyMods\src\TehPers.FishingOverhaul\Services\Setup\FishingRodPatcher.cs:line 186 at TehPers.FishingOverhaul.Services.Setup.FishingRodPatcher.<>c__DisplayClass20_1.<DoFunction_Prefix>b__0(Int32 _) in C:\Users\joxw1\OneDrive\Documents\_Projects\_Mods\Stardew Valley\tehs_StardewValleyMods\src\TehPers.FishingOverhaul\Services\Setup\FishingRodPatcher.cs:line 919 at StardewValley.TemporaryAnimatedSprite.unload() in D:\GitlabRunner\builds\Gq5qA5P4\0\ConcernedApe\stardewvalley\Farmer\Farmer\TemporaryAnimatedSprite.cs:line 1029 at StardewValley.TemporaryAnimatedSprite.update(GameTime time) in D:\GitlabRunner\builds\Gq5qA5P4\0\ConcernedApe\stardewvalley\Farmer\Farmer\TemporaryAnimatedSprite.cs:line 1182 at StardewValley.Game1.UpdateOther(GameTime time) in D:\GitlabRunner\builds\Gq5qA5P4\0\ConcernedApe\stardewvalley\Farmer\Farmer\Game1.cs:line 6732 at StardewValley.Game1._update(GameTime gameTime) in D:\GitlabRunner\builds\Gq5qA5P4\0\ConcernedApe\stardewvalley\Farmer\Farmer\Game1.cs:line 4093 at StardewValley.Game1.Update(GameTime gameTime) in D:\GitlabRunner\builds\Gq5qA5P4\0\ConcernedApe\stardewvalley\Farmer\Farmer\Game1.cs:line 3199 at StardewModdingAPI.Framework.SCore.OnPlayerInstanceUpdating(SGame instance, GameTime gameTime, Action runUpdate) in SMAPI\Framework\SCore.cs:line 1083 [game] ...
Would you ever consider going back to this? I've been playing with this mod for years and this is the only fanmade 1.6 update I could find, it's so helpful! I know absolutely nothing about coding and modding, but I'd be happy to help in any way I can - possibly playtesting? SPOILER:
Spoiler:
Show
Does anybody know if the mod works with the golden treasure chests added in 1.6? I saw someone say it breaks with the iridium rods and only has the old chest loot, so I don't know whether it would be worth saving the fishing upgrades for last.
For anyone having the problem with the iridium rod freezing, i put a tackle on it and it worked fine for me so if your having a problem I'd try putting a tackle on the iridium rod, hope this helps
Unofficial one worked for me... But a bit too well... On new save, added mod 3 days in and it was raining, I caught a Spook Fish, Blob fish, and Son of Crimson fish at the beach. Also, small pond in the forest had several different fish in it. Uninstalling it, because that's a bit too broken, but some people might like it.
I am going to be just heart broken if this mod can't be updated for 1.6. This was a really great mod, it didn't feel like cheating or making fishing too easy it just made sense with the fishing. I really enjoyed trying to beat my streak score of perfectly caught fish!!! It made me try harder with fishing, when fishing in SDV is one of the last things I do. What a shame!
1063 comments
keep getting the bug where you cast and then its stuck and freezes
UPDATE: Considering I just caught five of the same legendary fish in a row in town with zero battle, I don't think it works on an existing save. :) I'll have more time to check it out later after work on a new save. Thanks for your work on this!
Is there any way you could upload your 1.6 compatible version on Nexus too? Would make it easier to follow any changes and comment.
- Rare fish that need a quest to spawn being caught without the quest being active (Like the Mr. Qi family quest)
- Fish that can only be caught during the night market on the sea floor (Blobfish)
- Rare fish that are a catch once only per save also showing up again
its completely bugged out my spawn rates so I removed it :(
Did this for me too. For me, it clashed with Esca's Modding Plugins (and probably any mod that messes with fish spawns and/or crab pots. Unfortunately I use that mod for its ability to completely disable the pass-out penalty, so its more important to me cause I'm real bad at getting to bed on time. I do really miss this mid though and hope they're compatible again soon, as they always were in 1.5.
[Content Patcher] The mod 'Teh's Fishing Overhaul' added custom token 'TehPers.FishingOverhaul/MissingJournalScraps', which failed and may not work correctly. See the log for details.
My rod keeps getting stuck in the water. I can "fix" that stuck by teleporting to allies with teleport-to-player.
Smapi keeps producing INSANE amounts of red errors, endlessly, after that.
Sadly happened after 4 restartes i tried + fishing different spots.
Will post the red lines when i catch them next time
[game] An error occurred in the base update loop: NullReferenceException: Object reference not set to an instance of an object.
at TehPers.FishingOverhaul.Services.Setup.FishingRodPatcher.<>c.<StartFishingMinigame>b__16_0(Object tackle) in C:\Users\joxw1\OneDrive\Documents\_Projects\_Mods\Stardew Valley\tehs_StardewValleyMods\src\TehPers.FishingOverhaul\Services\Setup\FishingRodPatcher.cs:line 192
at System.Linq.Enumerable.SelectListIterator`2.ToList()
at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
at TehPers.FishingOverhaul.Services.Setup.FishingRodPatcher.StartFishingMinigame(FishingInfo fishingInfo, Item fishItem, FishingRod rod, FishEntry fishEntry, Boolean fromFishPond) in C:\Users\joxw1\OneDrive\Documents\_Projects\_Mods\Stardew Valley\tehs_StardewValleyMods\src\TehPers.FishingOverhaul\Services\Setup\FishingRodPatcher.cs:line 186
at TehPers.FishingOverhaul.Services.Setup.FishingRodPatcher.<>c__DisplayClass20_1.<DoFunction_Prefix>b__0(Int32 _) in C:\Users\joxw1\OneDrive\Documents\_Projects\_Mods\Stardew Valley\tehs_StardewValleyMods\src\TehPers.FishingOverhaul\Services\Setup\FishingRodPatcher.cs:line 919
at StardewValley.TemporaryAnimatedSprite.unload() in D:\GitlabRunner\builds\Gq5qA5P4\0\ConcernedApe\stardewvalley\Farmer\Farmer\TemporaryAnimatedSprite.cs:line 1029
at StardewValley.TemporaryAnimatedSprite.update(GameTime time) in D:\GitlabRunner\builds\Gq5qA5P4\0\ConcernedApe\stardewvalley\Farmer\Farmer\TemporaryAnimatedSprite.cs:line 1182
at StardewValley.Game1.UpdateOther(GameTime time) in D:\GitlabRunner\builds\Gq5qA5P4\0\ConcernedApe\stardewvalley\Farmer\Farmer\Game1.cs:line 6732
at StardewValley.Game1._update(GameTime gameTime) in D:\GitlabRunner\builds\Gq5qA5P4\0\ConcernedApe\stardewvalley\Farmer\Farmer\Game1.cs:line 4093
at StardewValley.Game1.Update(GameTime gameTime) in D:\GitlabRunner\builds\Gq5qA5P4\0\ConcernedApe\stardewvalley\Farmer\Farmer\Game1.cs:line 3199
at StardewModdingAPI.Framework.SCore.OnPlayerInstanceUpdating(SGame instance, GameTime gameTime, Action runUpdate) in SMAPI\Framework\SCore.cs:line 1083
[game] ...
And i used no baits mostly and the treasure-tackle only
SPOILER: