i'm assuming that's your github bc it's the same profile pic. would you ever consider putting it on here so that we can have it included in our list on vortex?
I was able to reach out to Cat, but Cat only gave me permission to post the updated mod here in the original BAGI mod's forum, I was not allowed to upload a new mod.
I have a updated version for this mod. I have only tested it on Vanilla Stardew Valley 1.6 for now, haven't test with other packs, so no guarantee there isn't any bug.
For anyone want to try this out please report any issue.
Edit: The unofficial fix for this mod can be found in this Github.
I recommend uploading to nexus too, makes keeping track of updates through Vortex easier, might also assist with people providing constructive feedback in a place you can control.
I have this mod I really like called "Peachy Objects" that also needs the old BAGI mod, do you think you can make it compatible for this one you're making? Here it is: https://www.nexusmods.com/stardewvalley/mods/4908
Hi! In the manifest.json, I kept getting error messages from SMAPI saying that it couldn't load this mod. I found that you have the original mod as the Entry DLL, so in order to fix the SMAPI issue I had to make the following change in the manifest: FROM: "EntryDll": "BetterArtisanGoodIcons.dll", TO: "EntryDll": "EvenBetterArtisanGoodIcons.dll",
I don't know yet if the mod works since I made this change, but at the very least I'm no longer getting the SMAPI error.
Thanks for the report! The entry DLL was a very obvious change I somehow missed LOL I have a fix for it on the upcoming update, which it will also get an official upload on Nexus.
I have been getting several report on incompatibility with other mod, so I will look into that as soon as I can.
Thanks for your mod, I'm testing it now. Not sure if you'd be able to include this but I was working on a way to get a Peachy Objects patch for 1.6, maybe you could include Peachy assets as an additional option in yours? https://www.nexusmods.com/stardewvalley/mods/4908?tab=files
I don't wish to make an account on the stardew valley forum so I can post this in the Unofficial Modding thread, but for anyone suggesting this mod to be updated there, please make sure to provide the github for the mod, which you can find here: https://github.com/danvolchek/StardewMods/tree/master/BetterArtisanGoodIcons
I tried updating this myself, but I've never developed a mod for a game before, let alone stardew valley. Having programming experience doesn't really cover all the basis you need to know for this sort of thing. The documentation didn't really cover all the things replaced. For example, "honeyType" isn't a class of objects anymore, and it's something the mod uses. It says in the comments that now you're supposed to use this new class for it, but it doesn't say how as it doesn't exclusively correlate to the honey type, and I couldn't find any classes in that one that did. That was only one of the issues I ran into and there's still a few others that need to be addressed. I just didn't have the patience to try and figure out all this information even for a mod I really will not play without. Hopefully someone can do what I can't.
It's been requested a couple times, but no one's linked the github. Also it's been said to be "redundant" to update it by some, even though that's not necessarily true.
Because of the lack of activity on trying to update this, I'm considering taking another crack at it. I need help though. I wonder if there's like a discord modding server for Stardew that can help me figure out this HoneyType issue. If any of you know of one, lemme know.
I've never looked into it myself, but I remember some changes mentioned in the changelog: https://stardewvalleywiki.com/Modding:Migrate_to_Stardew_Valley_1.6
A search for honey shows that honey does in fact have a change to its data. I think this is the relevant part:
NEARBY_FLOWER_ID The item ID for a flower within 5 tiles of the machine, or -1 if no flower is found. For example, bee houses produce FLAVORED_ITEM Honey NEARBY_FLOWER_ID
The honeyType was the least of the issue actually, because it now use preservedParentSheetIndex to keep the value of parent item just like the rest of artisan goods, so the honeyType check statement can just simply be removed.
Other than method that need to be migrated due to fundamental function change in 1.6, the logic to identify if an item is Artisan Good was broken because all of the non-honey Artisan Good was moved to the new sprite sheet Objects_2 so they had a different index. In a simple word, the mod refuse to draw according to instruction because it falsely detected Wine as Ancient Drum. (FYI, It also detected Juice as Golden Relic, Pickle as Pufferfish, Jelly as Tuna)
Other than that, since the most of Artisan good is now ColoredObject instead of regular Object, I had to override the draw function in ColoredObject as well so it would draw non-honey Artisan Good properly.
AND, let's not forget, this mod does things that 1.6 does not, like realistic and specific coloring for wines and jams. 1.6 Update's coconut jam is brown, for example.
The last time i spoke to this creator they explained they did not really remember how one of their mods worked from retiring from modding so long ago so the likely hood of this mod being updated i would say is low. They do not mod for SDV anymore. Very greatful for their contributions to the community though.
Give Feedback
335 comments
https://github.com/chsiao58/EvenBetterArtisanGoodIcons/releases
Thanks for everyone who reported bug here. From here on you can report bug over at the Github.
The mod you were looking for couldn't be found
Can I just rename everything in EvenBetterArtisanGoodIcons to match?
I have a updated version for this mod. I have only tested it on Vanilla Stardew Valley 1.6 for now, haven't test with other packs, so no guarantee there isn't any bug.
For anyone want to try this out please report any issue.
Edit: The unofficial fix for this mod can be found in this Github.
I recommend uploading to nexus too, makes keeping track of updates through Vortex easier, might also assist with people providing constructive feedback in a place you can control.
Thanks, this will soon be uploaded to Nexus once I fixed a couple more things, which is very soon, so stay tuned.Edit: I was unable to get permission to upload so I will leave the Github page here.
Here it is: https://www.nexusmods.com/stardewvalley/mods/4908
FROM: "EntryDll": "BetterArtisanGoodIcons.dll",
TO: "EntryDll": "EvenBetterArtisanGoodIcons.dll",
I don't know yet if the mod works since I made this change, but at the very least I'm no longer getting the SMAPI error.
Thank you so much for updating it, by the way!
I have a fix for it on the upcoming update, which it will also get an official upload on Nexus.
I have been getting several report on incompatibility with other mod, so I will look into that as soon as I can.
I tried updating this myself, but I've never developed a mod for a game before, let alone stardew valley. Having programming experience doesn't really cover all the basis you need to know for this sort of thing. The documentation didn't really cover all the things replaced. For example, "honeyType" isn't a class of objects anymore, and it's something the mod uses. It says in the comments that now you're supposed to use this new class for it, but it doesn't say how as it doesn't exclusively correlate to the honey type, and I couldn't find any classes in that one that did. That was only one of the issues I ran into and there's still a few others that need to be addressed. I just didn't have the patience to try and figure out all this information even for a mod I really will not play without. Hopefully someone can do what I can't.
Because of the lack of activity on trying to update this, I'm considering taking another crack at it. I need help though. I wonder if there's like a discord modding server for Stardew that can help me figure out this HoneyType issue. If any of you know of one, lemme know.
https://stardewvalleywiki.com/Modding:Migrate_to_Stardew_Valley_1.6
A search for honey shows that honey does in fact have a change to its data. I think this is the relevant part:
NEARBY_FLOWER_ID The item ID for a flower within 5 tiles of the machine, or -1 if no flower is found. For example, bee houses produce
FLAVORED_ITEM Honey NEARBY_FLOWER_IDOther than method that need to be migrated due to fundamental function change in 1.6, the logic to identify if an item is Artisan Good was broken because all of the non-honey Artisan Good was moved to the new sprite sheet Objects_2 so they had a different index. In a simple word, the mod refuse to draw according to instruction because it falsely detected Wine as Ancient Drum. (FYI, It also detected Juice as Golden Relic, Pickle as Pufferfish, Jelly as Tuna)
Other than that, since the most of Artisan good is now ColoredObject instead of regular Object, I had to override the draw function in ColoredObject as well so it would draw non-honey Artisan Good properly.
However, if you ask me, this mod is still better in some aspects:
- Pickles icons actually showed some parts of the ingredient rather than a simple recolor
- Icons for Honey (which wasn't added in 1.6)
- A small icon shown for what kind of ingredient was used
- Prettier or more realistic product colorations
I do hope someone ports at least some of these featuresPretty please