Brilliant. Works just as it says on the box. And, I should mention, I'm testing this on Skyrim VR and there appears to be no problems with the whole fishing mechanic. Aside from being able to fish in any body of water, the activation by swinging the fishing rod is a great bonus. And it feels really natural in VR.
I looking to tweak the fishing experience further for an even better VR experience, but I'm not a real coder. I tend to kludge things until they break or roughly do the thing I want. So if it's okay, I might run a couple of oddities and ideas pass you.
I've decompiles the scripts, and have been mucking around in "ccbgssse001_fishingsystemscript", mainly the "SetupCameraAndPosition()" function. I commented out any Disable/EnablePlayerControls stuff along with any Imagespace fadeins/out and recompiled successfully.
The return of player control during fishing worked, and happily when you move far enough away from the floating rod, it shuts down and cleans itself up. However there are two oddities. Firstly, the rod does not unequip - and I just can not find how it actually unequipped in the first place. Secondly, the fade between activating and casting is still there, and again I can not find where this new fade is coming from. However, I did find that if you take out the MovePlayerToFishingMarker() function, there is no fade.
At this point I'm not sure if I've decompiled the script badly and my raw source is missing functions, or if some of this behaviour is hardcoded into the VR version, or (most likely) I'm just terrible at this and am missing something incredibly obvious.
Now this might interest you, in that I tried also taking out the MovePlayerToFishingMarker() along with your mod (because in your mod, the fishingmarker comes to the player, so it is kinda redundant). Testing in game, sure enough I was able to activate the fishing and immediately went into the casting animation without a visible shift or any kind of fade to black. This was great, however, I now had the problem of still having the fishing rod equipped, and could initiate new fishing instances by swinging it - which of course I did, numerous times, and was soon surrounded by floating fishing rods.
Anyway, I thought that if you can sort the unequipping issue, this might be a nice upgrade to your mod. Additionally, you might also appreciate to know that this mode appears to working just fine in VR (with the right VR version of po3's Extender).
So many thanks again for this mod, and I'll will be interested to hear what you think.
Meanwhile, I'll start on my next kludge which is to make the fish drop on the ground in front of the player, rather than float briefly in front of you then disappear into your bag. That way you get to play with the fish and HIGGS - maybe even be able to toss it back in the water if it's not a fish you want.
The system requires that you have the rod equipped in order to know what rod you want to use. But you can rewrite it so it remembers your swing rod and unequip it
Thanks for that. Well, I had a played around and I got the unequip/equip fishing rod thing going. I also had a first stab at dropping caught fish at my feet, which ended up being relatively simple. Mostly just a lot of commenting out stuff. I tried to be tidier about when you can interact with stuff, so that I don't accidently fire off a lot of fishing instances, but haven't quite caught them all. I still can get the occasion extra floating fishing pole that I can't get rid of. Still, if I'm not too twitchy with the fishing pole, overall it's quite a fun experience.
Followed the river down to Whiterun, trying out fishing wherever I could get close enough to the water. No frozen body, no teleports, no fadeouts/fadeins, no floating fish that magically put themselves in my backpack. Fished up a bottle of ale from the river, picked it up off the ground and drank it right there, thanks to HIGGS. Ah fun times. (And, sheesh! Are those troll skulls big!)
If you are interested, I can send you the source and compiled script (though I'm not sure what the best way to do that is) and I'm happy for you to do whatever you like with it. Thanks for the pointers, and thanks especially for this mod.
Hello friend! I am wondering which mod did you use for fishing in VR? I only find an old mod Fishing in Skyrim VR?? that just provided a port to an elder mod Fishing in Skyrim? and posts said the experience in that mod is not very well...
Hey Sabenn, not sure if wSkeever has any plans to update with your edits for a VR version but the need is definitely there! As you can't upload it without his permission, would you be able to share all the exact edits you made? It would be much appreciated by those with VR like myself :)
Do a power attack (pull trigger) while swinging the "fishing rod" near water and it'll work in VR. Without doing a power attack (without the trigger) it doesn't work which is fine. I like the trigger 'cause it's like pulling the trigger on your casting reel.
Great mod, thank you. I looked for awhile (o^-^)b Endorsed PS. I did a little SkyrimVR subreddit post on this mod and quoted a bit of what Sabenn said below too (without attribution).
First, thank you so much for this awesome mod, I cannot play without it anymore.
I've noticed a strange bug, possibly caused by PO3's Papyrus Extender ? When I use version 5.7.0 of the extender, everything's fine, but if I update it to its latest version (5.8.0), your mod always considers that I'm too far from the water when I try to fish, even though I'm standing in front of a body of water as I should be.
What is your opinion on this bug ? I'm using the 1.6.640 version of Skyrim, and the version 5.0 of your mod.
Just wanted to confirm something, is it possible to get followers stuck on the "fishing idle package"? I see that you added an array of followers and even support for up to 10 followers, which is very cool. But looking at the ccBGSSSE001_FishingSystemScript for the Fishing System quest, this function is called on one of the "Clean up" events: function ResumeFollowerBehavior() Actor follower = FollowerAlias.GetActorRef() Actor dog = DogAlias.GetActorRef() ccBGSSSE001_FishingFollowerIdleQuest.Stop() if follower follower.EvaluatePackage() endif if dog dog.EvaluatePackage() endif endFunction As it seems, it only revaluates the package for the "Follower01".. Maybe the array is supposed to be used there now, or somewhere else?
Hmm, makes sense. The quest should be stopped by this point, but something seems to make the packages stay on the followers. I made some changes to the fishing system script, but not this function in particular. I'll keep investigating this.
I got serana and inigo stuck around the fishing spot , When I realized they are missing but only sofiya following me , I moveto 2002b74 then I found that. I did a fishing again and fixed it. I wonder if you can tell me how did you change this script , it will be helpful to me ,Thanks
I found this note, Maybe this problem is caused by the CC fishing ? Vanilla game only need to consider 1 follower ? if any upgrade or fix path for this will be helpful , thanks for your answer anyway : )
Never mind, I got it to work right. The problem had something to do with the save file I loaded. It started working correctly after loading a previous save.
Didn't work, swinging fish rod near water just does that chop. I have improved camera, I think that be the culprit, installed all requirements/ turned off scripted events IC nothing.
This is rad! I've even gotten it to work while aboard ships using Vicn's Animated Ships mod although most of the time it just places you on the ground (ocean floor) when you enter fishing mode.
222 comments
If fishing spot is not available, will fall back to sensible conditional defaults.
It will take more time to catch fish/lanter/pearl?
I looking to tweak the fishing experience further for an even better VR experience, but I'm not a real coder. I tend to kludge things until they break or roughly do the thing I want. So if it's okay, I might run a couple of oddities and ideas pass you.
I've decompiles the scripts, and have been mucking around in "ccbgssse001_fishingsystemscript", mainly the "SetupCameraAndPosition()" function.
I commented out any Disable/EnablePlayerControls stuff along with any Imagespace fadeins/out and recompiled successfully.
The return of player control during fishing worked, and happily when you move far enough away from the floating rod, it shuts down and cleans itself up. However there are two oddities. Firstly, the rod does not unequip - and I just can not find how it actually unequipped in the first place. Secondly, the fade between activating and casting is still there, and again I can not find where this new fade is coming from. However, I did find that if you take out the MovePlayerToFishingMarker() function, there is no fade.
At this point I'm not sure if I've decompiled the script badly and my raw source is missing functions, or if some of this behaviour is hardcoded into the VR version, or (most likely) I'm just terrible at this and am missing something incredibly obvious.
Now this might interest you, in that I tried also taking out the MovePlayerToFishingMarker() along with your mod (because in your mod, the fishingmarker comes to the player, so it is kinda redundant). Testing in game, sure enough I was able to activate the fishing and immediately went into the casting animation without a visible shift or any kind of fade to black. This was great, however, I now had the problem of still having the fishing rod equipped, and could initiate new fishing instances by swinging it - which of course I did, numerous times, and was soon surrounded by floating fishing rods.
Anyway, I thought that if you can sort the unequipping issue, this might be a nice upgrade to your mod. Additionally, you might also appreciate to know that this mode appears to working just fine in VR (with the right VR version of po3's Extender).
So many thanks again for this mod, and I'll will be interested to hear what you think.
Meanwhile, I'll start on my next kludge which is to make the fish drop on the ground in front of the player, rather than float briefly in front of you then disappear into your bag. That way you get to play with the fish and HIGGS - maybe even be able to toss it back in the water if it's not a fish you want.
Followed the river down to Whiterun, trying out fishing wherever I could get close enough to the water. No frozen body, no teleports, no fadeouts/fadeins, no floating fish that magically put themselves in my backpack. Fished up a bottle of ale from the river, picked it up off the ground and drank it right there, thanks to HIGGS. Ah fun times. (And, sheesh! Are those troll skulls big!)
If you are interested, I can send you the source and compiled script (though I'm not sure what the best way to do that is) and I'm happy for you to do whatever you like with it. Thanks for the pointers, and thanks especially for this mod.
Without doing a power attack (without the trigger) it doesn't work which is fine. I like the trigger 'cause it's like pulling the trigger on your casting reel.
Great mod, thank you. I looked for awhile (o^-^)b
Endorsed
PS. I did a little SkyrimVR subreddit post on this mod and quoted a bit of what Sabenn said below too (without attribution).
First, thank you so much for this awesome mod, I cannot play without it anymore.
I've noticed a strange bug, possibly caused by PO3's Papyrus Extender ? When I use version 5.7.0 of the extender, everything's fine, but if I update it to its latest version (5.8.0), your mod always considers that I'm too far from the water when I try to fish, even though I'm standing in front of a body of water as I should be.
What is your opinion on this bug ? I'm using the 1.6.640 version of Skyrim, and the version 5.0 of your mod.
Nevermind, i'm just stupid, didn't installed powerofthree's Papyrus Extender
Just wanted to confirm something, is it possible to get followers stuck on the "fishing idle package"? I see that you added an array of followers and even support for up to 10 followers, which is very cool.
But looking at the ccBGSSSE001_FishingSystemScript for the Fishing System quest, this function is called on one of the "Clean up" events:
function ResumeFollowerBehavior()
As it seems, it only revaluates the package for the "Follower01".. Maybe the array is supposed to be used there now, or somewhere else?Actor follower = FollowerAlias.GetActorRef()
Actor dog = DogAlias.GetActorRef()
ccBGSSSE001_FishingFollowerIdleQuest.Stop()
if follower
follower.EvaluatePackage()
endif
if dog
dog.EvaluatePackage()
endif
endFunction
Thanks for your time.
The quest should be stopped by this point, but something seems to make the packages stay on the followers. I made some changes to the fishing system script, but not this function in particular.
I'll keep investigating this.
Thank you.
This mod has nothing to do with what you catch
It likely is the culprit. I can still fish at normal places, though, so...might have to just make due, I guess.